1435 Коммитов

Автор SHA1 Сообщение Дата
Ben Schumacher
eb35e83152 [MM-54850] Use request-specific logger in channels/app/admin_advisor.go (#24859) 2023-10-12 08:23:57 +02:00
Agniva De Sarker
3dd9e3715c Goodbye, GraphQL (#24827)
```release-note
NONE
```
2023-10-12 09:47:35 +05:30
Deepayan Mukherjee
77ee4d93b7 [MM-24856] User request specific loggers in channels/api4/system.go (#24881)
* replace global mlog with local c.Logger and setInvalidParam with setInvalidParamWithErr if relevant

Signed-off-by: Deepayan Mukherjee <deepayanmukherjee1312@gmail.com>

* replace global mlog.Info with local c.Logger.Info

Signed-off-by: Deepayan Mukherjee <deepayanmukherjee1312@gmail.com>

---------

Signed-off-by: Deepayan Mukherjee <deepayanmukherjee1312@gmail.com>
2023-10-11 17:34:49 +02:00
Ben Schumacher
13c05a571f Migrate store methods to use request.Context instead of context.Context (#24836) 2023-10-11 13:08:55 +02:00
Ben Schumacher
0d5a8b8841 Add whitespace linter (#24855) 2023-10-11 10:13:36 +02:00
Harshil Sharma
06765b1f44 Displayed error message for already used channel name (#24860)
* WIP

* Displayed existing channel name error

* refactoring
2023-10-10 17:41:49 +05:30
Jesse Hallam
47bfa2b66b Pass a logger instead of embedding on job (#24650)
* pass a logger instead of embedding on job

* leverage mlog.Millis

* use worker logger with HandleJobPanic

* rely on existing LogClone instead

* guard Job.LogClone against nil Job

* s/workername/worker_name

* Revert "rely on existing LogClone instead"

This reverts commit 17303cbac90d4b01815abca1309b78b97de368fb.

* Revert "guard Job.LogClone against nil Job"

This reverts commit f1ae22dee58d76f084582857830ffe8d4c546d7e.
2023-10-09 11:04:55 -03:00
Ben Schumacher
aad25be4e1 [MM-54434] Use job.Logger to capture ldap logs (#24493) 2023-10-06 22:43:21 +02:00
Delaney Sylvans
d61364a24a [MM-54024] Handle JSON nulls when unmarshalling in api4 (#24656)
* handle JSON nulls when unmarshalling in api4

* catch more cases of unhandled JSON null

* fix lint issues

* remove unnecessary checks

* add bot tests for null values

* fix bot_test lint

* add channel null tests

* add group null tests

* add notify_admin null tests

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-10-05 19:25:59 +05:30
Daniel Espino García
5f0aac70ac [MM-54497]Fix updatePost props (#24543)
* Fix updatePost props and plugin hooks

* Add more tests

* Minor naming improvement

* Revert plugin hooks changes

* Rename post variable

* Fix app layers

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-10-05 09:40:53 +02:00
Ibrahim Serdar Acikgoz
8e7e5c8775 server/app: remove websocket_router.go (#24680) 2023-10-04 10:54:40 +03:00
Caleb Roseland
b7f1a7f262 MM-52792: Update createPost, updatePost, & patchPost (#24195) 2023-10-03 09:51:07 -05:00
Agniva De Sarker
b9c50641db MM-54580: Fix panic in jobs/base_workers.go (#24631)
If GetJob fails, we would return a nil job and then try to log
with that. To prevent this, we keep a reference to the old job
and log with that in the error case.

https://mattermost.atlassian.net/browse/MM-54580

```release-note
Fix a panic where a simple worker would crash if if failed to get a job.
```
2023-10-03 07:55:38 +05:30
Scott Bishel
ae1decd1a7 MM-54555 - Include channel name in error (#24614)
* include channel name in error

* update multiple returns

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-10-03 06:55:21 +08:00
Ibrahim Serdar Acikgoz
53a0f8da27 Add limiting ability to log fields (#24251) 2023-09-28 19:28:40 +03:00
Elias Nahum
cd9e0d7509 fix mobile oauth tests (#24610)
* fix mobile oauth tests

* update test description

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-09-27 12:18:56 +03:00
Daniel Espino García
c42839094e Fix flaky test introduced in #24495 (#24603) 2023-09-26 09:48:06 +02:00
Ben Schumacher
35c1639ee3 [MM-54291] Add goroutines profile to support package (#24478) 2023-09-25 20:22:25 +02:00
Elias Nahum
7cd9780399 MM-54489 restrict mobile oauth/saml redirect to native app schemes (#24554)
* MM-54489 restrict mobile oauth/saml redirect to native app schemes

* replace slices package with contains function in utils

* use the existing Contains utility function

* Fix unit tests

* more test cases

* fix cfg.NativeAppSettings.AppCustomURLSchemes assignment

* Append mmauth to cfg.NativeAppSettings.AppCustomURLSchemes in unit test
2023-09-25 20:46:45 +03:00
Daniel Espino García
6c48cca78f Fix MM-54027 (#24495)
* Fix MM-54027

* Add tests

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-09-25 11:08:58 +02:00
Ben Schumacher
845ea2a984 [MM-54290] Add CPU profile to support package (#24477) 2023-09-25 11:00:33 +02:00
Ben Schumacher
153ebc31d7 [MM-54289] Add heap profile to support package (#24476) 2023-09-25 09:46:15 +02:00
Daniel Espino García
88d043a971 Make GM behave as DM (#24289)
* Make GM behave as DM

* Fix lint

* Add desktop notification special behavior

* Change notification preferences menu

* Make changes to the GM channel intro

* Fix tests

* Fix i18n and style lint

* Add system notice and update style

* Fix style and fix tests

* Fix tests

* Handle push notifications as desktop notifications

* Fix tests

* Add test and default GMs to none when user level config is none

* Fix test

* Update only for mentions text

* Add tests

* Fix lint

* Fix lint
2023-09-19 15:29:57 +02:00
Harshil Sharma
39d6cb8008 MM-53125 Add feature to convert group message to private channel (#24421)
* Added convert to channel menu item

* WIP

* refactored channel name input field and created conversion modal

* style

* style

* WIP

* wip

* Created API to fetch common teams of GM members

* Added UI for all members deactivated

* Fetched common teams in client

* WIP

* Added a required attribute to DropdownInput component

* Fixed a case with dropdown input required flag

* WIP

* API first draft

* Genetayed layers and mocks

* Fixed create channel bug

* WIP

* Added cache invalidation

* Calling API from client

* Updated API to accept name and display name as well

* WIP

* Moved converted GM to correct category

* Style fixes

* Added logic to move user to new team/channel after GM conversion

* Prevented guest user from performing action

* Added loading indicator

* Added smoother height transistion when loading finishes

* UI imporvements

* WIP

* Formatted GM conversion message on client side

* lint fix

* Moved convert option from sidebar menu to channel header menu

* Some cleanup

* Updated server layers

* Fixed i18n

* Fixed types

* Fix server i18n

* Fixed channel creation bug

* Added store test for GetCommonTeamIDsForMultipleUsers

* Server tests done

* Updated snapshots

* Updated layers

* lint fix

* Update tests

* For CI

* lint

* restored debug code

* Used user ID instead of username in channel conversion post

* WIP

* Review fixes

* LInt fixes

* Test fix

* WIP

* WIP

* WIP

* wip

* Review fixes, lots of them

* Review fix

* Disabled WIP test

* test

* Cleanup

* Test fix

* removed testing line

* Fixed incorrect default message

* Review fixes

* Fixes

* lint and i18n fix

* Setting category on server side

* updated i18n

* Updated tests

* Added tests

* Refs cleanup

* added test

---------

Co-authored-by: Harshil Sharma <harshilsharma@Harshils-MacBook-Pro.local>
2023-09-19 14:41:34 +02:00
Devin Binnie
11cdd2b66b Fix flaky/incorrect desktop token test, clarify the parameter names (#24565)
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-09-19 08:49:51 +02:00
Caleb Roseland
9a3b503169 MM-54505: re-enable remote marketplace functionality (#24561) 2023-09-15 12:17:53 -05:00
Scott Bishel
64fabbeed3 MM-54123 Add group slash command (#24553)
* adding group members to channel initial commit

* adding group to channel functionality along with add new team members

* fixing circular dependency

* fixing e2e and other optimizations

* adding e2e tests for adding group members to channels

* cypress lint

* fixing comments

* adding count to button

* improvements

* adjusting some stuff from PR comments

* remove ability to add user to team, update message for non-team members

* remove adding to team from add groups functionality

* update misspelled variable

* lint and unit test fixes

* add tests, cleanup

* lint fix

* revert package-lock.json

* fixes for cypress tests

* rename TeamInviteBanner to TeamWarningBanner, since invites are no longer allowed

* update for warning

* lint fixes

* cleanup

* fix failing e2e tests

* update slash command for user groups

* revert package-lock

* remove unused function

* update based on feedback

* update tests for last change

* i18n-extract, reorder

* retrieve and display user name

---------

Co-authored-by: Benjamin Cooke <benkcooke@gmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-09-15 11:00:41 -06:00
Jesús Espino
17ff2049ec Adding 'MessageHasBeenDeleted' hook to plugins (#22476)
* Adding 'MessageHasBeenDeleted' hook to plugins

* Remove debug logs

* Add unit test

* Bumping the required version

* Fix CI problems

* Increasing the minimum version

* go fmt

---------

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-09-14 18:33:22 +02:00
Ben Cooke
bc4904e5b3 MM-54123 Add group to channel (#22954)
* adding group members to channel initial commit

* adding group to channel functionality along with add new team members

* fixing circular dependency

* fixing e2e and other optimizations

* adding e2e tests for adding group members to channels

* cypress lint

* fixing comments

* adding count to button

* improvements

* adjusting some stuff from PR comments

* remove ability to add user to team, update message for non-team members

* remove adding to team from add groups functionality

* update misspelled variable

* lint and unit test fixes

* add tests, cleanup

* lint fix

* revert package-lock.json

* fixes for cypress tests

* rename TeamInviteBanner to TeamWarningBanner, since invites are no longer allowed

* update for warning

* lint fixes

* cleanup

* fix failing e2e tests

* update messages to not use markdown

---------

Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-09-14 08:43:44 -06:00
Claudio Costa
b4a47803e6 [MM-54456] Fix potential read after write issue when loading license (#24524)
* Fix potential read after write issue when loading license

* Use upsert
2023-09-13 14:47:12 -06:00
Felipe Martin
f65dad83bb Migrate emojiStore to use request.CTX instead of context.Context (#24514)
* migrate emojistore to request.ctx

* use mlog.CreateConsoleTestLogger

* Add comment to WithMaster and RequestContextWithMaster
2023-09-11 17:07:29 +02:00
David Janda
6e6668b88b [GH-16800]: Refactor raw SQL to query builder in group_store.go - part 2 (#24254)
* Use builder in GetMember

* Use query builder in GetByUser

* Use query builder in GetMemberUsers

* Use query builder in GetNonMemberUsersPage

* Use query builder in PermanentDeleteMembersByUser

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-09-11 15:17:26 +03:00
Sinan Sonmez (Chaush)
71fb10ae7a MM-54260: In Browse Channel Modal fix member count on private channels and when there is only 1 member in the channel (#24452) 2023-09-09 14:47:06 +05:30
Doug Lauder
5e7d1c6f9e MM-37511 Add userid to http logs (#24516)
* include user_id in http logs
2023-09-08 18:24:34 -04:00
Ben Schumacher
42e988132c [MM-46134] Add additional checks for PostStore/PostgreSQL/GetForThread/Pagination (#24458)
* Use require

* Add additonal length checks

* Remove Skip

* Manually set CreateAt
2023-09-08 16:50:53 +02:00
Ben Schumacher
a32e793982 Fix logger panic in migration scheduler (#24509)
Automatic Merge
2023-09-08 17:27:36 +03:00
Scott Bishel
15faf4a69c update to use AppError.Where() to differentiate errors (#24379)
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-09-08 08:17:58 -06:00
David Janda
afeeacb94a Use GetBuilder and SelectBuilder to remove some boilerplate in group_store.go (#24255) 2023-09-07 18:28:39 +03:00
Agniva De Sarker
acdfefe456 Revert "MM-53879: Fix recursive loading of license (#24200)" (#24498)
This reverts commit dd73c2af0f.
2023-09-07 20:58:20 +05:30
Ibrahim Serdar Acikgoz
0e84ccb383 Bump Go version to v1.20 (#24439) 2023-09-07 13:06:18 +03:00
Ben Schumacher
30b12f199b [MM-54132] Use annotated logger for log messages from jobs (#24275) 2023-09-07 08:50:22 +02:00
Ben Cooke
791ee40568 [MM-53291] Data retention improvements (#24253)
* adding new migration for RetentionIdsForDeletion, changing logic for deleting orphaned reactions. Updating delete user and channel endpoints to remove respective reactions
2023-09-06 08:25:27 -04:00
Ben Schumacher
b2f36c7cdf [MM-54318] Add file storage information to support package (#24474)
* Reorder stats in support package struct

* Add file storage information to support package

* Add clusterID

* Change method name to DriverName

* Ordering

* Fix test
2023-09-06 09:21:25 +02:00
Agniva De Sarker
4482ba0fd0 MM-43341: Allow test to run (#24470)
When I fixed the flaky test in https://github.com/mattermost/mattermost/pull/20140,
I actually forgot to uncomment this line to allow the test to run.

Thanks to @hanzei for spotting this.

https://mattermost.atlassian.net/browse/MM-43341
```release-note
NONE
```

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-09-06 10:39:58 +05:30
Ben Schumacher
2c893d8c05 [MM-43252] Fix flaky TestPreparePostListForClient (#24407)
* Fix flaky TestPreparePostListForClient

* Ignore order of returned elements

* Revert timeout increase
2023-09-06 07:07:58 +02:00
Christopher Poile
b6f2c8205e MM-54219 - Fix: Improve limits on redirectLocationDataCache (#24429)
* ignore redirect locations over certain length

* maybe the link isn't necessary

* remove unrelated debugging line

* PR comments
2023-09-05 14:04:14 -04:00
KyeongSoo Kim
de000e888d MM-53687: Block changes to name, display name or purpose for direct and group messages (#24199)
* block changes to name, display name or purpose for direct and group messages

* add test

* fix condition

* update patch_channel

* update error message

* fix message

* fix lint

* fix i18n

```release-note
NONE
```

---------

Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in>
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-09-05 15:00:32 +05:30
Felipe Martin
9f7521d003 Move request package into public/shared folder (#24420)
* move request package to public/shared

* updated app-layers

* update app layer

* remove original package location
2023-09-05 09:47:30 +02:00
Ben Schumacher
01e7e96448 Migrate to idiomatic error handling in support_package.go (#24382) 2023-09-04 19:36:46 +02:00
Ben Schumacher
918fff378d [MM-47612] Fix flaky TestPluginAPIDeleteUserPreferences (#24406) 2023-09-04 10:41:05 +02:00