Christopher Poile
87ea6d8b1c
[MM-62537] Fix: Integration action nil ptr dereference ( #29986 )
...
* guard against nil dereference; lock down with tests
* fix test name
2025-01-28 13:46:12 -05:00
Anna Os
48b047aa0c
[GH-16199] add IsValid to model OpenDialogRequest ( #26526 )
...
* [GH-16199] add IsValid to model OpenDialogRequest
* [GH-16199] add IsValid to model OpenDialogRequest, revert remove of translations
* [GH-16199] fix tests after revert
* [GH-16199] add IsValid to model OpenDialogRequest
* [GH-16199] revert validation of icon url
* [GH-16199] update go sum
* [GH-16199] log warning for invalid dialog
* [GH-16199] log error for invalid dialog
* [GH-16199] log warning for invalid dialog
* [GH-16199] fix golang-ci
---------
Co-authored-by: Lukas Eipert <git@leipert.io >
Co-authored-by: Mattermost Build <build@mattermost.com >
2024-04-30 18:27:07 +02:00
Alejandro García Montoro
994e437f2a
MM-56780: Ensure p.Integration is not nil ( #26301 )
...
* Ensure p.Integration is not nil
A Sentry crash report showed that the check
p.Integration.URL != input.integration.URL
was dereferencing a nil pointer. At that point in the code,
input.Integration is known to be non-nil, but we still need to check
whether the original, p.Integration, is.
Crash report: https://mattermost-mr.sentry.io/issues/4918263046/events/5738b67edcee4c9c883d40f7d26563a6
* Test nil original integration and both nil
2024-02-27 13:52:52 +01:00
Ben Schumacher
1fdddfe678
[MM-53269] Add configuration setting for integration requests timeout ( #23805 )
...
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com >
2023-12-18 16:07:00 +01:00
Jesse Hallam
bb02b35048
Expose public/ API as submodule ( #23345 )
...
* model -> public/model
* plugin -> public/plugin
* public/model/utils -> public/utils
* platform/shared/mlog -> public/shared/mlog
* platform/shared/i18n -> public/shared/i18n
* platform/shared/markdown -> public/shared/markdown
* platform/services/timezones -> public/shared/timezones
* channels/einterfaces -> einterfaces
* expose public/ submodule
* go mod tidy
* .github: cache-dependency-path, setup-go-work
* modules-tidy for public/ too
* remove old gomodtidy
2023-05-10 13:07:02 -03:00
