From ff6de4bdabda5beda8e4b3ecc99c049980ae4dfc Mon Sep 17 00:00:00 2001 From: Ben Schumacher Date: Mon, 14 Oct 2024 21:05:39 +0200 Subject: [PATCH] Fix errcheck issues in channels/app/admin_test.go (#28767) --- server/.golangci.yml | 1 - server/channels/app/admin_test.go | 9 ++++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index aa01a0b04e..22cd2bb6e5 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -97,7 +97,6 @@ issues: channels/api4/webhook_test.go|\ channels/api4/websocket_test.go|\ channels/app/admin.go|\ - channels/app/admin_test.go|\ channels/app/app_test.go|\ channels/app/authorization_test.go|\ channels/app/auto_responder_test.go|\ diff --git a/server/channels/app/admin_test.go b/server/channels/app/admin_test.go index 67fa0b2190..f7d5d940e7 100644 --- a/server/channels/app/admin_test.go +++ b/server/channels/app/admin_test.go @@ -32,7 +32,8 @@ func TestGetLatestVersion(t *testing.T) { require.NoError(t, jsonErr) ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { - w.Write(validJSON) + _, err := w.Write(validJSON) + require.NoError(t, err) })) defer ts.Close() @@ -62,7 +63,8 @@ func TestGetLatestVersion(t *testing.T) { require.NoError(t, jsonErr) updatedServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { - w.Write(updatedJSON) + _, err := w.Write(updatedJSON) + require.NoError(t, err) })) defer ts.Close() @@ -76,11 +78,12 @@ func TestGetLatestVersion(t *testing.T) { th.App.ClearLatestVersionCache(th.Context) errorServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusInternalServerError) - w.Write([]byte(` + _, err := w.Write([]byte(` { "message": "internal server error" } `)) + require.NoError(t, err) })) defer ts.Close()