Migrate Plugin.List to Sync by default (#11582)

app/plugin_key_value_store.go

@@ -125,12 +125,12 @@ func (a *App) DeleteAllExpiredPluginKeys() *model.AppError {
 }
 
 func (a *App) ListPluginKeys(pluginId string, page, perPage int) ([]string, *model.AppError) {
-	result := <-a.Srv.Store.Plugin().List(pluginId, page*perPage, perPage)
+	data, err := a.Srv.Store.Plugin().List(pluginId, page*perPage, perPage)
 
-	if result.Err != nil {
-		mlog.Error("Failed to list plugin key values", mlog.Int("page", page), mlog.Int("perPage", perPage), mlog.Err(result.Err))
-		return nil, result.Err
+	if err != nil {
+		mlog.Error("Failed to list plugin key values", mlog.Int("page", page), mlog.Int("perPage", perPage), mlog.Err(err))
+		return nil, err
 	}
 
-	return result.Data.([]string), nil
+	return data, nil
 }