[GH-19150] Remove strings in all channel types for constants (#19535)

Automatic Merge

services/slackimport/slackimport_test.go

@@ -117,7 +117,7 @@ func TestSlackParseChannels(t *testing.T) {
 	require.NoError(t, err)
 	defer file.Close()
 
-	channels, err := slackParseChannels(file, "O")
+	channels, err := slackParseChannels(file, model.ChannelTypeOpen)
 	require.NoError(t, err)
 	assert.Equal(t, 6, len(channels))
 }
@@ -127,7 +127,7 @@ func TestSlackParseDirectMessages(t *testing.T) {
 	require.NoError(t, err)
 	defer file.Close()
 
-	channels, err := slackParseChannels(file, "D")
+	channels, err := slackParseChannels(file, model.ChannelTypeDirect)
 	require.NoError(t, err)
 	assert.Equal(t, 4, len(channels))
 }
@@ -137,7 +137,7 @@ func TestSlackParsePrivateChannels(t *testing.T) {
 	require.NoError(t, err)
 	defer file.Close()
 
-	channels, err := slackParseChannels(file, "P")
+	channels, err := slackParseChannels(file, model.ChannelTypePrivate)
 	require.NoError(t, err)
 	assert.Equal(t, 1, len(channels))
 }
@@ -147,7 +147,7 @@ func TestSlackParseGroupDirectMessages(t *testing.T) {
 	require.NoError(t, err)
 	defer file.Close()
 
-	channels, err := slackParseChannels(file, "G")
+	channels, err := slackParseChannels(file, model.ChannelTypeGroup)
 	require.NoError(t, err)
 	assert.Equal(t, 3, len(channels))
 }
@@ -327,7 +327,7 @@ func TestOldImportChannel(t *testing.T) {
 	config.SetDefaults()
 
 	t.Run("No panic on direct channel", func(t *testing.T) {
-		//ch := th.CreateDmChannel(u1)
+		// ch := th.CreateDmChannel(u1)
 		ch := &model.Channel{
 			Type: model.ChannelTypeDirect,
 			Name: "test-channel",