From fd01e9244fbe6cf2749793e765a1137c0ec6c4e7 Mon Sep 17 00:00:00 2001 From: Rita Anene <92169163+Camillarhi@users.noreply.github.com> Date: Fri, 23 Aug 2024 04:05:23 +0100 Subject: [PATCH] [MM-60170] Migrate tooltips of "components/user_settings/display/user_settings_theme/custom_theme_chooser/custom_theme_chooser.tsx" to WithTooltip (#28009) --- .../custom_theme_chooser.test.tsx.snap | 22 ++++-------- .../custom_theme_chooser.tsx | 36 +++++++------------ 2 files changed, 20 insertions(+), 38 deletions(-) diff --git a/webapp/channels/src/components/user_settings/display/user_settings_theme/custom_theme_chooser/__snapshots__/custom_theme_chooser.test.tsx.snap b/webapp/channels/src/components/user_settings/display/user_settings_theme/custom_theme_chooser/__snapshots__/custom_theme_chooser.test.tsx.snap index ae33c7832f..df4ccade85 100644 --- a/webapp/channels/src/components/user_settings/display/user_settings_theme/custom_theme_chooser/__snapshots__/custom_theme_chooser.test.tsx.snap +++ b/webapp/channels/src/components/user_settings/display/user_settings_theme/custom_theme_chooser/__snapshots__/custom_theme_chooser.test.tsx.snap @@ -426,27 +426,19 @@ exports[`components/user_settings/display/CustomThemeChooser should match, init Monokai - code theme image - - } - placement="top" - trigger={ - Array [ - "hover", - "focus", - ] + } > - + diff --git a/webapp/channels/src/components/user_settings/display/user_settings_theme/custom_theme_chooser/custom_theme_chooser.tsx b/webapp/channels/src/components/user_settings/display/user_settings_theme/custom_theme_chooser/custom_theme_chooser.tsx index 0e5d4a13f4..8bd531ce18 100644 --- a/webapp/channels/src/components/user_settings/display/user_settings_theme/custom_theme_chooser/custom_theme_chooser.tsx +++ b/webapp/channels/src/components/user_settings/display/user_settings_theme/custom_theme_chooser/custom_theme_chooser.tsx @@ -9,9 +9,7 @@ import type {IntlShape, MessageDescriptor} from 'react-intl'; import type {Theme} from 'mattermost-redux/selectors/entities/preferences'; import {setThemeDefaults} from 'mattermost-redux/utils/theme_utils'; -import OverlayTrigger from 'components/overlay_trigger'; -import type {BaseOverlayTrigger} from 'components/overlay_trigger'; -import Popover from 'components/widgets/popover'; +import WithTooltip from 'components/with_tooltip'; import Constants from 'utils/constants'; @@ -134,7 +132,6 @@ export class CustomThemeChooser extends React.PureComponent { centerChannelStylesHeaderRef: RefObject; linkAndButtonStylesHeaderRef: RefObject; sidebarStylesRef: RefObject; - headerOverlayRef: RefObject; centerChannelStylesRef: RefObject; linkAndButtonStylesRef: RefObject; @@ -145,7 +142,6 @@ export class CustomThemeChooser extends React.PureComponent { this.centerChannelStylesHeaderRef = createRef(); this.linkAndButtonStylesHeaderRef = createRef(); this.sidebarStylesRef = createRef(); - this.headerOverlayRef = createRef(); this.centerChannelStylesRef = createRef(); this.linkAndButtonStylesRef = createRef(); @@ -311,20 +307,6 @@ export class CustomThemeChooser extends React.PureComponent { ); }); - const popoverContent = ( - - {'code - - ); - centerChannelElements.push(
{ > {codeThemeOptions} - + {'code +
+ } > { src={codeThemeURL} /> - + , );