MM-31323: Fix racy test TestHandleCommandResponsePost (#16542)
In https://github.com/mattermost/mattermost-server/pull/16089, we added logic to modify the notification text in the presence of fallback text. Unfortunately, that created a race condition during publishing the post via websockets. To fix this, we create a clone of the post before sending it off for push notifications. https://mattermost.atlassian.net/browse/MM-31323 ```release-note NONE ```
Этот коммит содержится в:
коммит произвёл
GitHub
родитель
8e2986e5ed
Коммит
fa1f2a8504
@@ -210,7 +210,7 @@ func (a *App) SendNotifications(post *model.Post, team *model.Team, channel *mod
|
|||||||
}
|
}
|
||||||
|
|
||||||
notification := &PostNotification{
|
notification := &PostNotification{
|
||||||
Post: post,
|
Post: post.Clone(),
|
||||||
Channel: channel,
|
Channel: channel,
|
||||||
ProfileMap: profileMap,
|
ProfileMap: profileMap,
|
||||||
Sender: sender,
|
Sender: sender,
|
||||||
|
|||||||
@@ -583,7 +583,9 @@ func (a *App) buildFullPushNotificationMessage(contentsConfig string, post *mode
|
|||||||
}
|
}
|
||||||
|
|
||||||
for _, attachment := range post.Attachments() {
|
for _, attachment := range post.Attachments() {
|
||||||
post.Message += "\n" + attachment.Fallback
|
if attachment.Fallback != "" {
|
||||||
|
post.Message += "\n" + attachment.Fallback
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
userLocale := utils.GetUserTranslations(user.Locale)
|
userLocale := utils.GetUserTranslations(user.Locale)
|
||||||
|
|||||||
Ссылка в новой задаче
Block a user