From f9f4553dae2e12aaa965daae60b35a710b85cc28 Mon Sep 17 00:00:00 2001 From: Caleb Roseland Date: Tue, 2 May 2023 16:14:02 -0500 Subject: [PATCH] MM-52529: remove defunct 'all teams' fallback text & tooltip (#23216) --- webapp/playbooks/i18n/en.json | 2 - .../src/components/sidebar/sidebar.tsx | 40 +++++++++---------- 2 files changed, 20 insertions(+), 22 deletions(-) diff --git a/webapp/playbooks/i18n/en.json b/webapp/playbooks/i18n/en.json index a87fb63adc..d2680f5b15 100644 --- a/webapp/playbooks/i18n/en.json +++ b/webapp/playbooks/i18n/en.json @@ -95,7 +95,6 @@ "9M92On": "Select channels", "9Obw6C": "Filter", "9PXW6Q": "Duration / Started on", - "9S+ZiL": "No team is selected", "9SIW2x": "Target value for each run", "9TTfXU": "Your System Admin has been notified.", "9X3jwi": "{icon} Cost", @@ -143,7 +142,6 @@ "DXACD6": "Publish retrospective report and access the timeline", "DaHpK1": "Search for a channel", "DnBhRg": "Add People", - "DoskyC": "All Teams", "DqTQOp": "Once", "DtCplA": "{numParticipants, plural, =1 {# participant} other {# participants}}", "EQpfkS": "Finished", diff --git a/webapp/playbooks/src/components/sidebar/sidebar.tsx b/webapp/playbooks/src/components/sidebar/sidebar.tsx index de39393db2..c238ba0288 100644 --- a/webapp/playbooks/src/components/sidebar/sidebar.tsx +++ b/webapp/playbooks/src/components/sidebar/sidebar.tsx @@ -4,11 +4,9 @@ import {getTeam} from 'mattermost-redux/selectors/entities/teams'; import {GlobalState} from '@mattermost/types/store'; import {useSelector} from 'react-redux'; import {Team} from '@mattermost/types/teams'; -import {OverlayTrigger, Tooltip} from 'react-bootstrap'; import Scrollbars from 'react-custom-scrollbars'; -import {useIntl} from 'react-intl'; -import {OVERLAY_DELAY} from 'src/constants'; +import Tooltip from 'src/components/widgets/tooltip'; import {renderThumbVertical, renderTrackHorizontal, renderView} from 'src/components/rhs/rhs_shared'; @@ -39,30 +37,32 @@ interface SidebarProps { headerDropdown: React.ReactNode; } -const teamNameSelector = (teamId: string) => (state: GlobalState): Team => getTeam(state, teamId); +const selectTeam = (teamId: string) => (state: GlobalState): Team => getTeam(state, teamId); const Sidebar = (props: SidebarProps) => { - const team = useSelector(teamNameSelector(props.team_id)); + const team = useSelector(selectTeam(props.team_id)); - const {formatMessage} = useIntl(); + const teamName = ( + + {team?.display_name} + + ); return (
- - {team?.description?.length ? team.description : formatMessage({defaultMessage: 'No team is selected'})} - - } - > - - {team?.display_name?.length ? team.display_name : formatMessage({defaultMessage: 'All Teams'})} - - + {team?.description ? ( + + {teamName} + + ) : ( + teamName + )} {props.headerDropdown}