Merge pull request #1697 from asaadmahmoodspin/master

FIxing scroll for more direct channels

web/react/components/more_direct_channels.jsx

@@ -47,6 +47,21 @@ export default class MoreDirectChannels extends React.Component {
         UserStore.addChangeListener(this.handleUserChange);
     }
 
+    componentDidUpdate(prevProps) {
+        if (!prevProps.show && this.props.show) {
+            this.onShow();
+        }
+    }
+
+    onShow() {
+        if (Utils.isMobile()) {
+            $(ReactDOM.findDOMNode(this.refs.userList)).css('max-height', $(window).height() - 250);
+        } else {
+            $(ReactDOM.findDOMNode(this.refs.userList)).perfectScrollbar();
+            $(ReactDOM.findDOMNode(this.refs.userList)).css('max-height', $(window).height() - 300);
+        }
+    }
+
     handleFilterChange() {
         const filter = ReactDOM.findDOMNode(this.refs.filter).value;
 
@@ -164,15 +179,6 @@ export default class MoreDirectChannels extends React.Component {
         );
     }
 
-    componentDidUpdate(prevProps) {
-        if (!prevProps.show && this.props.show) {
-            $(ReactDOM.findDOMNode(this.refs.userList)).css('max-height', $(window).height() - 50);
-            if ($(window).width() > 768) {
-                $(ReactDOM.findDOMNode(this.refs.userList)).perfectScrollbar();
-            }
-        }
-    }
-
     render() {
         if (!this.props.show) {
             return null;
@@ -217,8 +223,8 @@ export default class MoreDirectChannels extends React.Component {
                 <Modal.Header closeButton={true}>
                     <Modal.Title>{'Direct Messages'}</Modal.Title>
                 </Modal.Header>
-                <Modal.Body>
+                <Modal.Body ref='modalBody'>
-                    <div className='row filter-row'>
+                    <div className='filter-row'>
                         <div className='col-sm-6'>
                             <input
                                 ref='filter'

web/sass-files/sass/partials/_modal.scss

@@ -381,9 +381,9 @@
 .more-modal {
 
 	.user-list {
+		overflow-y: auto;
+		overflow-x: hidden;
 		margin-top: 10px;
-		overflow: auto;
-		-webkit-overflow-scrolling: touch;
 		max-height: 500px;
 		position: relative;
 	}
@@ -394,11 +394,12 @@
 
 	.modal-body {
 		padding: 10px 0 20px;
+		overflow-x: hidden;
 	}
 
 	.filter-row {
 		margin-top: 10px;
-		padding: 0 15px;
+		@include clearfix;
 	}
 
 	.member-count {