Migrate Jobs store to sync by default (#11183)

* Migrate Jobs store to sync by default

* Fixing compilation

* Fixing compilation

* Fixing govet

migrations/migrations.go

@@ -40,21 +40,22 @@ func GetMigrationState(migration string, store store.Store) (string, *model.Job,
 		return MIGRATION_STATE_COMPLETED, nil, nil
 	}
 
-	if result := <-store.Job().GetAllByType(model.JOB_TYPE_MIGRATIONS); result.Err != nil {
-		return "", nil, result.Err
-	} else {
-		for _, job := range result.Data.([]*model.Job) {
-			if key, ok := job.Data[JOB_DATA_KEY_MIGRATION]; ok {
-				if key != migration {
-					continue
-				}
+	jobs, err := store.Job().GetAllByType(model.JOB_TYPE_MIGRATIONS)
+	if err != nil {
+		return "", nil, err
+	}
 
-				switch job.Status {
-				case model.JOB_STATUS_IN_PROGRESS, model.JOB_STATUS_PENDING:
-					return MIGRATION_STATE_IN_PROGRESS, job, nil
-				default:
-					return MIGRATION_STATE_UNSCHEDULED, job, nil
-				}
+	for _, job := range jobs {
+		if key, ok := job.Data[JOB_DATA_KEY_MIGRATION]; ok {
+			if key != migration {
+				continue
+			}
+
+			switch job.Status {
+			case model.JOB_STATUS_IN_PROGRESS, model.JOB_STATUS_PENDING:
+				return MIGRATION_STATE_IN_PROGRESS, job, nil
+			default:
+				return MIGRATION_STATE_UNSCHEDULED, job, nil
 			}
 		}
 	}