From f865703ce9b3e6bedf971a86322d84508cce0243 Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Fri, 26 Mar 2021 15:19:04 +0530 Subject: [PATCH] Remove server from WebsocketRouter (#17238) App contains server. Server contains WebsocketRouter. There is no need for WebsocketRouter to contain server too. As is evident because the code never used it. ```release-note NONE ``` --- app/server.go | 3 +-- app/websocket_router.go | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/app/server.go b/app/server.go index 7fcbceb13a..5ec7e23191 100644 --- a/app/server.go +++ b/app/server.go @@ -496,10 +496,9 @@ func NewServer(options ...Option) (*Server, error) { } s.WebSocketRouter = &WebSocketRouter{ - server: s, handlers: make(map[string]webSocketHandler), + app: fakeApp, } - s.WebSocketRouter.app = fakeApp mailConfig := s.MailServiceConfig() diff --git a/app/websocket_router.go b/app/websocket_router.go index e599ee782a..6bbb2539b0 100644 --- a/app/websocket_router.go +++ b/app/websocket_router.go @@ -16,7 +16,6 @@ type webSocketHandler interface { } type WebSocketRouter struct { - server *Server app *App handlers map[string]webSocketHandler }