fix: e2e tests (#22807)

* fix: e2e tests

* add more fix

* fixed_custom_categories

---------

Co-authored-by: Furqan Malik <furqan.malik@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>

e2e-tests/cypress/tests/support/ui/account_settings_modal.d.ts

@@ -18,19 +18,19 @@ declare namespace Cypress {
     interface Chainable {
 
         /**
-         * Open the account settings modal
+         * Open the profile settings modal
          * @param {string} section - such as `'General'`, `'Security'`, `'Notifications'`, `'Display'`, `'Sidebar'` and `'Advanced'`
          * @return the "#accountSettingsModal"
          *
          * @example
-         *   cy.uiOpenProfileModal().within(() => {
+         *   cy.uiOpenProfileModal('Profile Settings').within(() => {
          *       // Do something here
          *   });
          */
-        uiOpenProfileModal(section?: string): Chainable<JQuery<HTMLElement>>;
+        uiOpenProfileModal(section: string): Chainable<JQuery<HTMLElement>>;
 
         /**
-         * Close the account settings modal given that the modal itself is opened.
+         * Close the profile settings modal given that the modal itself is opened.
          *
          * @example
          *   cy.uiCloseAccountSettingsModal();
@@ -38,7 +38,7 @@ declare namespace Cypress {
         uiCloseAccountSettingsModal(): Chainable;
 
         /**
-         * Navigate to account settings and verify the user's first, last name
+         * Navigate to profile settings and verify the user's first, last name
          * @param {String} firstname - expected user firstname
          * @param {String} lastname - expected user lastname
          */

e2e-tests/cypress/tests/support/ui/account_settings_modal.js

@@ -19,7 +19,7 @@ Cypress.Commands.add('uiOpenProfileModal', (section = '') => {
 
 Cypress.Commands.add('verifyAccountNameSettings', (firstname, lastname) => {
     // # Go to Profile
-    cy.uiOpenProfileModal();
+    cy.uiOpenProfileModal('Profile Settings');
 
     // * Check name value
     cy.get('#nameDesc').should('have.text', `${firstname} ${lastname}`);

e2e-tests/cypress/tests/support/ui/channel.js

@@ -11,7 +11,7 @@ Cypress.Commands.add('uiCreateChannel', ({
     name = '',
     createBoard = false,
 }) => {
-    cy.uiBrowseOrCreateChannel('Create New Channel').click();
+    cy.uiBrowseOrCreateChannel('Create new channel').click();
 
     cy.get('#new-channel-modal').should('be.visible');
     if (isPrivate) {

e2e-tests/cypress/tests/support/ui/channel_sidebar.js

@@ -7,8 +7,8 @@ Cypress.Commands.add('uiCreateSidebarCategory', (categoryName = `category-${getR
     // # Click the New Category/Channel Dropdown button
     cy.uiGetLHSAddChannelButton().click();
 
-    // # Click the Create New Category dropdown item
-    cy.get('.AddChannelDropdown').should('be.visible').contains('.MenuItem', 'Create New Category').click();
+    // # Click the Create new category dropdown item
+    cy.get('.AddChannelDropdown').should('be.visible').contains('.MenuItem', 'Create new category').click();
 
     cy.findByRole('dialog', {name: 'Rename Category'}).should('be.visible').within(() => {
         // # Fill in the category name and click 'Create'

e2e-tests/cypress/tests/support/ui/sidebar_left.ts

@@ -213,7 +213,7 @@ declare global {
              * @param {string} item - dropdown menu. If set, it will do click action.
              *
              * @example
-             *   cy.uiBrowseOrCreateChannel('Browse Channels');
+             *   cy.uiBrowseOrCreateChannel('Browse channels');
              */
             uiBrowseOrCreateChannel(item: string): Chainable;
 

e2e-tests/cypress/tests/support/ui_commands.ts

@@ -788,7 +788,7 @@ declare global {
             updateChannelHeader(text: string): ChainableT<void>;
 
             /**
-             * Navigate to system console-PluginManagement from account settings
+             * Navigate to system console-PluginManagement from profile settings
              */
             checkRunLDAPSync: typeof checkRunLDAPSync;