corrected file permissions for localstore (#13369)

Automatic Merge

services/filesstore/localstore.go

@@ -71,7 +71,7 @@ func (b *LocalFileBackend) CopyFile(oldPath, newPath string) *model.AppError {
 }
 
 func (b *LocalFileBackend) MoveFile(oldPath, newPath string) *model.AppError {
-	if err := os.MkdirAll(filepath.Dir(filepath.Join(b.directory, newPath)), 0774); err != nil {
+	if err := os.MkdirAll(filepath.Dir(filepath.Join(b.directory, newPath)), 0750); err != nil {
 		return model.NewAppError("moveFile", "api.file.move_file.rename.app_error", nil, err.Error(), http.StatusInternalServerError)
 	}
 
@@ -87,11 +87,11 @@ func (b *LocalFileBackend) WriteFile(fr io.Reader, path string) (int64, *model.A
 }
 
 func writeFileLocally(fr io.Reader, path string) (int64, *model.AppError) {
-	if err := os.MkdirAll(filepath.Dir(path), 0774); err != nil {
+	if err := os.MkdirAll(filepath.Dir(path), 0750); err != nil {
 		directory, _ := filepath.Abs(filepath.Dir(path))
 		return 0, model.NewAppError("WriteFile", "api.file.write_file_locally.create_dir.app_error", nil, "directory="+directory+", err="+err.Error(), http.StatusInternalServerError)
 	}
-	fw, err := os.OpenFile(path, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
+	fw, err := os.OpenFile(path, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0600)
 	if err != nil {
 		return 0, model.NewAppError("WriteFile", "api.file.write_file_locally.writing.app_error", nil, err.Error(), http.StatusInternalServerError)
 	}