From f2119d60fa4be4a38ac9997b4db40a8fe767dd6c Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Tue, 3 Aug 2021 00:35:03 +0530 Subject: [PATCH] Print a helpful message for JSON column update failures. (#18041) Automatic Merge --- store/sqlstore/store.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/store/sqlstore/store.go b/store/sqlstore/store.go index aa334dc5aa..eb452655c9 100644 --- a/store/sqlstore/store.go +++ b/store/sqlstore/store.go @@ -920,7 +920,11 @@ func (ss *SqlStore) AlterColumnTypeIfExists(tableName string, columnName string, } if err != nil { - mlog.Critical("Failed to alter column type", mlog.Err(err)) + msg := "Failed to alter column type." + if mySqlColType == "JSON" && postgresColType == "jsonb" { + msg += " It is likely you have invalid JSON values in the column. Please fix the values manually and run the migration again." + } + mlog.Critical(msg, mlog.Err(err)) time.Sleep(time.Second) os.Exit(ExitAlterColumn) }