From f1ddd3ad38a787d709d1296d8d82ef27fd71823f Mon Sep 17 00:00:00 2001 From: Doug Lauder Date: Mon, 20 Jun 2022 12:39:45 -0400 Subject: [PATCH] Revert PR checking for GetUser returning nil,nil (#20508) Reverts the PR https://github.com/mattermost/mattermost-server/pull/20501 which was added for SET escalation. It was determined that the plugins call to GetUser never made it to the app layer. --- app/user.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/app/user.go b/app/user.go index f05fd43270..1fb1e7be2f 100644 --- a/app/user.go +++ b/app/user.go @@ -388,12 +388,6 @@ func (a *App) GetUser(userID string) (*model.User, *model.AppError) { } } - // Temporary check to diagnose a SET escalation; when GetUser is called by some plugins a nil,nil is returned. - if user == nil { - mlog.Error("Unexpected nil from GetUser", mlog.String("user_id", userID)) - return nil, model.NewAppError("GetUser", "app.user.get.app_error", nil, "Unexpected nil fetching userid "+userID, http.StatusInternalServerError) - } - return user, nil }