From f0918e1c01d89b722c9c0b03145c302da82faf36 Mon Sep 17 00:00:00 2001 From: Arya Khochare <91268931+Aryakoste@users.noreply.github.com> Date: Tue, 8 Oct 2024 15:53:08 +0530 Subject: [PATCH] errcheck issues fixed (#28609) --- server/.golangci.yml | 1 - server/channels/api4/webhook.go | 8 ++++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index 960fae33f6..086a6740b0 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -106,7 +106,6 @@ issues: channels/api4/user.go|\ channels/api4/user_local.go|\ channels/api4/user_test.go|\ - channels/api4/webhook.go|\ channels/api4/webhook_test.go|\ channels/api4/websocket_test.go|\ channels/app/admin.go|\ diff --git a/server/channels/api4/webhook.go b/server/channels/api4/webhook.go index 245fda14e2..fc30ae62c4 100644 --- a/server/channels/api4/webhook.go +++ b/server/channels/api4/webhook.go @@ -238,7 +238,9 @@ func getIncomingHooks(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(js) + if _, err := w.Write(js); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func getIncomingHook(c *Context, w http.ResponseWriter, r *http.Request) { @@ -528,7 +530,9 @@ func getOutgoingHooks(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(js) + if _, err := w.Write(js); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func getOutgoingHook(c *Context, w http.ResponseWriter, r *http.Request) {