From ef4e37fb6b181861684b9f2b9b84905a4a849941 Mon Sep 17 00:00:00 2001 From: Christopher Speller Date: Mon, 17 Dec 2018 12:04:30 -0800 Subject: [PATCH] Fix update user auth. (#10013) --- api4/user.go | 1 + api4/user_test.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/api4/user.go b/api4/user.go index a98c7484ea..4a45de64c6 100644 --- a/api4/user.go +++ b/api4/user.go @@ -856,6 +856,7 @@ func updateUserAuth(c *Context, w http.ResponseWriter, r *http.Request) { user, err := c.App.UpdateUserAuth(c.Params.UserId, userAuth) if err != nil { c.Err = err + return } c.LogAuditWithUserId(c.Params.UserId, fmt.Sprintf("updated user auth to service=%v", user.AuthService)) diff --git a/api4/user_test.go b/api4/user_test.go index 4af6a31360..f20ffd8ed3 100644 --- a/api4/user_test.go +++ b/api4/user_test.go @@ -1203,7 +1203,7 @@ func TestUpdateUserAuth(t *testing.T) { userAuth.AuthData = user.AuthData userAuth.AuthService = "" userAuth.Password = "1" - if _, err := th.Client.UpdateUserAuth(user.Id, userAuth); err == nil { + if _, err := Client.UpdateUserAuth(user.Id, userAuth); err == nil { t.Fatal("Should have errored - user password not valid") }