Deprecate admin advisor (#26045)

* Deprecate admin advisor

* Webapp portion

* More webapp deprecation

* More cleanup

* Linting

* emoved metric ack dialog from annoucenemet bar

* Cleanued up uninsed i18n strings

* Updated test

* fixed types

* Updating server test

* Updated i18n

* Updated cypress test:

* Updated cypress test:

---------

Co-authored-by: harshil Sharma <harshilsharma63@gmail.com>

server/public/model/post.go

@@ -19,39 +19,38 @@ import (
 )
 
 const (
-	PostSystemMessagePrefix        = "system_"
-	PostTypeDefault                = ""
-	PostTypeSlackAttachment        = "slack_attachment"
-	PostTypeSystemGeneric          = "system_generic"
-	PostTypeJoinLeave              = "system_join_leave" // Deprecated, use PostJoinChannel or PostLeaveChannel instead
-	PostTypeJoinChannel            = "system_join_channel"
-	PostTypeGuestJoinChannel       = "system_guest_join_channel"
-	PostTypeLeaveChannel           = "system_leave_channel"
-	PostTypeJoinTeam               = "system_join_team"
-	PostTypeLeaveTeam              = "system_leave_team"
-	PostTypeAutoResponder          = "system_auto_responder"
-	PostTypeAddRemove              = "system_add_remove" // Deprecated, use PostAddToChannel or PostRemoveFromChannel instead
-	PostTypeAddToChannel           = "system_add_to_channel"
-	PostTypeAddGuestToChannel      = "system_add_guest_to_chan"
-	PostTypeRemoveFromChannel      = "system_remove_from_channel"
-	PostTypeMoveChannel            = "system_move_channel"
-	PostTypeAddToTeam              = "system_add_to_team"
-	PostTypeRemoveFromTeam         = "system_remove_from_team"
-	PostTypeHeaderChange           = "system_header_change"
-	PostTypeDisplaynameChange      = "system_displayname_change"
-	PostTypeConvertChannel         = "system_convert_channel"
-	PostTypePurposeChange          = "system_purpose_change"
-	PostTypeChannelDeleted         = "system_channel_deleted"
-	PostTypeChannelRestored        = "system_channel_restored"
-	PostTypeEphemeral              = "system_ephemeral"
-	PostTypeChangeChannelPrivacy   = "system_change_chan_privacy"
-	PostTypeWrangler               = "system_wrangler"
-	PostTypeGMConvertedToChannel   = "system_gm_to_channel"
-	PostTypeAddBotTeamsChannels    = "add_bot_teams_channels"
-	PostTypeSystemWarnMetricStatus = "warn_metric_status"
-	PostTypeMe                     = "me"
-	PostCustomTypePrefix           = "custom_"
-	PostTypeReminder               = "reminder"
+	PostSystemMessagePrefix      = "system_"
+	PostTypeDefault              = ""
+	PostTypeSlackAttachment      = "slack_attachment"
+	PostTypeSystemGeneric        = "system_generic"
+	PostTypeJoinLeave            = "system_join_leave" // Deprecated, use PostJoinChannel or PostLeaveChannel instead
+	PostTypeJoinChannel          = "system_join_channel"
+	PostTypeGuestJoinChannel     = "system_guest_join_channel"
+	PostTypeLeaveChannel         = "system_leave_channel"
+	PostTypeJoinTeam             = "system_join_team"
+	PostTypeLeaveTeam            = "system_leave_team"
+	PostTypeAutoResponder        = "system_auto_responder"
+	PostTypeAddRemove            = "system_add_remove" // Deprecated, use PostAddToChannel or PostRemoveFromChannel instead
+	PostTypeAddToChannel         = "system_add_to_channel"
+	PostTypeAddGuestToChannel    = "system_add_guest_to_chan"
+	PostTypeRemoveFromChannel    = "system_remove_from_channel"
+	PostTypeMoveChannel          = "system_move_channel"
+	PostTypeAddToTeam            = "system_add_to_team"
+	PostTypeRemoveFromTeam       = "system_remove_from_team"
+	PostTypeHeaderChange         = "system_header_change"
+	PostTypeDisplaynameChange    = "system_displayname_change"
+	PostTypeConvertChannel       = "system_convert_channel"
+	PostTypePurposeChange        = "system_purpose_change"
+	PostTypeChannelDeleted       = "system_channel_deleted"
+	PostTypeChannelRestored      = "system_channel_restored"
+	PostTypeEphemeral            = "system_ephemeral"
+	PostTypeChangeChannelPrivacy = "system_change_chan_privacy"
+	PostTypeWrangler             = "system_wrangler"
+	PostTypeGMConvertedToChannel = "system_gm_to_channel"
+	PostTypeAddBotTeamsChannels  = "add_bot_teams_channels"
+	PostTypeMe                   = "me"
+	PostCustomTypePrefix         = "custom_"
+	PostTypeReminder             = "reminder"
 
 	PostFileidsMaxRunes   = 300
 	PostFilenamesMaxRunes = 4000
@@ -446,7 +445,6 @@ func (o *Post) IsValid(maxPostSize int) *AppError {
 		PostTypeChannelRestored,
 		PostTypeChangeChannelPrivacy,
 		PostTypeAddBotTeamsChannels,
-		PostTypeSystemWarnMetricStatus,
 		PostTypeReminder,
 		PostTypeMe,
 		PostTypeWrangler,

server/public/model/system.go

@@ -146,89 +146,6 @@ type FileData struct {
 	Filename string
 	Body     []byte
 }
-
-var WarnMetricsTable = map[string]WarnMetric{
-	SystemWarnMetricMfa: {
-		Id:        SystemWarnMetricMfa,
-		Limit:     -1,
-		IsBotOnly: true,
-		IsRunOnce: true,
-	},
-	SystemWarnMetricEmailDomain: {
-		Id:        SystemWarnMetricEmailDomain,
-		Limit:     -1,
-		IsBotOnly: true,
-		IsRunOnce: true,
-	},
-	SystemWarnMetricNumberOfTeams5: {
-		Id:        SystemWarnMetricNumberOfTeams5,
-		Limit:     5,
-		IsBotOnly: true,
-		IsRunOnce: true,
-	},
-	SystemWarnMetricNumberOfChannels50: {
-		Id:        SystemWarnMetricNumberOfChannels50,
-		Limit:     50,
-		IsBotOnly: true,
-		IsRunOnce: true,
-	},
-	SystemWarnMetricNumberOfActiveUsers100: {
-		Id:        SystemWarnMetricNumberOfActiveUsers100,
-		Limit:     100,
-		IsBotOnly: true,
-		IsRunOnce: true,
-	},
-	SystemWarnMetricNumberOfActiveUsers200: {
-		Id:        SystemWarnMetricNumberOfActiveUsers200,
-		Limit:     200,
-		IsBotOnly: true,
-		IsRunOnce: true,
-	},
-	SystemWarnMetricNumberOfActiveUsers300: {
-		Id:        SystemWarnMetricNumberOfActiveUsers300,
-		Limit:     300,
-		IsBotOnly: true,
-		IsRunOnce: true,
-	},
-	SystemWarnMetricNumberOfActiveUsers500: {
-		Id:        SystemWarnMetricNumberOfActiveUsers500,
-		Limit:     500,
-		IsBotOnly: false,
-		IsRunOnce: true,
-	},
-	SystemWarnMetricNumberOfPosts2m: {
-		Id:        SystemWarnMetricNumberOfPosts2m,
-		Limit:     2000000,
-		IsBotOnly: false,
-		IsRunOnce: true,
-	},
-}
-
-type WarnMetric struct {
-	Id         string
-	Limit      int64
-	IsBotOnly  bool
-	IsRunOnce  bool
-	SkipAction bool
-}
-
-type WarnMetricDisplayTexts struct {
-	BotTitle          string
-	BotMessageBody    string
-	BotSuccessMessage string
-	EmailBody         string
-}
-type WarnMetricStatus struct {
-	Id          string `json:"id"`
-	Limit       int64  `json:"limit"`
-	Acked       bool   `json:"acked"`
-	StoreStatus string `json:"store_status,omitempty"`
-}
-
-type SendWarnMetricAck struct {
-	ForceAck bool `json:"forceAck"`
-}
-
 type AppliedMigration struct {
 	Version int    `json:"version"`
 	Name    string `json:"name"`