Upgrade Go to 1.24.3 (#31220)

* Upgrade Go to 1.24.3

Updates the following files:
- server/.go-version: 1.23.9 → 1.24.3
- server/build/Dockerfile.buildenv: golang:1.23.9-bullseye → golang:1.24.3-bullseye
- server/go.mod: go 1.23.0 → go 1.24.3, toolchain go1.23.9 → go1.24.3
- server/public/go.mod: go 1.23.0 → go 1.24.3, toolchain go1.23.9 → go1.24.3

Also fixes non-constant format string errors introduced by Go 1.24.3's stricter format string checking:
- Added response() helper function in slashcommands/util.go for simple string responses
- Removed unused responsef() function from slashcommands/util.go
- Replaced responsef() with response() for translated strings that don't need formatting
- Fixed fmt.Errorf and fmt.Fprintf calls to use proper format verbs instead of string concatenation
- Updated marketplace buildURL to handle format strings conditionally

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Update generated mocks for Go 1.24.3

Regenerated mocks using mockery v2.53.4 to ensure compatibility with Go 1.24.3.
This addresses mock generation failures that occurred with the Go upgrade.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Update to bookworm and fix non-existent sha

Signed-off-by: Stavros Foteinopoulos <stafot@gmail.com>

* fix non-constant format string

---------

Signed-off-by: Stavros Foteinopoulos <stafot@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Stavros Foteinopoulos <stafot@gmail.com>

server/platform/services/cache/mocks/Cache.go

@@ -1,4 +1,4 @@
-// Code generated by mockery v2.42.2. DO NOT EDIT.
+// Code generated by mockery v2.53.4. DO NOT EDIT.
 
 // Regenerate this file using `make cache-mocks`.
 
@@ -34,7 +34,7 @@ func (_m *Cache) Get(key string, value interface{}) error {
 	return r0
 }
 
-// GetInvalidateClusterEvent provides a mock function with given fields:
+// GetInvalidateClusterEvent provides a mock function with no fields
 func (_m *Cache) GetInvalidateClusterEvent() model.ClusterEvent {
 	ret := _m.Called()
 
@@ -72,7 +72,7 @@ func (_m *Cache) GetMulti(keys []string, values []interface{}) []error {
 	return r0
 }
 
-// Name provides a mock function with given fields:
+// Name provides a mock function with no fields
 func (_m *Cache) Name() string {
 	ret := _m.Called()
 
@@ -90,7 +90,7 @@ func (_m *Cache) Name() string {
 	return r0
 }
 
-// Purge provides a mock function with given fields:
+// Purge provides a mock function with no fields
 func (_m *Cache) Purge() error {
 	ret := _m.Called()
 

server/platform/services/cache/mocks/ExternalCache.go

@@ -1,4 +1,4 @@
-// Code generated by mockery v2.42.2. DO NOT EDIT.
+// Code generated by mockery v2.53.4. DO NOT EDIT.
 
 // Regenerate this file using `make cache-mocks`.
 
@@ -52,7 +52,7 @@ func (_m *ExternalCache) Get(key string, value interface{}) error {
 	return r0
 }
 
-// GetInvalidateClusterEvent provides a mock function with given fields:
+// GetInvalidateClusterEvent provides a mock function with no fields
 func (_m *ExternalCache) GetInvalidateClusterEvent() model.ClusterEvent {
 	ret := _m.Called()
 
@@ -108,7 +108,7 @@ func (_m *ExternalCache) Increment(key string, val int) error {
 	return r0
 }
 
-// Name provides a mock function with given fields:
+// Name provides a mock function with no fields
 func (_m *ExternalCache) Name() string {
 	ret := _m.Called()
 
@@ -126,7 +126,7 @@ func (_m *ExternalCache) Name() string {
 	return r0
 }
 
-// Purge provides a mock function with given fields:
+// Purge provides a mock function with no fields
 func (_m *ExternalCache) Purge() error {
 	ret := _m.Called()
 

server/platform/services/cache/mocks/Provider.go

@@ -1,4 +1,4 @@
-// Code generated by mockery v2.42.2. DO NOT EDIT.
+// Code generated by mockery v2.53.4. DO NOT EDIT.
 
 // Regenerate this file using `make cache-mocks`.
 
@@ -16,7 +16,7 @@ type Provider struct {
 	mock.Mock
 }
 
-// Close provides a mock function with given fields:
+// Close provides a mock function with no fields
 func (_m *Provider) Close() error {
 	ret := _m.Called()
 
@@ -34,7 +34,7 @@ func (_m *Provider) Close() error {
 	return r0
 }
 
-// Connect provides a mock function with given fields:
+// Connect provides a mock function with no fields
 func (_m *Provider) Connect() (string, error) {
 	ret := _m.Called()
 
@@ -97,7 +97,7 @@ func (_m *Provider) SetMetrics(metrics einterfaces.MetricsInterface) {
 	_m.Called(metrics)
 }
 
-// Type provides a mock function with given fields:
+// Type provides a mock function with no fields
 func (_m *Provider) Type() string {
 	ret := _m.Called()
 

server/platform/services/marketplace/client.go

@@ -119,7 +119,10 @@ func closeBody(r *http.Response) {
 }
 
 func (c *Client) buildURL(urlPath string, args ...any) string {
-	return fmt.Sprintf("%s/%s", strings.TrimRight(c.address, "/"), strings.TrimLeft(fmt.Sprintf(urlPath, args...), "/"))
+	if len(args) > 0 {
+		urlPath = fmt.Sprintf(urlPath, args...)
+	}
+	return fmt.Sprintf("%s/%s", strings.TrimRight(c.address, "/"), strings.TrimLeft(urlPath, "/"))
 }
 
 func (c *Client) doGet(u string) (*http.Response, error) {

server/platform/services/searchengine/mocks/SearchEngineInterface.go

@@ -1,4 +1,4 @@
-// Code generated by mockery v2.42.2. DO NOT EDIT.
+// Code generated by mockery v2.53.4. DO NOT EDIT.
 
 // Regenerate this file using `make searchengine-mocks`.
 
@@ -217,7 +217,7 @@ func (_m *SearchEngineInterface) DeleteUserPosts(rctx request.CTX, userID string
 	return r0
 }
 
-// GetFullVersion provides a mock function with given fields:
+// GetFullVersion provides a mock function with no fields
 func (_m *SearchEngineInterface) GetFullVersion() string {
 	ret := _m.Called()
 
@@ -235,7 +235,7 @@ func (_m *SearchEngineInterface) GetFullVersion() string {
 	return r0
 }
 
-// GetName provides a mock function with given fields:
+// GetName provides a mock function with no fields
 func (_m *SearchEngineInterface) GetName() string {
 	ret := _m.Called()
 
@@ -253,7 +253,7 @@ func (_m *SearchEngineInterface) GetName() string {
 	return r0
 }
 
-// GetPlugins provides a mock function with given fields:
+// GetPlugins provides a mock function with no fields
 func (_m *SearchEngineInterface) GetPlugins() []string {
 	ret := _m.Called()
 
@@ -273,7 +273,7 @@ func (_m *SearchEngineInterface) GetPlugins() []string {
 	return r0
 }
 
-// GetVersion provides a mock function with given fields:
+// GetVersion provides a mock function with no fields
 func (_m *SearchEngineInterface) GetVersion() int {
 	ret := _m.Called()
 
@@ -371,7 +371,7 @@ func (_m *SearchEngineInterface) IndexUser(rctx request.CTX, user *model.User, t
 	return r0
 }
 
-// IsActive provides a mock function with given fields:
+// IsActive provides a mock function with no fields
 func (_m *SearchEngineInterface) IsActive() bool {
 	ret := _m.Called()
 
@@ -389,7 +389,7 @@ func (_m *SearchEngineInterface) IsActive() bool {
 	return r0
 }
 
-// IsAutocompletionEnabled provides a mock function with given fields:
+// IsAutocompletionEnabled provides a mock function with no fields
 func (_m *SearchEngineInterface) IsAutocompletionEnabled() bool {
 	ret := _m.Called()
 
@@ -407,7 +407,7 @@ func (_m *SearchEngineInterface) IsAutocompletionEnabled() bool {
 	return r0
 }
 
-// IsEnabled provides a mock function with given fields:
+// IsEnabled provides a mock function with no fields
 func (_m *SearchEngineInterface) IsEnabled() bool {
 	ret := _m.Called()
 
@@ -425,7 +425,7 @@ func (_m *SearchEngineInterface) IsEnabled() bool {
 	return r0
 }
 
-// IsIndexingEnabled provides a mock function with given fields:
+// IsIndexingEnabled provides a mock function with no fields
 func (_m *SearchEngineInterface) IsIndexingEnabled() bool {
 	ret := _m.Called()
 
@@ -443,7 +443,7 @@ func (_m *SearchEngineInterface) IsIndexingEnabled() bool {
 	return r0
 }
 
-// IsIndexingSync provides a mock function with given fields:
+// IsIndexingSync provides a mock function with no fields
 func (_m *SearchEngineInterface) IsIndexingSync() bool {
 	ret := _m.Called()
 
@@ -461,7 +461,7 @@ func (_m *SearchEngineInterface) IsIndexingSync() bool {
 	return r0
 }
 
-// IsSearchEnabled provides a mock function with given fields:
+// IsSearchEnabled provides a mock function with no fields
 func (_m *SearchEngineInterface) IsSearchEnabled() bool {
 	ret := _m.Called()
 
@@ -717,7 +717,7 @@ func (_m *SearchEngineInterface) SearchUsersInTeam(teamId string, restrictedToCh
 	return r0, r1
 }
 
-// Start provides a mock function with given fields:
+// Start provides a mock function with no fields
 func (_m *SearchEngineInterface) Start() *model.AppError {
 	ret := _m.Called()
 
@@ -737,7 +737,7 @@ func (_m *SearchEngineInterface) Start() *model.AppError {
 	return r0
 }
 
-// Stop provides a mock function with given fields:
+// Stop provides a mock function with no fields
 func (_m *SearchEngineInterface) Stop() *model.AppError {
 	ret := _m.Called()
 

server/platform/services/sharedchannel/mock_AppIface_test.go

@@ -1,4 +1,4 @@
-// Code generated by mockery v2.42.2. DO NOT EDIT.
+// Code generated by mockery v2.53.4. DO NOT EDIT.
 
 // Regenerate this file using `make sharedchannel-mocks`.
 

server/platform/services/sharedchannel/mock_ServerIface_test.go

@@ -1,4 +1,4 @@
-// Code generated by mockery v2.42.2. DO NOT EDIT.
+// Code generated by mockery v2.53.4. DO NOT EDIT.
 
 // Regenerate this file using `make sharedchannel-mocks`.
 
@@ -40,7 +40,7 @@ func (_m *MockServerIface) AddClusterLeaderChangedListener(listener func()) stri
 	return r0
 }
 
-// Config provides a mock function with given fields:
+// Config provides a mock function with no fields
 func (_m *MockServerIface) Config() *model.Config {
 	ret := _m.Called()
 
@@ -60,7 +60,7 @@ func (_m *MockServerIface) Config() *model.Config {
 	return r0
 }
 
-// GetMetrics provides a mock function with given fields:
+// GetMetrics provides a mock function with no fields
 func (_m *MockServerIface) GetMetrics() einterfaces.MetricsInterface {
 	ret := _m.Called()
 
@@ -80,7 +80,7 @@ func (_m *MockServerIface) GetMetrics() einterfaces.MetricsInterface {
 	return r0
 }
 
-// GetRemoteClusterService provides a mock function with given fields:
+// GetRemoteClusterService provides a mock function with no fields
 func (_m *MockServerIface) GetRemoteClusterService() remotecluster.RemoteClusterServiceIFace {
 	ret := _m.Called()
 
@@ -100,7 +100,7 @@ func (_m *MockServerIface) GetRemoteClusterService() remotecluster.RemoteCluster
 	return r0
 }
 
-// GetStore provides a mock function with given fields:
+// GetStore provides a mock function with no fields
 func (_m *MockServerIface) GetStore() store.Store {
 	ret := _m.Called()
 
@@ -120,7 +120,7 @@ func (_m *MockServerIface) GetStore() store.Store {
 	return r0
 }
 
-// IsLeader provides a mock function with given fields:
+// IsLeader provides a mock function with no fields
 func (_m *MockServerIface) IsLeader() bool {
 	ret := _m.Called()
 
@@ -138,7 +138,7 @@ func (_m *MockServerIface) IsLeader() bool {
 	return r0
 }
 
-// Log provides a mock function with given fields:
+// Log provides a mock function with no fields
 func (_m *MockServerIface) Log() *mlog.Logger {
 	ret := _m.Called()
 

server/platform/services/telemetry/mocks/ServerIface.go

@@ -1,4 +1,4 @@
-// Code generated by mockery v2.42.2. DO NOT EDIT.
+// Code generated by mockery v2.53.4. DO NOT EDIT.
 
 // Regenerate this file using `make telemetry-mocks`.
 
@@ -20,7 +20,7 @@ type ServerIface struct {
 	mock.Mock
 }
 
-// Config provides a mock function with given fields:
+// Config provides a mock function with no fields
 func (_m *ServerIface) Config() *model.Config {
 	ret := _m.Called()
 
@@ -40,7 +40,7 @@ func (_m *ServerIface) Config() *model.Config {
 	return r0
 }
 
-// GetPluginsEnvironment provides a mock function with given fields:
+// GetPluginsEnvironment provides a mock function with no fields
 func (_m *ServerIface) GetPluginsEnvironment() *plugin.Environment {
 	ret := _m.Called()
 
@@ -124,7 +124,7 @@ func (_m *ServerIface) GetSchemes(_a0 string, _a1 int, _a2 int) ([]*model.Scheme
 	return r0, r1
 }
 
-// HTTPService provides a mock function with given fields:
+// HTTPService provides a mock function with no fields
 func (_m *ServerIface) HTTPService() httpservice.HTTPService {
 	ret := _m.Called()
 
@@ -144,7 +144,7 @@ func (_m *ServerIface) HTTPService() httpservice.HTTPService {
 	return r0
 }
 
-// IsLeader provides a mock function with given fields:
+// IsLeader provides a mock function with no fields
 func (_m *ServerIface) IsLeader() bool {
 	ret := _m.Called()
 
@@ -162,7 +162,7 @@ func (_m *ServerIface) IsLeader() bool {
 	return r0
 }
 
-// License provides a mock function with given fields:
+// License provides a mock function with no fields
 func (_m *ServerIface) License() *model.License {
 	ret := _m.Called()
 

server/platform/shared/filestore/mocks/FileBackend.go

@@ -1,4 +1,4 @@
-// Code generated by mockery v2.42.2. DO NOT EDIT.
+// Code generated by mockery v2.53.4. DO NOT EDIT.
 
 // Regenerate this file using `make filestore-mocks`.
 
@@ -65,7 +65,7 @@ func (_m *FileBackend) CopyFile(oldPath string, newPath string) error {
 	return r0
 }
 
-// DriverName provides a mock function with given fields:
+// DriverName provides a mock function with no fields
 func (_m *FileBackend) DriverName() string {
 	ret := _m.Called()
 
@@ -341,7 +341,7 @@ func (_m *FileBackend) RemoveFile(path string) error {
 	return r0
 }
 
-// TestConnection provides a mock function with given fields:
+// TestConnection provides a mock function with no fields
 func (_m *FileBackend) TestConnection() error {
 	ret := _m.Called()
 

server/platform/shared/filestore/mocks/FileBackendWithLinkGenerator.go

@@ -1,4 +1,4 @@
-// Code generated by mockery v2.42.2. DO NOT EDIT.
+// Code generated by mockery v2.53.4. DO NOT EDIT.
 
 // Regenerate this file using `make filestore-mocks`.
 

server/platform/shared/filestore/mocks/ReadCloseSeeker.go

@@ -1,4 +1,4 @@
-// Code generated by mockery v2.42.2. DO NOT EDIT.
+// Code generated by mockery v2.53.4. DO NOT EDIT.
 
 // Regenerate this file using `make filestore-mocks`.
 
@@ -11,7 +11,7 @@ type ReadCloseSeeker struct {
 	mock.Mock
 }
 
-// Close provides a mock function with given fields:
+// Close provides a mock function with no fields
 func (_m *ReadCloseSeeker) Close() error {
 	ret := _m.Called()