From e6c0ed4a1be314db5a3cf4612777565c07697549 Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Fri, 6 Dec 2024 10:10:41 +0530 Subject: [PATCH] MM-62085: Handle nil post priority (#29496) https://mattermost.atlassian.net/browse/MM-62085 ```release-note NONE ``` --- server/public/model/post.go | 4 ++++ server/public/model/post_test.go | 13 +++++++++++++ 2 files changed, 17 insertions(+) diff --git a/server/public/model/post.go b/server/public/model/post.go index b69e3c91e8..c3df9b9e4a 100644 --- a/server/public/model/post.go +++ b/server/public/model/post.go @@ -935,6 +935,10 @@ func (o *Post) IsUrgent() bool { return false } + if postPriority.Priority == nil { + return false + } + return *postPriority.Priority == PostPriorityUrgent } diff --git a/server/public/model/post_test.go b/server/public/model/post_test.go index 9dd19a0561..66c6ae0752 100644 --- a/server/public/model/post_test.go +++ b/server/public/model/post_test.go @@ -977,3 +977,16 @@ func TestPostForPlugin(t *testing.T) { require.NotNil(t, pluginPost.GetProp("requested_features")) }) } + +func TestPostPriority(t *testing.T) { + p := &Post{ + Metadata: &PostMetadata{}, + } + require.False(t, p.IsUrgent()) + + p.Metadata.Priority = &PostPriority{} + require.False(t, p.IsUrgent()) + + p.Metadata.Priority.Priority = NewPointer(PostPriorityUrgent) + require.True(t, p.IsUrgent()) +}