PLT-3842 - Fixing scrolling issue on account/team settings modal (#3819)

webapp/components/channel_notifications_modal.jsx

@@ -34,7 +34,9 @@ export default class ChannelNotificationsModal extends React.Component {
         };
     }
     updateSection(section) {
-        $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        if ($('.section-max').length) {
+            $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        }
         this.setState({activeSection: section});
     }
     componentWillReceiveProps(nextProps) {

webapp/components/team_general_tab.jsx

@@ -81,7 +81,9 @@ class GeneralTab extends React.Component {
     }
 
     updateSection(section) {
-        $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        if ($('.section-max').length) {
+            $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        }
         this.setState(this.setupInitialState(this.props));
         this.props.updateSection(section);
     }

webapp/components/team_settings_modal.jsx

@@ -58,7 +58,9 @@ class TeamSettingsModal extends React.Component {
         }
     }
     updateSection(section) {
-        $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        if ($('.section-max').length) {
+            $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        }
         this.setState({activeSection: section});
     }
     render() {

webapp/components/user_settings/user_settings_advanced.jsx

@@ -126,7 +126,9 @@ export default class AdvancedSettingsDisplay extends React.Component {
     }
 
     updateSection(section) {
-        $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        if ($('.section-max').length) {
+            $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        }
         if (!section) {
             this.setState(this.getStateFromStores());
         }

webapp/components/user_settings/user_settings_display.jsx

@@ -126,7 +126,9 @@ export default class UserSettingsDisplay extends React.Component {
     }
 
     updateSection(section) {
-        $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        if ($('.section-max').length) {
+            $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        }
         this.updateState();
         this.props.updateSection(section);
     }

webapp/components/user_settings/user_settings_general.jsx

@@ -285,7 +285,9 @@ class UserSettingsGeneralTab extends React.Component {
     }
 
     updateSection(section) {
-        $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        if ($('.section-max').length) {
+            $('.settings-modal .modal-body').scrollTop(0).perfectScrollbar('update');
+        }
         const emailChangeInProgress = this.state.emailChangeInProgress;
         this.setState(Object.assign({}, this.setupInitialState(this.props), {emailChangeInProgress, clientError: '', serverError: '', emailError: ''}));
         this.submitActive = false;