From e4f1ff75ba6dc071b1248bea33126594a06fa2bd Mon Sep 17 00:00:00 2001 From: jachewz <50257390+jachewz@users.noreply.github.com> Date: Thu, 27 Mar 2025 05:06:44 +1100 Subject: [PATCH] fix admin_test not closing correct servers (#30531) --- server/channels/app/admin_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/channels/app/admin_test.go b/server/channels/app/admin_test.go index 5277eda97f..f77bda5ee6 100644 --- a/server/channels/app/admin_test.go +++ b/server/channels/app/admin_test.go @@ -67,7 +67,7 @@ func TestGetLatestVersion(t *testing.T) { _, err := w.Write(updatedJSON) require.NoError(t, err) })) - defer ts.Close() + defer updatedServer.Close() cachedResult, appErr := th.App.GetLatestVersion(th.Context, updatedServer.URL) require.Nil(t, appErr) @@ -88,7 +88,7 @@ func TestGetLatestVersion(t *testing.T) { `)) require.NoError(t, err) })) - defer ts.Close() + defer errorServer.Close() _, appErr := th.App.GetLatestVersion(th.Context, errorServer.URL) require.NotNil(t, appErr)