NO-TCIKET fix bad smells - error strings should not be capitalized (#16930)

Automatic Merge

plugin/client_rpc.go

@@ -436,7 +436,7 @@ func (s *apiRPCServer) PluginHTTP(args *Z_PluginHTTPArgs, returns *Z_PluginHTTPR
 		returns.Response = response
 		returns.ResponseBody = responseBody
 	} else {
-		return encodableError(fmt.Errorf("API PluginHTTP called but not implemented."))
+		return encodableError(fmt.Errorf("API PluginHTTP called but not implemented"))
 	}
 	return nil
 }
@@ -524,7 +524,7 @@ func (s *hooksRPCServer) FileWillBeUploaded(args *Z_FileWillBeUploadedArgs, retu
 	}); ok {
 		returns.A, returns.B = hook.FileWillBeUploaded(args.A, args.B, fileReader, returnFileWriter)
 	} else {
-		return fmt.Errorf("Hook FileWillBeUploaded called but not implemented.")
+		return fmt.Errorf("hook FileWillBeUploaded called but not implemented")
 	}
 	return nil
 }
@@ -564,7 +564,7 @@ func (s *hooksRPCServer) MessageWillBePosted(args *Z_MessageWillBePostedArgs, re
 		returns.A, returns.B = hook.MessageWillBePosted(args.A, args.B)
 
 	} else {
-		return encodableError(fmt.Errorf("Hook MessageWillBePosted called but not implemented."))
+		return encodableError(fmt.Errorf("hook MessageWillBePosted called but not implemented"))
 	}
 	return nil
 }
@@ -605,7 +605,7 @@ func (s *hooksRPCServer) MessageWillBeUpdated(args *Z_MessageWillBeUpdatedArgs,
 		returns.A, returns.B = hook.MessageWillBeUpdated(args.A, args.B, args.C)
 
 	} else {
-		return encodableError(fmt.Errorf("Hook MessageWillBeUpdated called but not implemented."))
+		return encodableError(fmt.Errorf("hook MessageWillBeUpdated called but not implemented"))
 	}
 	return nil
 }
@@ -634,7 +634,7 @@ func (s *apiRPCServer) LogDebug(args *Z_LogDebugArgs, returns *Z_LogDebugReturns
 	}); ok {
 		hook.LogDebug(args.A, args.B...)
 	} else {
-		return encodableError(fmt.Errorf("API LogDebug called but not implemented."))
+		return encodableError(fmt.Errorf("API LogDebug called but not implemented"))
 	}
 	return nil
 }
@@ -663,7 +663,7 @@ func (s *apiRPCServer) LogInfo(args *Z_LogInfoArgs, returns *Z_LogInfoReturns) e
 	}); ok {
 		hook.LogInfo(args.A, args.B...)
 	} else {
-		return encodableError(fmt.Errorf("API LogInfo called but not implemented."))
+		return encodableError(fmt.Errorf("API LogInfo called but not implemented"))
 	}
 	return nil
 }
@@ -692,7 +692,7 @@ func (s *apiRPCServer) LogWarn(args *Z_LogWarnArgs, returns *Z_LogWarnReturns) e
 	}); ok {
 		hook.LogWarn(args.A, args.B...)
 	} else {
-		return encodableError(fmt.Errorf("API LogWarn called but not implemented."))
+		return encodableError(fmt.Errorf("API LogWarn called but not implemented"))
 	}
 	return nil
 }
@@ -720,7 +720,7 @@ func (s *apiRPCServer) LogError(args *Z_LogErrorArgs, returns *Z_LogErrorReturns
 	}); ok {
 		hook.LogError(args.A, args.B...)
 	} else {
-		return encodableError(fmt.Errorf("API LogError called but not implemented."))
+		return encodableError(fmt.Errorf("API LogError called but not implemented"))
 	}
 	return nil
 }
@@ -762,7 +762,7 @@ func (s *apiRPCServer) InstallPlugin(args *Z_InstallPluginArgs, returns *Z_Insta
 		InstallPlugin(file io.Reader, replace bool) (*model.Manifest, *model.AppError)
 	})
 	if !ok {
-		return encodableError(fmt.Errorf("API InstallPlugin called but not implemented."))
+		return encodableError(fmt.Errorf("API InstallPlugin called but not implemented"))
 	}
 
 	receivePluginConnection, err := s.muxBroker.Dial(args.PluginStreamID)