NO-TCIKET fix bad smells - error strings should not be capitalized (#16930)

Automatic Merge

app/command_autocomplete.go

@@ -307,18 +307,18 @@ func (a *App) getBuiltinDynamicListArgument(commandArgs *model.CommandArgs, arg
 	dynamicArg := arg.Data.(*model.AutocompleteDynamicListArg)
 	arr := strings.Split(dynamicArg.FetchURL, ":")
 	if len(arr) < 2 {
-		return nil, errors.New("Dynamic list URL missing built-in command name")
+		return nil, errors.New("dynamic list URL missing built-in command name")
 	}
 	cmdName := arr[1]
 
 	provider := GetCommandProvider(cmdName)
 	if provider == nil {
-		return nil, fmt.Errorf("No command provider for %s", cmdName)
+		return nil, fmt.Errorf("no command provider for %s", cmdName)
 	}
 
 	dp, ok := provider.(AutocompleteDynamicArgProvider)
 	if !ok {
-		return nil, fmt.Errorf("Auto-completion not available for built-in command %s", cmdName)
+		return nil, fmt.Errorf("auto-completion not available for built-in command %s", cmdName)
 	}
 
 	return dp.GetAutoCompleteListItems(a, commandArgs, arg, parsed, toBeParsed)

app/file_test.go

@@ -278,11 +278,12 @@ func TestCreateZipFileAndAddFiles(t *testing.T) {
 	defer th.TearDown()
 
 	mockBackend := mocks.FileBackend{}
-	mockBackend.On("WriteFile", mock.Anything, "directory-to-heaven/zip-file-name-to-heaven.zip").Return(int64(666), errors.New("Only those who dare to fail greatly can ever achieve greatly"))
+	mockBackend.On("WriteFile", mock.Anything, "directory-to-heaven/zip-file-name-to-heaven.zip").Return(int64(666), errors.New("only those who dare to fail greatly can ever achieve greatly"))
 
 	err := th.App.CreateZipFileAndAddFiles(&mockBackend, []model.FileData{}, "zip-file-name-to-heaven.zip", "directory-to-heaven")
-	require.Error(t, err)
-	require.Equal(t, err.Error(), "Only those who dare to fail greatly can ever achieve greatly")
+
+	require.NotNil(t, err)
+	require.Equal(t, err.Error(), "only those who dare to fail greatly can ever achieve greatly")
 
 	mockBackend = mocks.FileBackend{}
 	mockBackend.On("WriteFile", mock.Anything, "directory-to-heaven/zip-file-name-to-heaven.zip").Return(int64(666), nil)

app/layer_generators/main.go

@@ -160,7 +160,7 @@ func extractStoreMetadata() (*storeMetadata, error) {
 
 	file, err := os.Open(inputFile)
 	if err != nil {
-		return nil, fmt.Errorf("Unable to open %s file: %w", inputFile, err)
+		return nil, fmt.Errorf("unable to open %s file: %w", inputFile, err)
 	}
 	src, err := ioutil.ReadAll(file)
 	if err != nil {