MM-33903 rename slash commands & permission (#17494)

- rename slash commands
    - "remote" -> "secure-connection"
    - "share" -> "share-channel"
- change status icons to text (translated)
- remove channel invite "Description" field
- rename permission "manage_remote_clusters" -> "manage_secure_connections"

model/migration.go

@@ -24,7 +24,7 @@ const (
 	MIGRATION_KEY_ADD_SYSTEM_ROLES_PERMISSIONS                = "add_system_roles_permissions"
 	MIGRATION_KEY_ADD_BILLING_PERMISSIONS                     = "add_billing_permissions"
 	MIGRATION_KEY_ADD_MANAGE_SHARED_CHANNEL_PERMISSIONS       = "manage_shared_channel_permissions"
-	MIGRATION_KEY_ADD_MANAGE_REMOTE_CLUSTERS_PERMISSIONS      = "manage_remote_clusters_permissions"
+	MIGRATION_KEY_ADD_MANAGE_SECURE_CONNECTIONS_PERMISSIONS   = "manage_secure_connections_permissions"
 	MIGRATION_KEY_ADD_DOWNLOAD_COMPLIANCE_EXPORT_RESULTS      = "download_compliance_export_results"
 	MIGRATION_KEY_ADD_COMPLIANCE_SUBSECTION_PERMISSIONS       = "compliance_subsection_permissions"
 	MIGRATION_KEY_ADD_EXPERIMENTAL_SUBSECTION_PERMISSIONS     = "experimental_subsection_permissions"

model/permission.go

@@ -100,7 +100,7 @@ var PERMISSION_USE_GROUP_MENTIONS *Permission
 var PERMISSION_READ_OTHER_USERS_TEAMS *Permission
 var PERMISSION_EDIT_BRAND *Permission
 var PERMISSION_MANAGE_SHARED_CHANNELS *Permission
-var PERMISSION_MANAGE_REMOTE_CLUSTERS *Permission
+var PERMISSION_MANAGE_SECURE_CONNECTIONS *Permission
 var PERMISSION_DOWNLOAD_COMPLIANCE_EXPORT_RESULT *Permission
 var PERMISSION_CREATE_DATA_RETENTION_JOB *Permission
 var PERMISSION_READ_DATA_RETENTION_JOB *Permission
@@ -711,10 +711,10 @@ func initializePermissions() {
 		"authentication.permissions.manage_shared_channels.description",
 		PermissionScopeSystem,
 	}
-	PERMISSION_MANAGE_REMOTE_CLUSTERS = &Permission{
-		"manage_remote_clusters",
-		"authentication.permissions.manage_remote_clusters.name",
-		"authentication.permissions.manage_remote_clusters.description",
+	PERMISSION_MANAGE_SECURE_CONNECTIONS = &Permission{
+		"manage_secure_connections",
+		"authentication.permissions.manage_secure_connections.name",
+		"authentication.permissions.manage_secure_connections.description",
 		PermissionScopeSystem,
 	}
 
@@ -2041,7 +2041,7 @@ func initializePermissions() {
 		PERMISSION_DEMOTE_TO_GUEST,
 		PERMISSION_EDIT_BRAND,
 		PERMISSION_MANAGE_SHARED_CHANNELS,
-		PERMISSION_MANAGE_REMOTE_CLUSTERS,
+		PERMISSION_MANAGE_SECURE_CONNECTIONS,
 		PERMISSION_DOWNLOAD_COMPLIANCE_EXPORT_RESULT,
 		PERMISSION_CREATE_DATA_RETENTION_JOB,
 		PERMISSION_READ_DATA_RETENTION_JOB,

model/shared_channel.go

@@ -106,7 +106,6 @@ func (sc *SharedChannel) PreUpdate() {
 type SharedChannelRemote struct {
 	Id                string `json:"id"`
 	ChannelId         string `json:"channel_id"`
-	Description       string `json:"description"`
 	CreatorId         string `json:"creator_id"`
 	CreateAt          int64  `json:"create_at"`
 	UpdateAt          int64  `json:"update_at"`
@@ -136,10 +135,6 @@ func (sc *SharedChannelRemote) IsValid() *AppError {
 		return NewAppError("SharedChannelRemote.IsValid", "model.channel.is_valid.id.app_error", nil, "ChannelId="+sc.ChannelId, http.StatusBadRequest)
 	}
 
-	if len(sc.Description) > 64 {
-		return NewAppError("SharedChannelRemote.IsValid", "model.channel.is_valid.description.app_error", nil, "description="+sc.Description, http.StatusBadRequest)
-	}
-
 	if sc.CreateAt == 0 {
 		return NewAppError("SharedChannelRemote.IsValid", "model.channel.is_valid.create_at.app_error", nil, "id="+sc.ChannelId, http.StatusBadRequest)
 	}
@@ -172,7 +167,6 @@ type SharedChannelRemoteStatus struct {
 	SiteURL          string `json:"site_url"`
 	LastPingAt       int64  `json:"last_ping_at"`
 	NextSyncAt       int64  `json:"next_sync_at"`
-	Description      string `json:"description"`
 	ReadOnly         bool   `json:"readonly"`
 	IsInviteAccepted bool   `json:"is_invite_accepted"`
 	Token            string `json:"token"`

model/shared_channel_test.go

@@ -76,12 +76,11 @@ func TestSharedChannelPreUpdate(t *testing.T) {
 }
 
 func TestSharedChannelRemoteJson(t *testing.T) {
-	o := SharedChannelRemote{Id: NewId(), ChannelId: NewId(), Description: "Test"}
+	o := SharedChannelRemote{Id: NewId(), ChannelId: NewId()}
 	json := o.ToJson()
 	ro, err := SharedChannelRemoteFromJson(strings.NewReader(json))
 
 	require.NoError(t, err)
 	require.Equal(t, o.Id, ro.Id)
 	require.Equal(t, o.ChannelId, ro.ChannelId)
-	require.Equal(t, o.Description, ro.Description)
 }