* Create scheduled post api (#27920)

* Added migration files for Postgres

* Added migrations for MySQL

* Added store method

* Added API and store tests

* Renamed migration after syncing with master

* Added app layer tests

* API is ready

* API is ready

* API is ready

* Renamed migration after syncing with master

* Updated migration list

* Fixed retry layer tests

* Allowed posts with empty messages

* Review fixes

* Reverted an incorrect change

* Renamed migration and fixed ID assignment

* CI

* Send post button changes (#28019)

* added Split button

* WIP

* Added core menu options

* WIP

* WIP

* WIP

* Handled displaying error in creating scheduled post

* lint fixes

* webapp i18n fix

* Review fixes

* Fixed a webapp test

* A few more fixes

* Removed a duplicate comment

* Scheduled post job (#28088)

* Added the job function

* Added query for fetching scheduled posts for pricessing

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* Reafactoring of scheduled post job

* Lint fixes

* Updated i18n files

* FInishing touches

* Added tests for GetScheduledPosts

* Added tests for PermanentlyDeleteScheduledPosts

* Updated all layer

* Some changes as discussed with team

* Added tests for UpdatedScheduledPost

* Code review refactoring

* Added job test

* MM-60120 - Custom time selection (#28120)

* Added a common date time picker modal and used it for post reminder

* Added a common date time picker modal and used it for post reminderggp

* Added modal for custom schedule time and fixed TZ issue

* WIP

* Removed event from useSubmit hook

* Removed event from useSubmit hook

* Added timezone handling

* fixed type error

* Updated i18n strings

* Minor cleanup

* updated snapshots

* review fixes

* Handled event

* Supported for having a DM thread open in RHS while in a regular channel

* Review fixes

* MM-60136 - Scheduled messages tab (#28133)

* WIP

* WIP

* Created Tabs and Tab wrapper with added styling

* Added API to get scheduled posts

* WIP

* Displated scheduled post count

* i18n fix

* Added tests

* Handled asetting active tab absed on URL:

* Reverted unintended change

* Added API to client ad OpenAPI specs

* Renamed file

* Adding fileinfo to schedule posts

* Partial review fixes

* Made get scheduled post API return posts by teamID

* review fixes

* Moved scheduled post redux code to MM-redux package

* Usedd selector factory

* WIP:

* WIP:

* Lint fix

* Fixed an incorrect openapi spec file

* Removed redundent permission check

* Clreaed scheduled post data on logout

* Removed unused i18n string:

* lint fix

* Render scheduled posts (#28208)

* WIP

* WIP

* Created Tabs and Tab wrapper with added styling

* Added API to get scheduled posts

* WIP

* Displated scheduled post count

* i18n fix

* Added tests

* Handled asetting active tab absed on URL:

* Reverted unintended change

* Added API to client ad OpenAPI specs

* Renamed file

* Created common component for draft list item

* WIP

* WIP

* Adding fileinfo to schedule posts

* Basic rendering

* Added count badge to tabs

* WIP

* Made the Drafts LHS iteam appear if no drafts exist but scheduled posts do

* Fixed icon size

* Partial review fixes

* Made get scheduled post API return posts by teamID

* Handled initial vs team switch load

* Displayed scheduled date in panel header

* Added error message and error indiocator

* WIP

* review fixes

* WIP Adding error reason tag

* Added error codes

* Moved scheduled post redux code to MM-redux package

* Usedd selector factory

* WIP:

* WIP:

* Lint fix

* Fixed an incorrect openapi spec file

* Removed redundent permission check

* Clreaed scheduled post data on logout

* Removed unused i18n string:

* lint fix

* Opened rescheduling modal

* Updated graphic for empty state of schduled post list

* Added delete scheduled post option and modal

* Badge and timezone fix

* WIP:

* Added send now confirmation modal

* lint

* Webapp i18n fix

* Fixed webapp test

* Fixed a bug where DM/GM scheduled posts weren't immideatly showing up in UI

* Minor fixes

* WIP

* Review fixes

* Review fixes

* Optimisations

* Fixed reducer name

* Moment optimizatin

* Updated route check

* MM-60144 - added API to update a scheduled post (#28248)

* WIP

* Added api and ap layer for update scheduled post ̛̦̄

* Added API to OpenAI specs, Go client and TS client

* removed permissio check

* Added tests

* Fixed tests

* Added PreUpdate method on scheduled post model

* MM-60131 - Reschedule post integration (#28281)

* Handled rescheduling post in webapp

* Added error handling

* MM-60146 - Delete scheduled post api (#28265)

* WIP

* Added api and ap layer for update scheduled post ̛̦̄

* Added API to OpenAI specs, Go client and TS client

* removed permissio check

* Added tests

* Fixed tests

* Added PreUpdate method on scheduled post model

* Added delete scheduled post API

* Added API to Go client and OpenAPI specs

* Added API to TS client

* Added tests

* CI

* Rmeoved two incorrect code comments

* MM-60653 - Integrated delete scheduled post API (#28296)

* Integrated delete scheduled apost API

* Lint fix

* Review fixes

* Excluded draft checks from scheduled posts (#28370)

* Excluded draft checks from scheduled posts

* Added a removed todo

* MM-60125 - Scheduled post channel indicator (#28320)

* Integrated delete scheduled apost API

* Lint fix

* Added state for storing scheduled posts by channel ID

* Refactored redux store to store scheudled posts by ID, thens tore IDs everywhere

* Refactored redux store to store scheudled posts by ID, thens tore IDs everywhere

* WIP

* Added scheduled post indiocator

* Handled single and multiple scheudled posts

* Review fixes

* Fixed styling and handled center channel, RHS and threads view

* Lint fix

* i18n fix

* Fixed a cycling dependency

* Lint fix

* Added some more comments

* Updated styling

* Review fixes

* Added common component for remote user time and scheduled post indicator

* Updated scheduled post count

* Minor change

* Moved CSS code around

* Fixed a bug where files in scheduled post didn't show up until refresh (#28359)

---------

Co-authored-by: Daniel Espino García <larkox@gmail.com>

* Scheduled post config (#28485)

* Added config

* Added config on server and webapp side

* Added config check in server and webapp

* Added license check

* Added license check

* Added placeholder help text

* Added license check to job

* Fixed job test

* Review fixes

* Updated English text

* Review fixes

* MM-60118 - Added index on ScheduledPosts table (#28579)

* Added index

* Updated indexes

* Scheduled posts misc fixes (#28625)

* Added detailed logging for scheduled post job

* Limited scheduled posts processing to 24 hours

* Marked old scheduled posts as unable to send

* Added t5ests

* converted some logs to trace level

* Fixed a bug causing error message to show up on deleting a scheduled post in a deleted thread (#28630)

* Fixed scheduled posts link in RHS (#28659)

* Fixed scheduled posts link in RHS

* Review fixes

* Fix permission name in scheduled posts by team (#28580)

* Fix permission name

* fix wording

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

* FIxed width of generic modal header to fix browser channel modal (#28639)

* Only consider error-free scheduled posts for indicator in channel and RHS (#28683)

* Show only errro free scheudled posts in post box indicator

* Fixed a bug to handle no scheduled posts

* Fixed draft and scheudled post UI in mobile view (#28680)

* MM-60873 and MM-60872 - Fixed a bug with updating scheduled posts (#28656)

* Fixed a bug with updating scheduled posts

* Better selectors

* MOved shceuled post message length validation to app layer

* MM-60732 - Scheduled posts channel link now takes you to the first scheduled post in channel/thread in list (#28768)

* Ordered scheudle dposts by schgeudled at nad create at

* Ordered in client

* Added scroll to target

* Removed classname prop

* Fixed tests

* Added doc

* Import fix

* MM-60961 - Fixed a bug where API used incoming create at date for scheduled post (#28703)

* Fixed a bug where API used incoming create at date for scheduled post

* Stopped sending created at value for scheduled post

* MM-60785 - Fixed a bug where scheduled posts of channel we are no longer member of didn't show up (#28637)

* Fixed a bug where scheduled posts of channel we are no longer member of didn't show up

* Added a comment

* CI

* Used data loader to optimise laoding missing channels

* Minor refactoring

* MM-60963 - Added common checks for post and scheduled posts (#28713)

* Added commen checks for post and scheuled posts

* Sanitised scheduled posts

* Fixed tests

* Splitted post checks into app and context functions

* Added checks on scheduiled posts job as well:

* i18n fix

* Fixed a test

* Renamed a func

* removed duplicate check

* Scheduled posts UI fixes (#28828)

* Fixed send button and time picker borders

* Fixed center alignment of time picker

* Removed on for today and tomorrow

* Lint fix

* Date time modal hover state fix

* Badge fix

* Fixed a mnerge issue

* Scheduled Post send now and add schedule on draft (#28851)

* Added send now option on scheduled posts

* Minor refactoring

* WIP

* WIP

* WIP

* Lint fix

* i18n fix

* Snapshot update

* Review fixes

* Scheduled post inline editing (#28893)

* Added send now option on scheduled posts

* Minor refactoring

* WIP

* WIP

* WIP

* Lint fix

* i18n fix

* Snapshot update

* Displayed editing component in scheduled post

* Added handling for updating scheduled post

* Handle events

* Fixed escape key issue in scheudled post editing

* Fixes

* Displayed error message for editing error

* Don't show mention warning

* Handled dev mode (#28918)

* MInor fixes

* client fix

* Fixes

* CI

* Removed dev mode behaviour temperorily (#29008)

---------

Co-authored-by: Daniel Espino García <larkox@gmail.com>
Co-authored-by: Eva Sarafianou <eva.sarafianou@gmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
Этот коммит содержится в:
Harshil Sharma
2024-11-04 11:39:35 +05:30
коммит произвёл GitHub
родитель aaf9234c8e
Коммит e281b3f37e
135 изменённых файлов: 7792 добавлений и 684 удалений

Просмотреть файл

@@ -0,0 +1,221 @@
// Code generated by mockery v2.42.2. DO NOT EDIT.
// Regenerate this file using `make store-mocks`.
package mocks
import (
model "github.com/mattermost/mattermost/server/public/model"
mock "github.com/stretchr/testify/mock"
)
// ScheduledPostStore is an autogenerated mock type for the ScheduledPostStore type
type ScheduledPostStore struct {
mock.Mock
}
// CreateScheduledPost provides a mock function with given fields: scheduledPost
func (_m *ScheduledPostStore) CreateScheduledPost(scheduledPost *model.ScheduledPost) (*model.ScheduledPost, error) {
ret := _m.Called(scheduledPost)
if len(ret) == 0 {
panic("no return value specified for CreateScheduledPost")
}
var r0 *model.ScheduledPost
var r1 error
if rf, ok := ret.Get(0).(func(*model.ScheduledPost) (*model.ScheduledPost, error)); ok {
return rf(scheduledPost)
}
if rf, ok := ret.Get(0).(func(*model.ScheduledPost) *model.ScheduledPost); ok {
r0 = rf(scheduledPost)
} else {
if ret.Get(0) != nil {
r0 = ret.Get(0).(*model.ScheduledPost)
}
}
if rf, ok := ret.Get(1).(func(*model.ScheduledPost) error); ok {
r1 = rf(scheduledPost)
} else {
r1 = ret.Error(1)
}
return r0, r1
}
// Get provides a mock function with given fields: scheduledPostId
func (_m *ScheduledPostStore) Get(scheduledPostId string) (*model.ScheduledPost, error) {
ret := _m.Called(scheduledPostId)
if len(ret) == 0 {
panic("no return value specified for Get")
}
var r0 *model.ScheduledPost
var r1 error
if rf, ok := ret.Get(0).(func(string) (*model.ScheduledPost, error)); ok {
return rf(scheduledPostId)
}
if rf, ok := ret.Get(0).(func(string) *model.ScheduledPost); ok {
r0 = rf(scheduledPostId)
} else {
if ret.Get(0) != nil {
r0 = ret.Get(0).(*model.ScheduledPost)
}
}
if rf, ok := ret.Get(1).(func(string) error); ok {
r1 = rf(scheduledPostId)
} else {
r1 = ret.Error(1)
}
return r0, r1
}
// GetMaxMessageSize provides a mock function with given fields:
func (_m *ScheduledPostStore) GetMaxMessageSize() int {
ret := _m.Called()
if len(ret) == 0 {
panic("no return value specified for GetMaxMessageSize")
}
var r0 int
if rf, ok := ret.Get(0).(func() int); ok {
r0 = rf()
} else {
r0 = ret.Get(0).(int)
}
return r0
}
// GetPendingScheduledPosts provides a mock function with given fields: beforeTime, afterTime, lastScheduledPostId, perPage
func (_m *ScheduledPostStore) GetPendingScheduledPosts(beforeTime int64, afterTime int64, lastScheduledPostId string, perPage uint64) ([]*model.ScheduledPost, error) {
ret := _m.Called(beforeTime, afterTime, lastScheduledPostId, perPage)
if len(ret) == 0 {
panic("no return value specified for GetPendingScheduledPosts")
}
var r0 []*model.ScheduledPost
var r1 error
if rf, ok := ret.Get(0).(func(int64, int64, string, uint64) ([]*model.ScheduledPost, error)); ok {
return rf(beforeTime, afterTime, lastScheduledPostId, perPage)
}
if rf, ok := ret.Get(0).(func(int64, int64, string, uint64) []*model.ScheduledPost); ok {
r0 = rf(beforeTime, afterTime, lastScheduledPostId, perPage)
} else {
if ret.Get(0) != nil {
r0 = ret.Get(0).([]*model.ScheduledPost)
}
}
if rf, ok := ret.Get(1).(func(int64, int64, string, uint64) error); ok {
r1 = rf(beforeTime, afterTime, lastScheduledPostId, perPage)
} else {
r1 = ret.Error(1)
}
return r0, r1
}
// GetScheduledPostsForUser provides a mock function with given fields: userId, teamId
func (_m *ScheduledPostStore) GetScheduledPostsForUser(userId string, teamId string) ([]*model.ScheduledPost, error) {
ret := _m.Called(userId, teamId)
if len(ret) == 0 {
panic("no return value specified for GetScheduledPostsForUser")
}
var r0 []*model.ScheduledPost
var r1 error
if rf, ok := ret.Get(0).(func(string, string) ([]*model.ScheduledPost, error)); ok {
return rf(userId, teamId)
}
if rf, ok := ret.Get(0).(func(string, string) []*model.ScheduledPost); ok {
r0 = rf(userId, teamId)
} else {
if ret.Get(0) != nil {
r0 = ret.Get(0).([]*model.ScheduledPost)
}
}
if rf, ok := ret.Get(1).(func(string, string) error); ok {
r1 = rf(userId, teamId)
} else {
r1 = ret.Error(1)
}
return r0, r1
}
// PermanentlyDeleteScheduledPosts provides a mock function with given fields: scheduledPostIDs
func (_m *ScheduledPostStore) PermanentlyDeleteScheduledPosts(scheduledPostIDs []string) error {
ret := _m.Called(scheduledPostIDs)
if len(ret) == 0 {
panic("no return value specified for PermanentlyDeleteScheduledPosts")
}
var r0 error
if rf, ok := ret.Get(0).(func([]string) error); ok {
r0 = rf(scheduledPostIDs)
} else {
r0 = ret.Error(0)
}
return r0
}
// UpdateOldScheduledPosts provides a mock function with given fields: beforeTime
func (_m *ScheduledPostStore) UpdateOldScheduledPosts(beforeTime int64) error {
ret := _m.Called(beforeTime)
if len(ret) == 0 {
panic("no return value specified for UpdateOldScheduledPosts")
}
var r0 error
if rf, ok := ret.Get(0).(func(int64) error); ok {
r0 = rf(beforeTime)
} else {
r0 = ret.Error(0)
}
return r0
}
// UpdatedScheduledPost provides a mock function with given fields: scheduledPost
func (_m *ScheduledPostStore) UpdatedScheduledPost(scheduledPost *model.ScheduledPost) error {
ret := _m.Called(scheduledPost)
if len(ret) == 0 {
panic("no return value specified for UpdatedScheduledPost")
}
var r0 error
if rf, ok := ret.Get(0).(func(*model.ScheduledPost) error); ok {
r0 = rf(scheduledPost)
} else {
r0 = ret.Error(0)
}
return r0
}
// NewScheduledPostStore creates a new instance of ScheduledPostStore. It also registers a testing interface on the mock and a cleanup function to assert the mocks expectations.
// The first argument is typically a *testing.T value.
func NewScheduledPostStore(t interface {
mock.TestingT
Cleanup(func())
}) *ScheduledPostStore {
mock := &ScheduledPostStore{}
mock.Mock.Test(t)
t.Cleanup(func() { mock.AssertExpectations(t) })
return mock
}

Просмотреть файл

@@ -919,6 +919,26 @@ func (_m *Store) Role() store.RoleStore {
return r0
}
// ScheduledPost provides a mock function with given fields:
func (_m *Store) ScheduledPost() store.ScheduledPostStore {
ret := _m.Called()
if len(ret) == 0 {
panic("no return value specified for ScheduledPost")
}
var r0 store.ScheduledPostStore
if rf, ok := ret.Get(0).(func() store.ScheduledPostStore); ok {
r0 = rf()
} else {
if ret.Get(0) != nil {
r0 = ret.Get(0).(store.ScheduledPostStore)
}
}
return r0
}
// Scheme provides a mock function with given fields:
func (_m *Store) Scheme() store.SchemeStore {
ret := _m.Called()

Просмотреть файл

@@ -0,0 +1,472 @@
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
package storetest
import (
"testing"
"time"
"github.com/mattermost/mattermost/server/public/model"
"github.com/mattermost/mattermost/server/public/shared/request"
"github.com/mattermost/mattermost/server/v8/channels/store"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestScheduledPostStore(t *testing.T, rctx request.CTX, ss store.Store, s SqlStore) {
t.Run("CreateScheduledPost", func(t *testing.T) { testCreateScheduledPost(t, rctx, ss, s) })
t.Run("GetPendingScheduledPosts", func(t *testing.T) { testGetScheduledPosts(t, rctx, ss, s) })
t.Run("PermanentlyDeleteScheduledPosts", func(t *testing.T) { testPermanentlyDeleteScheduledPosts(t, rctx, ss, s) })
t.Run("UpdatedScheduledPost", func(t *testing.T) { testUpdatedScheduledPost(t, rctx, ss, s) })
t.Run("UpdateOldScheduledPosts", func(t *testing.T) { testUpdateOldScheduledPosts(t, rctx, ss, s) })
}
func testCreateScheduledPost(t *testing.T, rctx request.CTX, ss store.Store, s SqlStore) {
channel := &model.Channel{
TeamId: "team_id_1",
Type: model.ChannelTypeOpen,
Name: "channel_name",
DisplayName: "Channel Name",
}
createdChannel, err := ss.Channel().Save(rctx, channel, 1000)
assert.NoError(t, err)
defer func() {
_ = ss.Channel().PermanentDelete(rctx, createdChannel.Id)
}()
t.Run("base case", func(t *testing.T) {
userId := model.NewId()
scheduledPost := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: userId,
ChannelId: createdChannel.Id,
Message: "this is a scheduled post",
},
ScheduledAt: model.GetMillis() + 100000, // 100 seconds in the future
}
createdScheduledPost, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost.Id)
defer func() {
_ = ss.ScheduledPost().PermanentlyDeleteScheduledPosts([]string{createdScheduledPost.Id})
}()
scheduledPostsFromDatabase, err := ss.ScheduledPost().GetScheduledPostsForUser(userId, "team_id_1")
assert.NoError(t, err)
require.Equal(t, 1, len(scheduledPostsFromDatabase))
assert.Equal(t, scheduledPost.Id, scheduledPostsFromDatabase[0].Id)
})
t.Run("scheduling in past SHOULD BE allowed", func(t *testing.T) {
// this is only allowed in store layer and user won't be able to do so as the checks
// in app layer would stop them.
userId := model.NewId()
scheduledPost := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: userId,
ChannelId: createdChannel.Id,
Message: "this is a scheduled post",
},
ScheduledAt: model.GetMillis() - 100000, // 100 seconds in the past
}
_, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost)
assert.NoError(t, err)
defer func() {
_ = ss.ScheduledPost().PermanentlyDeleteScheduledPosts([]string{scheduledPost.Id})
}()
})
}
func testGetScheduledPosts(t *testing.T, rctx request.CTX, ss store.Store, s SqlStore) {
t.Run("should handle no scheduled posts exist", func(t *testing.T) {
apr2022 := time.Date(2100, time.April, 1, 1, 0, 0, 0, time.UTC)
afterTime := time.Date(2100, time.March, 1, 1, 0, 0, 0, time.UTC)
scheduledPosts, err := ss.ScheduledPost().GetPendingScheduledPosts(model.GetMillisForTime(apr2022), model.GetMillisForTime(afterTime), "", 10)
assert.NoError(t, err)
assert.Equal(t, 0, len(scheduledPosts))
})
t.Run("base case", func(t *testing.T) {
// creating some sample scheduled posts
// Create a time object for 1 January 2100, 1 AM
jan2100 := time.Date(2100, time.January, 1, 1, 0, 0, 0, time.UTC)
scheduledPost1 := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: model.NewId(),
ChannelId: model.NewId(),
Message: "this is a scheduled post",
},
ScheduledAt: model.GetMillisForTime(jan2100),
}
createdScheduledPost1, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost1)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost1.Id)
feb2100 := time.Date(2100, time.February, 1, 1, 0, 0, 0, time.UTC)
scheduledPost2 := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: model.NewId(),
ChannelId: model.NewId(),
Message: "this is a scheduled post",
},
ScheduledAt: model.GetMillisForTime(feb2100),
}
createdScheduledPost2, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost2)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost2.Id)
mar2100 := time.Date(2100, time.March, 1, 1, 0, 0, 0, time.UTC)
scheduledPost3 := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: model.NewId(),
ChannelId: model.NewId(),
Message: "this is a scheduled post",
},
ScheduledAt: model.GetMillisForTime(mar2100),
}
createdScheduledPost3, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost3)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost3.Id)
defer func() {
_ = ss.ScheduledPost().PermanentlyDeleteScheduledPosts([]string{
createdScheduledPost1.Id,
createdScheduledPost2.Id,
createdScheduledPost3.Id,
})
}()
apr2022 := time.Date(2100, time.April, 1, 1, 0, 0, 0, time.UTC)
afterTime := time.Date(2100, time.January, 1, 0, 0, 0, 0, time.UTC)
scheduledPosts, err := ss.ScheduledPost().GetPendingScheduledPosts(model.GetMillisForTime(apr2022), model.GetMillisForTime(afterTime), "", 10)
assert.NoError(t, err)
assert.Equal(t, 3, len(scheduledPosts))
mar2100midnight := time.Date(2100, time.March, 1, 0, 0, 0, 0, time.UTC)
afterTime = time.Date(2100, time.January, 1, 0, 0, 0, 0, time.UTC)
scheduledPosts, err = ss.ScheduledPost().GetPendingScheduledPosts(model.GetMillisForTime(mar2100midnight), model.GetMillisForTime(afterTime), "", 10)
assert.NoError(t, err)
assert.Equal(t, 2, len(scheduledPosts))
jan2100Midnight := time.Date(2100, time.January, 1, 0, 0, 0, 0, time.UTC)
afterTime = time.Date(2099, time.December, 31, 0, 0, 0, 0, time.UTC)
scheduledPosts, err = ss.ScheduledPost().GetPendingScheduledPosts(model.GetMillisForTime(jan2100Midnight), model.GetMillisForTime(afterTime), "", 10)
assert.NoError(t, err)
assert.Equal(t, 0, len(scheduledPosts))
})
}
func testPermanentlyDeleteScheduledPosts(t *testing.T, rctx request.CTX, ss store.Store, s SqlStore) {
scheduledPostIDs := []string{}
scheduledPost := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: model.NewId(),
ChannelId: model.NewId(),
Message: "this is a scheduled post",
},
ScheduledAt: model.GetMillis() + 100000,
}
createdScheduledPost, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost.Id)
scheduledPostIDs = append(scheduledPostIDs, createdScheduledPost.Id)
scheduledPost = &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: model.NewId(),
ChannelId: model.NewId(),
Message: "this is a scheduled post 2",
},
ScheduledAt: model.GetMillis() + 100000,
}
createdScheduledPost, err = ss.ScheduledPost().CreateScheduledPost(scheduledPost)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost.Id)
scheduledPostIDs = append(scheduledPostIDs, createdScheduledPost.Id)
scheduledPost = &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: model.NewId(),
ChannelId: model.NewId(),
Message: "this is a scheduled post 3",
},
ScheduledAt: model.GetMillis() + 100000,
}
createdScheduledPost, err = ss.ScheduledPost().CreateScheduledPost(scheduledPost)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost.Id)
scheduledPostIDs = append(scheduledPostIDs, createdScheduledPost.Id)
scheduledPost = &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: model.NewId(),
ChannelId: model.NewId(),
Message: "this is a scheduled post 4",
},
ScheduledAt: model.GetMillis() + 100000,
}
createdScheduledPost, err = ss.ScheduledPost().CreateScheduledPost(scheduledPost)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost.Id)
scheduledPostIDs = append(scheduledPostIDs, createdScheduledPost.Id)
// verify 4 scheduled posts exist
scheduledPosts, err := ss.ScheduledPost().GetPendingScheduledPosts(model.GetMillis()+50000000, model.GetMillis()-100000000, "", 10)
assert.NoError(t, err)
assert.Equal(t, 4, len(scheduledPosts))
// now we'll delete all scheduled posts
err = ss.ScheduledPost().PermanentlyDeleteScheduledPosts(scheduledPostIDs)
assert.NoError(t, err)
// now there should be no posts
scheduledPosts, err = ss.ScheduledPost().GetPendingScheduledPosts(model.GetMillis()+50000000, model.GetMillis()-100000000, "", 10)
assert.NoError(t, err)
assert.Equal(t, 0, len(scheduledPosts))
}
func testUpdatedScheduledPost(t *testing.T, rctx request.CTX, ss store.Store, s SqlStore) {
channel := &model.Channel{
TeamId: "team_id_1",
Type: model.ChannelTypeOpen,
Name: "channel_name",
DisplayName: "Channel Name",
}
createdChannel, err := ss.Channel().Save(rctx, channel, 1000)
assert.NoError(t, err)
defer func() {
_ = ss.Channel().PermanentDelete(rctx, createdChannel.Id)
}()
t.Run("it should update only limited fields", func(t *testing.T) {
userId := model.NewId()
scheduledPost := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: userId,
ChannelId: createdChannel.Id,
Message: "this is a scheduled post",
},
ScheduledAt: model.GetMillis(),
}
createdScheduledPost, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost.Id)
// now we'll update the scheduled post
updateTimestamp := model.GetMillis()
fileID1 := model.NewId()
fileID2 := model.NewId()
newScheduledAt := model.GetMillis()
newUserId := model.NewId()
updateSchedulePost := &model.ScheduledPost{
Id: createdScheduledPost.Id,
ScheduledAt: newScheduledAt,
ErrorCode: "test_error_code",
Draft: model.Draft{
CreateAt: model.GetMillis(),
Message: "updated message",
UpdateAt: updateTimestamp,
UserId: newUserId, // this should not update
ChannelId: model.NewId(), // this should not update
FileIds: []string{fileID1, fileID2},
Priority: model.StringInterface{
"priority": "urgent",
"requested_ack": false,
"persistent_notifications": false,
},
},
}
err = ss.ScheduledPost().UpdatedScheduledPost(updateSchedulePost)
assert.NoError(t, err)
// now we'll get it and verify that intended fields updated and other fields did not
userScheduledPosts, err := ss.ScheduledPost().GetScheduledPostsForUser(userId, channel.TeamId)
assert.NoError(t, err)
assert.Equal(t, 1, len(userScheduledPosts))
// fields that should have changed
assert.Equal(t, newScheduledAt, userScheduledPosts[0].ScheduledAt)
assert.Equal(t, "test_error_code", userScheduledPosts[0].ErrorCode)
assert.Equal(t, "updated message", userScheduledPosts[0].Message)
assert.Equal(t, 2, len(userScheduledPosts[0].FileIds))
assert.Equal(t, "urgent", userScheduledPosts[0].Priority["priority"])
assert.Equal(t, false, userScheduledPosts[0].Priority["requested_ack"])
assert.Equal(t, false, userScheduledPosts[0].Priority["persistent_notifications"])
// fields that should not have changed. Checking them against the original value
assert.Equal(t, createdScheduledPost.Id, userScheduledPosts[0].Id)
assert.Equal(t, userId, userScheduledPosts[0].UserId)
assert.Equal(t, channel.Id, userScheduledPosts[0].ChannelId)
})
t.Run("it should update old scheduled post", func(t *testing.T) {
userId := model.NewId()
scheduledPost := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: userId,
ChannelId: createdChannel.Id,
Message: "this is a scheduled post",
},
ScheduledAt: model.GetMillis() - (24 * 60 * 60 * 1000), // 1 day in the past
}
createdScheduledPost, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost.Id)
// now we'll update the scheduled post
processedAt := model.GetMillis()
scheduledPost.ProcessedAt = processedAt
scheduledPost.ErrorCode = model.ScheduledPostErrorUnknownError
err = ss.ScheduledPost().UpdatedScheduledPost(scheduledPost)
assert.NoError(t, err)
updatedScheduledPost, err := ss.ScheduledPost().Get(scheduledPost.Id)
assert.NoError(t, err)
assert.Equal(t, processedAt, updatedScheduledPost.ProcessedAt)
assert.Equal(t, model.ScheduledPostErrorUnknownError, updatedScheduledPost.ErrorCode)
})
}
func testUpdateOldScheduledPosts(t *testing.T, rctx request.CTX, ss store.Store, s SqlStore) {
setupScheduledPosts := func(baseTime int64, userId, teamId string) func() {
channel := &model.Channel{
TeamId: teamId,
Type: model.ChannelTypeOpen,
Name: "channel_name",
DisplayName: "Channel Name",
}
createdChannel, err := ss.Channel().Save(rctx, channel, 1000)
assert.NoError(t, err)
// Scheduled post 1
scheduledPost1 := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: userId,
ChannelId: createdChannel.Id,
Message: "this is a scheduled post",
},
ScheduledAt: baseTime + 86400000, // 1 day in the future
}
createdScheduledPost1, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost1)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost1.Id)
time.Sleep(100 * time.Millisecond)
// Scheduled post 2
scheduledPost2 := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: userId,
ChannelId: createdChannel.Id,
Message: "this is second scheduled post",
},
ScheduledAt: baseTime + (2 * 86400000), // 2 days in the future
}
createdScheduledPost2, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost2)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost2.Id)
time.Sleep(100 * time.Millisecond)
// Scheduled post 3
scheduledPost3 := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: userId,
ChannelId: createdChannel.Id,
Message: "this is third scheduled post",
},
ScheduledAt: baseTime + (3 * 86400000), // 3 days in the future
}
createdScheduledPost3, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost3)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost3.Id)
time.Sleep(100 * time.Millisecond)
// Scheduled post 4
scheduledPost4 := &model.ScheduledPost{
Draft: model.Draft{
CreateAt: model.GetMillis(),
UserId: userId,
ChannelId: createdChannel.Id,
Message: "this is fourth scheduled post",
},
ScheduledAt: baseTime + (4 * 86400000), // 4 days in the future
}
createdScheduledPost4, err := ss.ScheduledPost().CreateScheduledPost(scheduledPost4)
assert.NoError(t, err)
assert.NotEmpty(t, createdScheduledPost4.Id)
return func() {
_ = ss.ScheduledPost().PermanentlyDeleteScheduledPosts([]string{
createdScheduledPost1.Id,
createdScheduledPost2.Id,
createdScheduledPost3.Id,
createdScheduledPost4.Id,
})
_ = ss.Channel().PermanentDelete(rctx, createdChannel.Id)
}
}
t.Run("should update only old scheduled posts", func(t *testing.T) {
now := model.GetMillis()
userId := model.NewId()
teamId := model.NewId()
cleanup := setupScheduledPosts(now, userId, teamId)
defer cleanup()
err := ss.ScheduledPost().UpdateOldScheduledPosts(now + 2.5*86400000) // marking all posts older than 2 days from now
assert.NoError(t, err)
scheduledPosts, err := ss.ScheduledPost().GetScheduledPostsForUser(userId, teamId)
assert.NoError(t, err)
assert.Equal(t, 4, len(scheduledPosts))
assert.Equal(t, model.ScheduledPostErrorUnableToSend, scheduledPosts[0].ErrorCode)
assert.Equal(t, model.ScheduledPostErrorUnableToSend, scheduledPosts[1].ErrorCode)
assert.Equal(t, "", scheduledPosts[2].ErrorCode)
assert.Equal(t, "", scheduledPosts[3].ErrorCode)
})
}

Просмотреть файл

@@ -65,6 +65,7 @@ type Store struct {
PostPersistentNotificationStore mocks.PostPersistentNotificationStore
DesktopTokensStore mocks.DesktopTokensStore
ChannelBookmarkStore mocks.ChannelBookmarkStore
ScheduledPostStore mocks.ScheduledPostStore
}
func (s *Store) SetContext(context context.Context) { s.context = context }
@@ -117,6 +118,7 @@ func (s *Store) Group() store.GroupStore { return &s.GroupSt
func (s *Store) LinkMetadata() store.LinkMetadataStore { return &s.LinkMetadataStore }
func (s *Store) SharedChannel() store.SharedChannelStore { return &s.SharedChannelStore }
func (s *Store) PostPriority() store.PostPriorityStore { return &s.PostPriorityStore }
func (s *Store) ScheduledPost() store.ScheduledPostStore { return &s.ScheduledPostStore }
func (s *Store) PostAcknowledgement() store.PostAcknowledgementStore {
return &s.PostAcknowledgementStore
}
@@ -188,5 +190,6 @@ func (s *Store) AssertExpectations(t mock.TestingT) bool {
&s.PostPersistentNotificationStore,
&s.DesktopTokensStore,
&s.ChannelBookmarkStore,
&s.ScheduledPostStore,
)
}