[MM-37064] - Onboarding flow is showing for existing users (#17977)

* [MM-37064] - Onboarding flow is showing for existing users

* add tests

* fix typo

* fix lint

* fix tests

api4/preference_test.go

@@ -48,7 +48,9 @@ func TestGetPreferences(t *testing.T) {
 
 	prefs, resp := Client.GetPreferences(user1.Id)
 	CheckNoError(t, resp)
-	require.Equal(t, len(prefs), 4, "received the wrong number of preferences")
+
+	// 5 because we have 2 initial preferences tutorial_step and recommended_next_steps added when creating a new user
+	require.Equal(t, len(prefs), 5, "received the wrong number of preferences")
 
 	for _, preference := range prefs {
 		require.Equal(t, preference.UserId, th.BasicUser.Id, "user id does not match")