Merge pull request #194 from ralder/fix-command-box-css

[webui] fix command-list css

web/react/components/command_list.jsx

@@ -20,12 +20,7 @@ module.exports = React.createClass({
     },
     getSuggestedCommands: function(cmd) {
 
-        if (cmd == "") {
-            this.setState({ suggestions: [ ], cmd: "" });
-            return;
-        }
-
-        if (cmd.indexOf("/") != 0) {
+        if (!cmd || cmd.charAt(0) != '/') {
             this.setState({ suggestions: [ ], cmd: "" });
             return;
         }
@@ -35,17 +30,19 @@ module.exports = React.createClass({
             cmd,
             true,
             function(data) {
-                if (data.suggestions.length === 1 && data.suggestions[0].suggestion === cmd) data.suggestions = [];
+                if (data.suggestions.length === 1 && data.suggestions[0].suggestion === cmd) {
+                    data.suggestions = [];
+                }
                 this.setState({ suggestions: data.suggestions, cmd: cmd  });
             }.bind(this),
             function(err){
-            }.bind(this)
+            }
         );
     },
     render: function() {
         if (this.state.suggestions.length == 0) return (<div/>);
 
-        var suggestions = []
+        var suggestions = [];
 
         for (var i = 0; i < this.state.suggestions.length; i++) {
             if (this.state.suggestions[i].suggestion != this.state.cmd) {
@@ -59,7 +56,7 @@ module.exports = React.createClass({
         }
 
         return (
-            <div ref="mentionlist" className="command-box" style={{height:(this.state.suggestions*37)+2}}>
+            <div ref="mentionlist" className="command-box" style={{height:(this.state.suggestions.length*37)+2}}>
                 { suggestions }
             </div>
         );

web/react/components/error_bar.jsx

@@ -8,21 +8,25 @@ var Constants = require('../utils/constants.jsx');
 var ActionTypes = Constants.ActionTypes;
 
 function getStateFromStores() {
-  var error = ErrorStore.getLastError();
-  if (error && error.message !== "There appears to be a problem with your internet connection") {
-      return { message: error.message };
-  } else {
-     return { message: null };
-  }
+    var error = ErrorStore.getLastError();
+    if (error && error.message !== "There appears to be a problem with your internet connection") {
+        return { message: error.message };
+    } else {
+        return { message: null };
+    }
 }
 
 module.exports = React.createClass({
+    displayName: 'ErrorBar',
+
     componentDidMount: function() {
         ErrorStore.addChangeListener(this._onChange);
-        $('body').css('padding-top', $('#error_bar').outerHeight());
-        $(window).resize(function(){
-            $('body').css('padding-top', $('#error_bar').outerHeight());
-        });
+        $('body').css('padding-top', $(React.findDOMNode(this)).outerHeight());
+        $(window).resize(function() {
+            if (this.state.message) {
+                $('body').css('padding-top', $(React.findDOMNode(this)).outerHeight());
+            }
+        }.bind(this));
     },
     componentWillUnmount: function() {
         ErrorStore.removeChangeListener(this._onChange);
@@ -31,39 +35,39 @@ module.exports = React.createClass({
         var newState = getStateFromStores();
         if (!utils.areStatesEqual(newState, this.state)) {
             if (newState.message) {
-                var self = this;
-                setTimeout(function(){self.handleClose();}, 10000);
+                setTimeout(this.handleClose, 10000);
             }
+
             this.setState(newState);
         }
     },
     handleClose: function(e) {
         if (e) e.preventDefault();
+
         AppDispatcher.handleServerAction({
             type: ActionTypes.RECIEVED_ERROR,
             err: null
         });
+
         $('body').css('padding-top', '0');
     },
     getInitialState: function() {
         var state = getStateFromStores();
         if (state.message) {
-            var self = this;
-            setTimeout(function(){self.handleClose();}, 10000);
+            setTimeout(this.handleClose, 10000);
         }
         return state;
     },
     render: function() {
-        var message = this.state.message;
-        if (message) {
+        if (this.state.message) {
             return (
                 <div className="error-bar">
-                    <span className="error-text">{message}</span>
-                    <a href="#" className="error-close pull-right" onClick={this.handleClose}>×</a>
+                    <span>{this.state.message}</span>
+                    <a href="#" className="error-bar__close" onClick={this.handleClose}>&times;</a>
                 </div>
             );
         } else {
             return <div/>;
         }
     }
-});
+});

web/react/components/sidebar_header.jsx

@@ -101,13 +101,13 @@ module.exports = React.createClass({
 
     getDefaultProps: function() {
         return {
-            teamName: config.SiteName
+            teamDisplayName: config.SiteName
         };
     },
 
     render: function() {
-        var teamDisplayName = this.props.teamDisplayName ? this.props.teamDisplayName : config.SiteName;
-        var me = UserStore.getCurrentUser()
+        var me = UserStore.getCurrentUser();
+
         if (!me) {
             return null;
         }
@@ -118,11 +118,11 @@ module.exports = React.createClass({
                     { me.last_picture_update ?
                     <img className="user__picture" src={"/api/v1/users/" + me.id + "/image?time=" + me.update_at} />
                     :
-                    <div />
+                    null
                     }
                     <div className="header__info">
                         <div className="user__name">{ '@' + me.username}</div>
-                        <div className="team__name">{ teamDisplayName }</div>
+                        <div className="team__name">{ this.props.teamDisplayName }</div>
                     </div>
                 </a>
                 <NavbarDropdown teamType={this.props.teamType} />

web/react/stores/user_store.jsx

@@ -183,6 +183,9 @@ var UserStore = assign({}, EventEmitter.prototype, {
 
     var keys = [];
 
+    if (!user)
+        return keys;
+
     if (user.notify_props && user.notify_props.mention_keys) keys = keys.concat(user.notify_props.mention_keys.split(','));
     if (user.first_name && user.notify_props.first_name === "true") keys.push(user.first_name);
     if (user.notify_props.all === "true") keys.push('@all');
@@ -258,4 +261,3 @@ UserStore.dispatchToken = AppDispatcher.register(function(payload) {
 UserStore.setMaxListeners(0);
 global.window.UserStore = UserStore;
 module.exports = UserStore;
-