Merge pull request #1167 from rgarmsen2295/plt-468

PLT-468 Fixed various React warnings
Этот коммит содержится в:
Corey Hulen
2015-10-24 09:24:47 -07:00
родитель 03140752e6 d6d5f9310e
Коммит db1834ce26
3 изменённых файлов: 11 добавлений и 16 удалений

Просмотреть файл

@@ -136,16 +136,15 @@ export default class ChannelNotifications extends React.Component {
var inputs = []; var inputs = [];
inputs.push( inputs.push(
<div> <div key='channel-notification-level-radio'>
<div className='radio'> <div className='radio'>
<label> <label>
<input <input
type='radio' type='radio'
checked={notifyActive[0]} checked={notifyActive[0]}
onChange={this.handleUpdateNotifyLevel.bind(this, 'default')} onChange={this.handleUpdateNotifyLevel.bind(this, 'default')}
> />
{`Global default (${globalNotifyLevelName})`} {`Global default (${globalNotifyLevelName})`}
</input>
</label> </label>
<br/> <br/>
</div> </div>
@@ -155,9 +154,8 @@ export default class ChannelNotifications extends React.Component {
type='radio' type='radio'
checked={notifyActive[1]} checked={notifyActive[1]}
onChange={this.handleUpdateNotifyLevel.bind(this, 'all')} onChange={this.handleUpdateNotifyLevel.bind(this, 'all')}
> />
{'For all activity'} {'For all activity'}
</input>
</label> </label>
<br/> <br/>
</div> </div>
@@ -167,9 +165,8 @@ export default class ChannelNotifications extends React.Component {
type='radio' type='radio'
checked={notifyActive[2]} checked={notifyActive[2]}
onChange={this.handleUpdateNotifyLevel.bind(this, 'mention')} onChange={this.handleUpdateNotifyLevel.bind(this, 'mention')}
> />
{'Only for mentions'} {'Only for mentions'}
</input>
</label> </label>
<br/> <br/>
</div> </div>
@@ -179,9 +176,8 @@ export default class ChannelNotifications extends React.Component {
type='radio' type='radio'
checked={notifyActive[3]} checked={notifyActive[3]}
onChange={this.handleUpdateNotifyLevel.bind(this, 'none')} onChange={this.handleUpdateNotifyLevel.bind(this, 'none')}
> />
{'Never'} {'Never'}
</input>
</label> </label>
</div> </div>
</div> </div>
@@ -274,16 +270,15 @@ export default class ChannelNotifications extends React.Component {
if (this.state.activeSection === 'markUnreadLevel') { if (this.state.activeSection === 'markUnreadLevel') {
const inputs = [( const inputs = [(
<div> <div key='channel-notification-unread-radio'>
<div className='radio'> <div className='radio'>
<label> <label>
<input <input
type='radio' type='radio'
checked={this.state.markUnreadLevel === 'all'} checked={this.state.markUnreadLevel === 'all'}
onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'all')} onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'all')}
> />
{'For all unread messages'} {'For all unread messages'}
</input>
</label> </label>
<br /> <br />
</div> </div>
@@ -293,9 +288,8 @@ export default class ChannelNotifications extends React.Component {
type='radio' type='radio'
checked={this.state.markUnreadLevel === 'mention'} checked={this.state.markUnreadLevel === 'mention'}
onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'mention')} onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'mention')}
> />
{'Only for mentions'} {'Only for mentions'}
</input>
</label> </label>
<br /> <br />
</div> </div>
@@ -370,7 +364,7 @@ export default class ChannelNotifications extends React.Component {
data-dismiss='modal' data-dismiss='modal'
> >
<span aria-hidden='true'>&times;</span> <span aria-hidden='true'>&times;</span>
<span className='sr-only'>Close</span> <span className='sr-only'>{'Close'}</span>
</button> </button>
<h4 className='modal-title'>Notification Preferences for <span className='name'>{this.state.title}</span></h4> <h4 className='modal-title'>Notification Preferences for <span className='name'>{this.state.title}</span></h4>
</div> </div>

Просмотреть файл

@@ -169,7 +169,7 @@ export default class MoreDirectChannels extends React.Component {
} }
return ( return (
<tr> <tr key={'direct-channel-row-user' + user.id}>
<td <td
key={user.id} key={user.id}
className='direct-channel' className='direct-channel'

Просмотреть файл

@@ -198,6 +198,7 @@ export default class SearchBar extends React.Component {
completeWord={this.completeWord} completeWord={this.completeWord}
/> />
<Popover <Popover
id='searchbar-help-popup'
placement='bottom' placement='bottom'
className={helpClass} className={helpClass}
> >