diff --git a/server/.golangci.yml b/server/.golangci.yml index bbc0b31315..2f3bb1f74d 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -18,7 +18,6 @@ linters: - govet - ineffassign - revive - - exportloopref - staticcheck - unconvert - unused diff --git a/server/channels/app/channel_test.go b/server/channels/app/channel_test.go index 8511ab21ad..0294c26405 100644 --- a/server/channels/app/channel_test.go +++ b/server/channels/app/channel_test.go @@ -2493,7 +2493,6 @@ func TestIsCRTEnabledForUser(t *testing.T) { } for _, tc := range testCases { - tc := tc t.Run(tc.desc, func(t *testing.T) { th := SetupWithStoreMock(t) defer th.TearDown() diff --git a/server/channels/app/platform/metrics_test.go b/server/channels/app/platform/metrics_test.go index 428a1aa733..a4aec5b483 100644 --- a/server/channels/app/platform/metrics_test.go +++ b/server/channels/app/platform/metrics_test.go @@ -57,8 +57,6 @@ func TestMetricsRouter(t *testing.T) { "pprof trace": {path: "/debug/pprof/trace"}, } { t.Run(name, func(t *testing.T) { - name := name // TODO: Remove once go1.22 is used - tc := tc // TODO: Remove once go1.22 is used t.Parallel() method := http.MethodGet diff --git a/server/channels/app/post_metadata_test.go b/server/channels/app/post_metadata_test.go index 982c6156f6..73da418b1f 100644 --- a/server/channels/app/post_metadata_test.go +++ b/server/channels/app/post_metadata_test.go @@ -1472,7 +1472,6 @@ func TestGetEmojiNamesForString(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { emojis := getEmojiNamesForString(testCase.Input) assert.ElementsMatch(t, emojis, testCase.Expected, "received incorrect emoji names") @@ -1568,7 +1567,6 @@ func TestGetEmojiNamesForPost(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { emojis := getEmojiNamesForPost(testCase.Post, testCase.Reactions) assert.ElementsMatch(t, emojis, testCase.Expected, "received incorrect emoji names") @@ -2829,7 +2827,6 @@ func TestContainsPermalink(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { actual := th.App.containsPermalink(th.Context, testCase.Post) assert.Equal(t, testCase.Expected, actual) diff --git a/server/channels/app/post_test.go b/server/channels/app/post_test.go index f3d562f58f..c3f8cba1b4 100644 --- a/server/channels/app/post_test.go +++ b/server/channels/app/post_test.go @@ -757,7 +757,6 @@ func TestMaxPostSize(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { mockStore := &storetest.Store{} defer mockStore.AssertExpectations(t) diff --git a/server/channels/store/sqlstore/store_test.go b/server/channels/store/sqlstore/store_test.go index ef739394c2..39295849e5 100644 --- a/server/channels/store/sqlstore/store_test.go +++ b/server/channels/store/sqlstore/store_test.go @@ -277,7 +277,6 @@ func TestGetReplica(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description+" with license", func(t *testing.T) { settings, err := makeSqlSettings(model.DatabaseDriverPostgres) if err != nil { @@ -647,7 +646,6 @@ func TestGetAllConns(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { t.Parallel() settings, err := makeSqlSettings(model.DatabaseDriverPostgres) diff --git a/server/channels/utils/utils_test.go b/server/channels/utils/utils_test.go index 6a531d3a82..f43891766a 100644 --- a/server/channels/utils/utils_test.go +++ b/server/channels/utils/utils_test.go @@ -272,7 +272,6 @@ func TestRoundOffToZeroes(t *testing.T) { }, } for _, tc := range testCases { - tc := tc t.Run(tc.desc, func(t *testing.T) { res := RoundOffToZeroes(tc.n) assert.Equal(t, tc.expected, res) @@ -427,7 +426,6 @@ func TestRoundOffToZeroesResolution(t *testing.T) { }, } for _, tc := range testCases { - tc := tc t.Run(tc.desc, func(t *testing.T) { res := RoundOffToZeroesResolution(tc.n, tc.minResolution) assert.Equal(t, tc.expected, res) diff --git a/server/channels/web/params_test.go b/server/channels/web/params_test.go index dcdaad060d..78c0241192 100644 --- a/server/channels/web/params_test.go +++ b/server/channels/web/params_test.go @@ -480,7 +480,6 @@ func TestParamsFromRequest(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { t.Parallel() diff --git a/server/cmd/mmctl/commands/completion_test.go b/server/cmd/mmctl/commands/completion_test.go index 9fce818b0a..b6eb876de1 100644 --- a/server/cmd/mmctl/commands/completion_test.go +++ b/server/cmd/mmctl/commands/completion_test.go @@ -135,8 +135,6 @@ func TestFetchAndComplete(t *testing.T) { }, } { t.Run(name, func(t *testing.T) { - name := name // TODO: Remove once go1.22 is used - tc := tc // TODO: Remove once go1.22 is used t.Parallel() comp, directive := fetchAndComplete[user](tc.fetcher, tc.matcher)(context.Background(), nil, nil, nil, tc.toComplete) diff --git a/server/config/client_test.go b/server/config/client_test.go index 9c37f54a62..04537e016f 100644 --- a/server/config/client_test.go +++ b/server/config/client_test.go @@ -322,7 +322,6 @@ func TestGetClientConfig(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.description, func(t *testing.T) { t.Parallel() @@ -414,7 +413,6 @@ func TestGetLimitedClientConfig(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.description, func(t *testing.T) { t.Parallel() diff --git a/server/public/model/command_response_test.go b/server/public/model/command_response_test.go index 264951a19a..e2a8f660a9 100644 --- a/server/public/model/command_response_test.go +++ b/server/public/model/command_response_test.go @@ -204,7 +204,6 @@ func TestCommandResponseFromJSON(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { t.Parallel() diff --git a/server/public/model/utils_test.go b/server/public/model/utils_test.go index c468d06ed8..1c1b1cd986 100644 --- a/server/public/model/utils_test.go +++ b/server/public/model/utils_test.go @@ -963,7 +963,6 @@ func TestNowhereNil(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { defer func() { if r := recover(); r != nil { @@ -1196,7 +1195,6 @@ func TestIsValidHTTPURL(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { defer func() { if r := recover(); r != nil { diff --git a/server/public/utils/json_test.go b/server/public/utils/json_test.go index 815f19fe54..95ecdcc815 100644 --- a/server/public/utils/json_test.go +++ b/server/public/utils/json_test.go @@ -62,7 +62,6 @@ func TestHumanizeJsonError(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { actual := utils.HumanizeJSONError(testCase.Err, testCase.Data) if testCase.ExpectedErr == "" { @@ -222,7 +221,6 @@ func TestNewHumanizedJSONError(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { actual := utils.NewHumanizedJSONError(testCase.Err, testCase.Data, testCase.Offset) if testCase.Expected != nil && actual.Err != nil { @@ -291,7 +289,6 @@ func TestIsJSONEmpty(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { empty := utils.IsEmptyJSON(testCase.Data) assert.Equal(t, testCase.Empty, empty) @@ -348,7 +345,6 @@ func TestStringPtrToJSON(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { j := utils.StringPtrToJSON(testCase.Ptr) assert.Equal(t, testCase.Expect, j)