From d9e3125e8785624e2e87bf972002bef19ba7bd99 Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Thu, 5 May 2022 22:05:50 +0530 Subject: [PATCH] MM-42997: Fix flaky TestDeletePostEvent (#20133) We increase the timeout further. Without this, there is no reliable way to wait for a message. Also consolidated the timeout values for other tests. https://mattermost.atlassian.net/browse/MM-42997 ```release-note NONE ``` --- api4/post_test.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/api4/post_test.go b/api4/post_test.go index b13958028e..00c7a6474e 100644 --- a/api4/post_test.go +++ b/api4/post_test.go @@ -130,7 +130,7 @@ func TestCreatePost(t *testing.T) { require.NoError(t, err) // Message with no channel mentions should result in no ephemeral message - timeout := time.After(300 * time.Millisecond) + timeout := time.After(2 * time.Second) waiting := true for waiting { select { @@ -156,7 +156,7 @@ func TestCreatePost(t *testing.T) { _, _, err = client.CreatePost(post) require.NoError(t, err) - timeout = time.After(600 * time.Millisecond) + timeout = time.After(2 * time.Second) eventsToGo := 3 // 3 Posts created with @ mentions should result in 3 websocket events for eventsToGo > 0 { select { @@ -553,7 +553,7 @@ func TestCreatePostSendOutOfChannelMentions(t *testing.T) { require.NoError(t, err) CheckCreatedStatus(t, resp) - timeout := time.After(300 * time.Millisecond) + timeout := time.After(2 * time.Second) waiting := true for waiting { select { @@ -572,7 +572,7 @@ func TestCreatePostSendOutOfChannelMentions(t *testing.T) { require.NoError(t, err) CheckCreatedStatus(t, resp) - timeout = time.After(300 * time.Millisecond) + timeout = time.After(2 * time.Second) waiting = true for waiting { select { @@ -2053,7 +2053,6 @@ func TestDeletePost(t *testing.T) { } func TestDeletePostEvent(t *testing.T) { - t.Skip("MM-42997") th := Setup(t).InitBasic() defer th.TearDown() @@ -2077,7 +2076,7 @@ func TestDeletePostEvent(t *testing.T) { require.NoError(t, err) received = true } - case <-time.After(500 * time.Millisecond): + case <-time.After(2 * time.Second): exit = true } if exit {