Fix flaky test TestScheduledPostStore (#29301)
There were couple of errors in the test: 1. UpdatedScheduledPost will automatically set the ProcessedAt to now internally inside toUpdateMap. So setting the value from outside has no effect. 2. The bug was that if it took more than a milisecond to capture the time, and then do the internal call, then the Get call will have a higher value and therefore fail. Since UpdatedScheduledPost doesn't return an updated post, so there is no need to compare the timestamps at all. ```release-note NONE ```
Этот коммит содержится в:
коммит произвёл
GitHub
родитель
504934b612
Коммит
d6a89c69c2
@@ -349,8 +349,7 @@ func testUpdatedScheduledPost(t *testing.T, rctx request.CTX, ss store.Store, s
|
|||||||
assert.NotEmpty(t, createdScheduledPost.Id)
|
assert.NotEmpty(t, createdScheduledPost.Id)
|
||||||
|
|
||||||
// now we'll update the scheduled post
|
// now we'll update the scheduled post
|
||||||
processedAt := model.GetMillis()
|
now := model.GetMillis()
|
||||||
scheduledPost.ProcessedAt = processedAt
|
|
||||||
scheduledPost.ErrorCode = model.ScheduledPostErrorUnknownError
|
scheduledPost.ErrorCode = model.ScheduledPostErrorUnknownError
|
||||||
|
|
||||||
err = ss.ScheduledPost().UpdatedScheduledPost(scheduledPost)
|
err = ss.ScheduledPost().UpdatedScheduledPost(scheduledPost)
|
||||||
@@ -358,7 +357,7 @@ func testUpdatedScheduledPost(t *testing.T, rctx request.CTX, ss store.Store, s
|
|||||||
|
|
||||||
updatedScheduledPost, err := ss.ScheduledPost().Get(scheduledPost.Id)
|
updatedScheduledPost, err := ss.ScheduledPost().Get(scheduledPost.Id)
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, processedAt, updatedScheduledPost.ProcessedAt)
|
assert.LessOrEqual(t, now, updatedScheduledPost.ProcessedAt)
|
||||||
assert.Equal(t, model.ScheduledPostErrorUnknownError, updatedScheduledPost.ErrorCode)
|
assert.Equal(t, model.ScheduledPostErrorUnknownError, updatedScheduledPost.ErrorCode)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
Ссылка в новой задаче
Block a user