From d1962e123e12b1a5e96c17dacd6ed26786726a0d Mon Sep 17 00:00:00 2001 From: Arya Khochare <91268931+Aryakoste@users.noreply.github.com> Date: Wed, 9 Oct 2024 15:23:25 +0530 Subject: [PATCH] [MM-60932] Fix errcheck issues in server/channels/api4/usage.go (#28641) --- server/.golangci.yml | 1 - server/channels/api4/usage.go | 13 ++++++++++--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index 4d869b6d0e..0257412597 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -99,7 +99,6 @@ issues: channels/api4/team_local.go|\ channels/api4/team_test.go|\ channels/api4/upload_test.go|\ - channels/api4/usage.go|\ channels/api4/usage_test.go|\ channels/api4/user.go|\ channels/api4/user_local.go|\ diff --git a/server/channels/api4/usage.go b/server/channels/api4/usage.go index 5657e7f178..6411446129 100644 --- a/server/channels/api4/usage.go +++ b/server/channels/api4/usage.go @@ -8,6 +8,7 @@ import ( "net/http" "github.com/mattermost/mattermost/server/public/model" + "github.com/mattermost/mattermost/server/public/shared/mlog" "github.com/mattermost/mattermost/server/v8/channels/utils" ) @@ -33,7 +34,9 @@ func getPostsUsage(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(json) + if _, err := w.Write(json); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func getStorageUsage(c *Context, w http.ResponseWriter, r *http.Request) { @@ -50,7 +53,9 @@ func getStorageUsage(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(json) + if _, err := w.Write(json); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func getTeamsUsage(c *Context, w http.ResponseWriter, r *http.Request) { @@ -70,5 +75,7 @@ func getTeamsUsage(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(json) + if _, err := w.Write(json); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } }