diff --git a/api4/user.go b/api4/user.go index d576eb2703..c498f626cd 100644 --- a/api4/user.go +++ b/api4/user.go @@ -123,16 +123,9 @@ func createUser(c *Context, w http.ResponseWriter, r *http.Request) { var ruser *model.User var err *model.AppError if tokenId != "" { - token, nErr := c.App.Srv().Store.Token().GetByToken(tokenId) - if nErr != nil { - var status int - switch nErr.(type) { - case *store.ErrNotFound: - status = http.StatusNotFound - default: - status = http.StatusInternalServerError - } - c.Err = model.NewAppError("CreateUserWithToken", "api.user.create_user.signup_link_invalid.app_error", nil, nErr.Error(), status) + token, appErr := c.App.GetTokenById(tokenId) + if appErr != nil { + c.Err = appErr return } auditRec.AddMeta("token_type", token.Type) diff --git a/app/app_iface.go b/app/app_iface.go index ed104d831f..f129aa5001 100644 --- a/app/app_iface.go +++ b/app/app_iface.go @@ -757,6 +757,7 @@ type AppIface interface { GetThreadMembershipForUser(userId, threadId string) (*model.ThreadMembership, *model.AppError) GetThreadMembershipsForUser(userID, teamID string) ([]*model.ThreadMembership, error) GetThreadsForUser(userID, teamID string, options model.GetUserThreadsOpts) (*model.Threads, *model.AppError) + GetTokenById(token string) (*model.Token, *model.AppError) GetUploadSession(uploadId string) (*model.UploadSession, *model.AppError) GetUploadSessionsForUser(userID string) ([]*model.UploadSession, *model.AppError) GetUser(userID string) (*model.User, *model.AppError) diff --git a/app/opentracing/opentracing_layer.go b/app/opentracing/opentracing_layer.go index 7c6b9ef2f6..c9b6e649ec 100644 --- a/app/opentracing/opentracing_layer.go +++ b/app/opentracing/opentracing_layer.go @@ -9330,6 +9330,28 @@ func (a *OpenTracingAppLayer) GetThreadsForUser(userID string, teamID string, op return resultVar0, resultVar1 } +func (a *OpenTracingAppLayer) GetTokenById(token string) (*model.Token, *model.AppError) { + origCtx := a.ctx + span, newCtx := tracing.StartSpanWithParentByContext(a.ctx, "app.GetTokenById") + + a.ctx = newCtx + a.app.Srv().Store.SetContext(newCtx) + defer func() { + a.app.Srv().Store.SetContext(origCtx) + a.ctx = origCtx + }() + + defer span.Finish() + resultVar0, resultVar1 := a.app.GetTokenById(token) + + if resultVar1 != nil { + span.LogFields(spanlog.Error(resultVar1)) + ext.Error.Set(span, true) + } + + return resultVar0, resultVar1 +} + func (a *OpenTracingAppLayer) GetTotalUsersStats(viewRestrictions *model.ViewUsersRestrictions) (*model.UsersStats, *model.AppError) { origCtx := a.ctx span, newCtx := tracing.StartSpanWithParentByContext(a.ctx, "app.GetTotalUsersStats") diff --git a/app/user.go b/app/user.go index fe2c57cc19..0014a67373 100644 --- a/app/user.go +++ b/app/user.go @@ -1353,6 +1353,25 @@ func (a *App) GetPasswordRecoveryToken(token string) (*model.Token, *model.AppEr return rtoken, nil } +func (a *App) GetTokenById(token string) (*model.Token, *model.AppError) { + rtoken, err := a.Srv().Store.Token().GetByToken(token) + + if err != nil { + var status int + + switch err.(type) { + case *store.ErrNotFound: + status = http.StatusNotFound + default: + status = http.StatusInternalServerError + } + + return nil, model.NewAppError("GetTokenById", "api.user.create_user.signup_link_invalid.app_error", nil, err.Error(), status) + } + + return rtoken, nil +} + func (a *App) DeleteToken(token *model.Token) *model.AppError { err := a.Srv().Store.Token().Delete(token.Token) if err != nil {