diff --git a/app/team.go b/app/team.go index 0550e46753..e2baf7a5ba 100644 --- a/app/team.go +++ b/app/team.go @@ -1312,8 +1312,8 @@ func (a *App) RemoveTeamIcon(teamId string) *model.AppError { } func (a *App) InvalidateAllEmailInvites() *model.AppError { - if result := <-a.Srv.Store.Token().RemoveAllTokensByType(TOKEN_TYPE_TEAM_INVITATION); result.Err != nil { - return model.NewAppError("InvalidateAllEmailInvites", "api.team.invalidate_all_email_invites.app_error", nil, result.Err.Error(), http.StatusBadRequest) + if err := a.Srv.Store.Token().RemoveAllTokensByType(TOKEN_TYPE_TEAM_INVITATION); err != nil { + return model.NewAppError("InvalidateAllEmailInvites", "api.team.invalidate_all_email_invites.app_error", nil, err.Error(), http.StatusBadRequest) } return nil } diff --git a/store/sqlstore/tokens_store.go b/store/sqlstore/tokens_store.go index c13bef44f4..2a419d2147 100644 --- a/store/sqlstore/tokens_store.go +++ b/store/sqlstore/tokens_store.go @@ -72,11 +72,9 @@ func (s SqlTokenStore) Cleanup() { } } -func (s SqlTokenStore) RemoveAllTokensByType(tokenType string) store.StoreChannel { - return store.Do(func(result *store.StoreResult) { - if _, err := s.GetMaster().Exec("DELETE FROM Tokens WHERE Type = :TokenType", map[string]interface{}{"TokenType": tokenType}); err != nil { - result.Err = model.NewAppError("SqlTokenStore.RemoveAllTokensByType", "store.sql_recover.remove_all_tokens_by_type.app_error", nil, err.Error(), http.StatusInternalServerError) - return - } - }) +func (s SqlTokenStore) RemoveAllTokensByType(tokenType string) *model.AppError { + if _, err := s.GetMaster().Exec("DELETE FROM Tokens WHERE Type = :TokenType", map[string]interface{}{"TokenType": tokenType}); err != nil { + return model.NewAppError("SqlTokenStore.RemoveAllTokensByType", "store.sql_recover.remove_all_tokens_by_type.app_error", nil, err.Error(), http.StatusInternalServerError) + } + return nil } diff --git a/store/store.go b/store/store.go index a06fb0048b..3afd1a4e72 100644 --- a/store/store.go +++ b/store/store.go @@ -454,7 +454,7 @@ type TokenStore interface { Delete(token string) *model.AppError GetByToken(token string) (*model.Token, *model.AppError) Cleanup() - RemoveAllTokensByType(tokenType string) StoreChannel + RemoveAllTokensByType(tokenType string) *model.AppError } type EmojiStore interface { diff --git a/store/storetest/mocks/TokenStore.go b/store/storetest/mocks/TokenStore.go index a58b66013c..b295467f20 100644 --- a/store/storetest/mocks/TokenStore.go +++ b/store/storetest/mocks/TokenStore.go @@ -6,7 +6,6 @@ package mocks import mock "github.com/stretchr/testify/mock" import model "github.com/mattermost/mattermost-server/model" -import store "github.com/mattermost/mattermost-server/store" // TokenStore is an autogenerated mock type for the TokenStore type type TokenStore struct { @@ -60,15 +59,15 @@ func (_m *TokenStore) GetByToken(token string) (*model.Token, *model.AppError) { } // RemoveAllTokensByType provides a mock function with given fields: tokenType -func (_m *TokenStore) RemoveAllTokensByType(tokenType string) store.StoreChannel { +func (_m *TokenStore) RemoveAllTokensByType(tokenType string) *model.AppError { ret := _m.Called(tokenType) - var r0 store.StoreChannel - if rf, ok := ret.Get(0).(func(string) store.StoreChannel); ok { + var r0 *model.AppError + if rf, ok := ret.Get(0).(func(string) *model.AppError); ok { r0 = rf(tokenType) } else { if ret.Get(0) != nil { - r0 = ret.Get(0).(store.StoreChannel) + r0 = ret.Get(0).(*model.AppError) } }