From c7aa2fdbb53cfa940570c4b44e101e093583fe16 Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Thu, 16 Jun 2022 12:34:08 +0530 Subject: [PATCH] MM-43832: Fix flaky TestReadReplicaDisabledBasedOnLicense (#20483) The config store was incorrectly initialized. Other than that, I don't think there is any "flakyness" in the test. https://mattermost.atlassian.net/browse/MM-43832 ```release-note NONE ``` --- app/server_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/server_test.go b/app/server_test.go index 3b127a6e33..710aa302a1 100644 --- a/app/server_test.go +++ b/app/server_test.go @@ -60,7 +60,6 @@ func TestStartServerSuccess(t *testing.T) { } func TestReadReplicaDisabledBasedOnLicense(t *testing.T) { - t.Skip("TODO: fix flaky test") cfg := model.Config{} cfg.SetDefaults() driverName := os.Getenv("MM_SQLSETTINGS_DRIVERNAME") @@ -97,6 +96,7 @@ func TestReadReplicaDisabledBasedOnLicense(t *testing.T) { s, err := NewServer(func(server *Server) error { configStore := config.NewTestMemoryStore() configStore.Set(&cfg) + server.configStore = &configWrapper{srv: server, Store: configStore} server.licenseValue.Store(model.NewTestLicense()) return nil })