MM-19445 - Fix conditional for plugin version diagnostics (#13844)

* Merge upstream

* Adding plugin version data if no error

* linting

Co-authored-by: Jason Paul Deland <9366595+jaydeland@users.noreply.github.com>

app/diagnostics.go

@@ -635,8 +635,10 @@ func (a *App) trackConfig() {
 	}
 
 	pluginsEnvironment := a.GetPluginsEnvironment()
-	plugins, appErr := pluginsEnvironment.Available()
+
-	if appErr != nil {
+	if plugins, appErr := pluginsEnvironment.Available(); appErr != nil {
+		mlog.Error("Unable to add plugin versions to diagnostics", mlog.Err(appErr))
+	} else {
 		pluginConfigData["version_antivirus"] = pluginVersion(plugins, "antivirus")
 		pluginConfigData["version_autolink"] = pluginVersion(plugins, "mattermost-autolink")
 		pluginConfigData["version_aws_sns"] = pluginVersion(plugins, "com.mattermost.aws-sns")