[MM-55990] Logger improvements for tests (#25467)

server/platform/services/sharedchannel/channelinvite_test.go

@@ -22,9 +22,8 @@ import (
 func TestOnReceiveChannelInvite(t *testing.T) {
 	t.Run("when msg payload is empty, it does nothing", func(t *testing.T) {
 		mockServer := &MockServerIface{}
-		mockLogger, err := mlog.NewLogger()
-		require.NoError(t, err)
-		mockServer.On("Log").Return(mockLogger)
+		logger := mlog.CreateConsoleTestLogger(t)
+		mockServer.On("Log").Return(logger)
 		mockApp := &MockAppIface{}
 		scs := &Service{
 			server: mockServer,
@@ -38,16 +37,15 @@ func TestOnReceiveChannelInvite(t *testing.T) {
 		remoteCluster := &model.RemoteCluster{}
 		msg := model.RemoteClusterMsg{}
 
-		err = scs.onReceiveChannelInvite(msg, remoteCluster, nil)
+		err := scs.onReceiveChannelInvite(msg, remoteCluster, nil)
 		require.NoError(t, err)
 		mockStore.AssertNotCalled(t, "Channel")
 	})
 
 	t.Run("when invitation prescribes a readonly channel, it does create a readonly channel", func(t *testing.T) {
 		mockServer := &MockServerIface{}
-		mockLogger, err := mlog.NewLogger()
-		require.NoError(t, err)
-		mockServer.On("Log").Return(mockLogger)
+		logger := mlog.CreateConsoleTestLogger(t)
+		mockServer.On("Log").Return(logger)
 		mockApp := &MockAppIface{}
 		scs := &Service{
 			server: mockServer,
@@ -106,9 +104,8 @@ func TestOnReceiveChannelInvite(t *testing.T) {
 
 	t.Run("when invitation prescribes a readonly channel and readonly update fails, it returns an error", func(t *testing.T) {
 		mockServer := &MockServerIface{}
-		mockLogger, err := mlog.NewLogger()
-		require.NoError(t, err)
-		mockServer.On("Log").Return(mockLogger)
+		logger := mlog.CreateConsoleTestLogger(t)
+		mockServer.On("Log").Return(logger)
 		mockApp := &MockAppIface{}
 		scs := &Service{
 			server: mockServer,
@@ -149,9 +146,8 @@ func TestOnReceiveChannelInvite(t *testing.T) {
 
 	t.Run("when invitation prescribes a direct channel, it does create a direct channel", func(t *testing.T) {
 		mockServer := &MockServerIface{}
-		mockLogger, err := mlog.NewLogger()
-		require.NoError(t, err)
-		mockServer.On("Log").Return(mockLogger)
+		logger := mlog.CreateConsoleTestLogger(t)
+		mockServer.On("Log").Return(logger)
 		mockApp := &MockAppIface{}
 		scs := &Service{
 			server: mockServer,

server/platform/services/sharedchannel/permalink_test.go

@@ -26,6 +26,7 @@ func TestProcessPermalinkToRemote(t *testing.T) {
 	mockStore := &mocks.Store{}
 	mockPostStore := mocks.PostStore{}
 	utils.TranslationsPreInit()
+	logger := mlog.CreateConsoleTestLogger(t)
 
 	pl := &model.PostList{}
 	mockPostStore.On("Get", context.Background(), "postID", model.GetPostsOptions{SkipFetchThreads: true}, "", map[string]bool{}).Return(pl, nil)
@@ -34,7 +35,7 @@ func TestProcessPermalinkToRemote(t *testing.T) {
 
 	mockServer := scs.server.(*MockServerIface)
 	mockServer.On("GetStore").Return(mockStore)
-	mockServer.On("Log").Return(mlog.NewLogger())
+	mockServer.On("Log").Return(logger)
 
 	mockApp := scs.app.(*MockAppIface)
 	mockApp.On("SendEphemeralPost", mock.Anything, "user", mock.AnythingOfType("*model.Post")).Return(&model.Post{}).Times(1)