MM-52532: Fix golangci warnings (#23709)

https://mattermost.atlassian.net/browse/MM-52532

- Replace golint with revive
- Add makezero linter
- Fix all the required linter failures

Some issues in enterprise and public modules
are yet to be fixed. We send this to expediate things.

server/boards/api/teams.go

@@ -322,7 +322,6 @@ func (a *API) handleGetTeamUsersByID(w http.ResponseWriter, r *http.Request) {
 	}
 
 	var users []*model.User
-	var error error
 
 	if len(userIDs) == 0 {
 		a.errorResponse(w, r, model.NewErrBadRequest("User IDs are empty"))
@@ -341,9 +340,9 @@ func (a *API) handleGetTeamUsersByID(w http.ResponseWriter, r *http.Request) {
 		}
 		users = append(users, user)
 	} else {
-		users, error = a.app.GetUsersList(userIDs)
-		if error != nil {
-			a.errorResponse(w, r, error)
+		users, err = a.app.GetUsersList(userIDs)
+		if err != nil {
+			a.errorResponse(w, r, err)
 			return
 		}
 

server/boards/api/users.go

@@ -67,7 +67,6 @@ func (a *API) handleGetUsersList(w http.ResponseWriter, r *http.Request) {
 	defer a.audit.LogRecord(audit.LevelAuth, auditRec)
 
 	var users []*model.User
-	var error error
 
 	if len(userIDs) == 0 {
 		a.errorResponse(w, r, model.NewErrBadRequest("User IDs are empty"))
@@ -86,9 +85,9 @@ func (a *API) handleGetUsersList(w http.ResponseWriter, r *http.Request) {
 		}
 		users = append(users, user)
 	} else {
-		users, error = a.app.GetUsersList(userIDs)
-		if error != nil {
-			a.errorResponse(w, r, error)
+		users, err = a.app.GetUsersList(userIDs)
+		if err != nil {
+			a.errorResponse(w, r, err)
 			return
 		}
 	}