From c137c091acb24a11009d4c39d67399370b5795e0 Mon Sep 17 00:00:00 2001 From: Tasnim Tantawi <101149675+tasnim0tantawi@users.noreply.github.com> Date: Fri, 16 Aug 2024 12:30:05 +0300 Subject: [PATCH] [MM-57720] Convert save_button.tsx to function component (#27912) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Convert save_button.tsx to function component * single quote * make saving optional * fix header * test suite command * fix lint * remove space * Update snapshots --------- Co-authored-by: Mattermost Build Co-authored-by: Daniel Espino GarcĂ­a --- .../setting_item_max.test.tsx.snap | 50 -------- .../bleve_settings.test.tsx.snap | 16 --- .../cluster_settings.test.tsx.snap | 32 ----- .../database_settings.test.tsx.snap | 8 -- .../elasticsearch_settings.test.tsx.snap | 16 --- .../message_export_settings.test.tsx.snap | 32 ----- .../__snapshots__/push_settings.test.tsx.snap | 16 --- .../schema_admin_settings.test.tsx.snap | 8 -- .../custom_plugin_settings.test.tsx.snap | 24 ---- ...om_terms_of_service_settings.test.tsx.snap | 32 ----- .../custom_policy_form.test.tsx.snap | 16 --- .../global_policy_form.test.tsx.snap | 8 -- ...ssion_system_scheme_settings.test.tsx.snap | 32 ----- ...mission_team_scheme_settings.test.tsx.snap | 56 -------- .../plugin_management.test.tsx.snap | 120 ------------------ .../system_user_detail.test.tsx.snap | 70 ---------- .../__snapshots__/login_mfa.test.tsx.snap | 1 - .../__snapshots__/multiselect.test.tsx.snap | 42 ------ .../src/components/save_button.test.tsx | 16 +-- .../channels/src/components/save_button.tsx | 116 ++++++++--------- .../signup/__snapshots__/signup.test.tsx.snap | 2 - .../update_user_group_modal.test.tsx.snap | 2 - .../email_notification_setting.test.tsx.snap | 28 ---- .../manage_auto_responder.test.tsx.snap | 28 ---- 24 files changed, 58 insertions(+), 713 deletions(-) diff --git a/webapp/channels/src/components/__snapshots__/setting_item_max.test.tsx.snap b/webapp/channels/src/components/__snapshots__/setting_item_max.test.tsx.snap index 86050df07e..b9d7fa68ee 100644 --- a/webapp/channels/src/components/__snapshots__/setting_item_max.test.tsx.snap +++ b/webapp/channels/src/components/__snapshots__/setting_item_max.test.tsx.snap @@ -27,23 +27,9 @@ exports[`components/SettingItemMax should match snapshot 1`] = ` >
- } disabled={false} - extraClasses="" onClick={[Function]} saving={false} - savingMessage={ - - } /> - ); +const SaveButton: React.FC = ({ + saving = false, + disabled = false, + savingMessage = ( + + ), + defaultMessage = ( + + ), + btnClass = '', + extraClasses = '', + ...props +}) => { + let className = 'btn'; + if (!btnClass) { + className += ' btn-primary'; } -} + + if (!disabled || saving) { + className += ' ' + btnClass; + } + + if (extraClasses) { + className += ' ' + extraClasses; + } + + return ( + + ); +}; + +export default SaveButton; diff --git a/webapp/channels/src/components/signup/__snapshots__/signup.test.tsx.snap b/webapp/channels/src/components/signup/__snapshots__/signup.test.tsx.snap index 2584917364..802a6dbcb0 100644 --- a/webapp/channels/src/components/signup/__snapshots__/signup.test.tsx.snap +++ b/webapp/channels/src/components/signup/__snapshots__/signup.test.tsx.snap @@ -193,7 +193,6 @@ exports[`components/signup/Signup should match snapshot for all signup options e
- } disabled={false} - extraClasses="" onClick={[Function]} saving={false} - savingMessage={ - - } >