From bcacc78f774e0763288c4a00f0278a11306b0df6 Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Mon, 11 Jan 2021 15:21:21 +0530 Subject: [PATCH] MM-31369: Fix racy test FileStoreWatcherEmitter encore (#16657) There was a mistake in my earlier analysis. t.Parallel only applies to the current test and not its subtests. There is some other test running with t.Parallel that is causing duplicate file watcher events to be fired. I have now verified that removing this causes the race to go away in CI --- config/file_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/config/file_test.go b/config/file_test.go index 4aa598ce1f..c52319c0dc 100644 --- a/config/file_test.go +++ b/config/file_test.go @@ -882,8 +882,6 @@ func TestFileStoreWatcherEmitter(t *testing.T) { t.Skip("skipping watcher test in short mode") } - t.Parallel() - t.Run("disabled", func(t *testing.T) { path, tearDown := setupConfigFile(t, emptyConfig) defer tearDown()