[MM12767] - Migrate tests from "store/storetest/license_store.… (#12769)

store/storetest/license_store.go

@@ -21,19 +21,16 @@ func testLicenseStoreSave(t *testing.T, ss store.Store) {
 	l1.Id = model.NewId()
 	l1.Bytes = "junk"
 
-	if _, err := ss.License().Save(&l1); err != nil {
+	_, err := ss.License().Save(&l1)
-		t.Fatal("couldn't save license record", err)
+	require.Nil(t, err, "couldn't save license record")
-	}
 
-	if _, err := ss.License().Save(&l1); err != nil {
+	_, err = ss.License().Save(&l1)
-		t.Fatal("shouldn't fail on trying to save existing license record", err)
+	require.Nil(t, err, "shouldn't fail on trying to save existing license record")
-	}
 
 	l1.Id = ""
 
-	if _, err := ss.License().Save(&l1); err == nil {
+	_, err = ss.License().Save(&l1)
-		t.Fatal("should fail on invalid license", err)
+	require.NotNil(t, err, "should fail on invalid license")
-	}
 }
 
 func testLicenseStoreGet(t *testing.T, ss store.Store) {
@@ -44,15 +41,11 @@ func testLicenseStoreGet(t *testing.T, ss store.Store) {
 	_, err := ss.License().Save(&l1)
 	require.Nil(t, err)
 
-	if record, err := ss.License().Get(l1.Id); err != nil {
+	record, err := ss.License().Get(l1.Id)
-		t.Fatal("couldn't get license", err)
+	require.Nil(t, err, "couldn't get license")
-	} else {
-		if record.Bytes != l1.Bytes {
-			t.Fatal("license bytes didn't match")
-		}
-	}
 
-	if _, err := ss.License().Get("missing"); err == nil {
+	require.Equal(t, record.Bytes, l1.Bytes, "license bytes didn't match")
-		t.Fatal("should fail on get license", err)
+
-	}
+	_, err = ss.License().Get("missing")
+	require.NotNil(t, err, "should fail on get license")
 }