MM-54181 : Clean up code around deprecated Gfycat (#24343)

* first pass of removal

* first pass of removal

* Update admin_console.js

* rev beta

* remove more

* Update initial_state.ts

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

server/config/client.go

@@ -79,8 +79,6 @@ func GenerateClientConfig(c *model.Config, telemetryID string, license *model.Li
 
 	props["EnableEmojiPicker"] = strconv.FormatBool(*c.ServiceSettings.EnableEmojiPicker)
 	props["EnableGifPicker"] = strconv.FormatBool(*c.ServiceSettings.EnableGifPicker)
-	props["GfycatApiKey"] = *c.ServiceSettings.GfycatAPIKey
-	props["GfycatApiSecret"] = *c.ServiceSettings.GfycatAPISecret
 	props["GiphySdkKey"] = getGiphySdkKey(c.ServiceSettings)
 	props["MaxFileSize"] = strconv.FormatInt(*c.FileSettings.MaxFileSize, 10)
 

server/config/diff.go

@@ -53,7 +53,6 @@ var configSensitivePaths = map[string]bool{
 	"MessageExportSettings.GlobalRelaySettings.SMTPUsername": true,
 	"MessageExportSettings.GlobalRelaySettings.SMTPPassword": true,
 	"MessageExportSettings.GlobalRelaySettings.EmailAddress": true,
-	"ServiceSettings.GfycatAPISecret":                        true,
 	"ServiceSettings.SplitKey":                               true,
 	"PluginSettings.Plugins":                                 true,
 }

server/config/diff_test.go

@@ -464,27 +464,6 @@ func TestDiffSanitized(t *testing.T) {
 			},
 			"",
 		},
-		{
-			"sensitive ServiceSettings.GfycatAPISecret",
-			func() *model.Config {
-				cfg := defaultConfigGen()
-				cfg.ServiceSettings.GfycatAPISecret = model.NewString("base")
-				return cfg
-			}(),
-			func() *model.Config {
-				cfg := defaultConfigGen()
-				cfg.ServiceSettings.GfycatAPISecret = model.NewString("actual")
-				return cfg
-			}(),
-			ConfigDiffs{
-				{
-					Path:      "ServiceSettings.GfycatAPISecret",
-					BaseVal:   model.FakeSetting,
-					ActualVal: model.FakeSetting,
-				},
-			},
-			"",
-		},
 		{
 			"sensitive ServiceSettings.SplitKey",
 			func() *model.Config {

server/config/utils.go

@@ -85,10 +85,6 @@ func desanitize(actual, target *model.Config) {
 		*target.MessageExportSettings.GlobalRelaySettings.SMTPPassword = *actual.MessageExportSettings.GlobalRelaySettings.SMTPPassword
 	}
 
-	if target.ServiceSettings.GfycatAPISecret != nil && *target.ServiceSettings.GfycatAPISecret == model.FakeSetting {
-		*target.ServiceSettings.GfycatAPISecret = *actual.ServiceSettings.GfycatAPISecret
-	}
-
 	if *target.ServiceSettings.SplitKey == model.FakeSetting {
 		*target.ServiceSettings.SplitKey = *actual.ServiceSettings.SplitKey
 	}