PLT-3242 Fixed clicking on input labels on iOS (#3417)
* Prevented channel notification settings radiobuttons from multi-selecting * Fixed clicking on input labels on iOS
Этот коммит содержится в:
коммит произвёл
Christopher Speller
родитель
459eee85a9
Коммит
b9cf09b5a4
@@ -132,6 +132,7 @@ export default class ChannelNotificationsModal extends React.Component {
|
|||||||
<label>
|
<label>
|
||||||
<input
|
<input
|
||||||
type='radio'
|
type='radio'
|
||||||
|
name='desktopNotificationLevel'
|
||||||
checked={notifyActive[0]}
|
checked={notifyActive[0]}
|
||||||
onChange={this.handleUpdateNotifyLevel.bind(this, 'default')}
|
onChange={this.handleUpdateNotifyLevel.bind(this, 'default')}
|
||||||
/>
|
/>
|
||||||
@@ -149,6 +150,7 @@ export default class ChannelNotificationsModal extends React.Component {
|
|||||||
<label>
|
<label>
|
||||||
<input
|
<input
|
||||||
type='radio'
|
type='radio'
|
||||||
|
name='desktopNotificationLevel'
|
||||||
checked={notifyActive[1]}
|
checked={notifyActive[1]}
|
||||||
onChange={this.handleUpdateNotifyLevel.bind(this, 'all')}
|
onChange={this.handleUpdateNotifyLevel.bind(this, 'all')}
|
||||||
/>
|
/>
|
||||||
@@ -160,6 +162,7 @@ export default class ChannelNotificationsModal extends React.Component {
|
|||||||
<label>
|
<label>
|
||||||
<input
|
<input
|
||||||
type='radio'
|
type='radio'
|
||||||
|
name='desktopNotificationLevel'
|
||||||
checked={notifyActive[2]}
|
checked={notifyActive[2]}
|
||||||
onChange={this.handleUpdateNotifyLevel.bind(this, 'mention')}
|
onChange={this.handleUpdateNotifyLevel.bind(this, 'mention')}
|
||||||
/>
|
/>
|
||||||
@@ -171,6 +174,7 @@ export default class ChannelNotificationsModal extends React.Component {
|
|||||||
<label>
|
<label>
|
||||||
<input
|
<input
|
||||||
type='radio'
|
type='radio'
|
||||||
|
name='desktopNotificationLevel'
|
||||||
checked={notifyActive[3]}
|
checked={notifyActive[3]}
|
||||||
onChange={this.handleUpdateNotifyLevel.bind(this, 'none')}
|
onChange={this.handleUpdateNotifyLevel.bind(this, 'none')}
|
||||||
/>
|
/>
|
||||||
@@ -285,6 +289,7 @@ export default class ChannelNotificationsModal extends React.Component {
|
|||||||
<label>
|
<label>
|
||||||
<input
|
<input
|
||||||
type='radio'
|
type='radio'
|
||||||
|
name='markUnreadLevel'
|
||||||
checked={this.state.unreadLevel === 'all'}
|
checked={this.state.unreadLevel === 'all'}
|
||||||
onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'all')}
|
onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'all')}
|
||||||
/>
|
/>
|
||||||
@@ -299,6 +304,7 @@ export default class ChannelNotificationsModal extends React.Component {
|
|||||||
<label>
|
<label>
|
||||||
<input
|
<input
|
||||||
type='radio'
|
type='radio'
|
||||||
|
name='markUnreadLevel'
|
||||||
checked={this.state.unreadLevel === 'mention'}
|
checked={this.state.unreadLevel === 'mention'}
|
||||||
onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'mention')}
|
onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'mention')}
|
||||||
/>
|
/>
|
||||||
|
|||||||
@@ -1051,3 +1051,9 @@
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// on iOS, allow clicks within an input's label to actually propagate through to the input itself
|
||||||
|
// http://stackoverflow.com/a/34810294/6325807
|
||||||
|
label span {
|
||||||
|
pointer-events: none;
|
||||||
|
}
|
||||||
Ссылка в новой задаче
Block a user