From b9bc1bbe10a1c0403cd708aff713ef32d8ffc55d Mon Sep 17 00:00:00 2001 From: Christopher Speller Date: Thu, 3 Sep 2015 08:49:58 -0400 Subject: [PATCH] Enabling checking of style guide on travis and turning on strict mode --- Makefile | 11 +++++------ web/react/package.json | 5 ++--- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefile index 915eb4cead..501e148cb0 100644 --- a/Makefile +++ b/Makefile @@ -5,7 +5,7 @@ GOFLAGS ?= $(GOFLAGS:) BUILD_NUMBER ?= $(BUILD_NUMBER:) GO=$(GOPATH)/bin/godep go -ESLINT=web/react/node_modules/eslint/bin/eslint.js +ESLINT=node_modules/eslint/bin/eslint.js ifeq ($(BUILD_NUMBER),) BUILD_NUMBER := dev @@ -37,6 +37,9 @@ travis: @cd web/react/ && npm install + @echo Checking for style guide compliance + cd web/react && $(ESLINT) components/* dispatcher/* pages/* stores/* utils/* + @$(GO) build $(GOFLAGS) ./... @$(GO) install $(GOFLAGS) -a ./... @@ -105,11 +108,7 @@ install: check: install @echo Running ESLint... - @$(ESLINT) web/react/components/* - @$(ESLINT) web/react/dispatcher/* - @$(ESLINT) web/react/pages/* - @$(ESLINT) web/react/stores/* - @$(ESLINT) web/react/utils/* + -cd web/react && $(ESLINT) components/* dispatcher/* pages/* stores/* utils/* test: install @mkdir -p logs diff --git a/web/react/package.json b/web/react/package.json index c930c4db60..5c33e21868 100644 --- a/web/react/package.json +++ b/web/react/package.json @@ -21,13 +21,12 @@ }, "scripts": { "start": "watchify --extension=jsx -o ../static/js/bundle.js -v -d ./**/*.jsx", - "build": "NODE_ENV=production browserify ./**/*.jsx | uglifyjs > ../static/js/bundle.min.js", - "build_old": "NODE_ENV=production browserify ./**/*.jsx | uglifyjs -cm > ../static/js/bundle.min.js", + "build": "NODE_ENV=production browserify ./**/*.jsx | uglifyjs > ../static/js/bundle.min.js", "test": "jest" }, "browserify": { "transform": [ - ["babelify", {"blacklist": ["strict"]}], + "babelify", "envify" ] },