Fix API Get channels for a user returns users' dm channels with blank teamid (#4748)
* fix API Get channels for a user returns users' dm channels with blank team ID add check in the context.go add suggestion made adjustment per review and support from @joram * update tests * add check if needd user or admin permissions * update per review
Этот коммит содержится в:
коммит произвёл
Corey Hulen
родитель
92b2810d84
Коммит
b9092ca2f5
@@ -745,10 +745,21 @@ func TestGetChannel(t *testing.T) {
|
||||
t.Fatal("should have failed - bad channel id")
|
||||
}
|
||||
|
||||
Client.SetTeamId(team2.Id)
|
||||
th.BasicClient.SetTeamId(team2.Id)
|
||||
if _, err := Client.GetChannel(channel2.Id, ""); err == nil {
|
||||
t.Fatal("should have failed - wrong team")
|
||||
}
|
||||
|
||||
//Test if a wrong team id is supplied should return error
|
||||
if _, err := Client.CreateDirectChannel(th.BasicUser2.Id); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
th.BasicClient.SetTeamId("nonexitingteamid")
|
||||
if _, err := Client.GetChannels(""); err == nil {
|
||||
t.Fatal("should have failed - wrong team id")
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
func TestGetMoreChannelsPage(t *testing.T) {
|
||||
|
||||
Ссылка в новой задаче
Block a user