diff --git a/utils/archive_test.go b/utils/archive_test.go index 77a0532d2d..a37366a86b 100644 --- a/utils/archive_test.go +++ b/utils/archive_test.go @@ -91,33 +91,33 @@ func TestUnzipToPath(t *testing.T) { require.NotEmpty(t, testDir) dir, err := ioutil.TempDir("", "unzip") - require.Nil(t, err) + require.NoError(t, err) defer os.RemoveAll(dir) t.Run("invalid archive", func(t *testing.T) { file, err := os.Open(testDir + "/testplugin.tar.gz") - require.Nil(t, err) + require.NoError(t, err) defer file.Close() info, err := file.Stat() - require.Nil(t, err) + require.NoError(t, err) paths, err := UnzipToPath(file, info.Size(), dir) - require.NotNil(t, err) + require.Error(t, err) require.True(t, errors.Is(err, zip.ErrFormat)) require.Nil(t, paths) }) t.Run("valid archive", func(t *testing.T) { file, err := os.Open(testDir + "/testarchive.zip") - require.Nil(t, err) + require.NoError(t, err) defer file.Close() info, err := file.Stat() - require.Nil(t, err) + require.NoError(t, err) paths, err := UnzipToPath(file, info.Size(), dir) - require.Nil(t, err) + require.NoError(t, err) require.NotEmpty(t, paths) expectedFiles := map[string]int64{ @@ -132,7 +132,7 @@ func TestUnzipToPath(t *testing.T) { } err = filepath.Walk(dir, func(path string, info os.FileInfo, err error) error { - require.Nil(t, err) + require.NoError(t, err) if path == dir { return nil } @@ -144,6 +144,6 @@ func TestUnzipToPath(t *testing.T) { } return nil }) - require.Nil(t, err) + require.NoError(t, err) }) } diff --git a/utils/backoff_test.go b/utils/backoff_test.go index f3ee5d7de4..01c047d456 100644 --- a/utils/backoff_test.go +++ b/utils/backoff_test.go @@ -56,7 +56,7 @@ func TestProgressiveRetry(t *testing.T) { err := ProgressiveRetry(tt.args.operation) if !tt.wantErr { - require.Nil(t, err) + require.NoError(t, err) } assert.Equal(t, tt.expectedRetries, retries) diff --git a/utils/imgutils/gif_test.go b/utils/imgutils/gif_test.go index ef87a2b8e2..24590130ec 100644 --- a/utils/imgutils/gif_test.go +++ b/utils/imgutils/gif_test.go @@ -36,7 +36,7 @@ func TestCountFrames(t *testing.T) { count, err := CountFrames(bytes.NewReader(b)) - assert.Nil(t, err) + assert.NoError(t, err) assert.Equal(t, 1, count) }) @@ -50,32 +50,32 @@ func TestCountFrames(t *testing.T) { count, err := CountFrames(bytes.NewReader(b)) - assert.Nil(t, err) + assert.NoError(t, err) assert.Equal(t, 100, count) }) t.Run("should count the frames of an actual animated gif", func(t *testing.T) { b, err := testutils.ReadTestFile("testgif.gif") - require.Nil(t, err) + require.NoError(t, err) count, err := CountFrames(bytes.NewReader(b)) - assert.Nil(t, err) + assert.NoError(t, err) assert.Equal(t, 4, count) }) t.Run("should return an error for a non-gif image", func(t *testing.T) { b, err := testutils.ReadTestFile("test.png") - require.Nil(t, err) + require.NoError(t, err) _, err = CountFrames(bytes.NewReader(b)) - assert.NotNil(t, err) + assert.Error(t, err) }) t.Run("should return an error for garbage data", func(t *testing.T) { _, err := CountFrames(bytes.NewReader([]byte("garbage data"))) - assert.NotNil(t, err) + assert.Error(t, err) }) }