Updating ESLint (#3597)

webapp/components/admin_console/admin_settings.jsx

@@ -106,11 +106,6 @@ export default class AdminSettings extends React.Component {
     }
 
     render() {
-        let saveClass = 'btn';
-        if (this.state.saveNeeded) {
-            saveClass += 'btn-primary';
-        }
-
         return (
             <div className='wrapper--fixed'>
                 {this.renderTitle()}

webapp/components/create_comment.jsx

@@ -181,7 +181,7 @@ class CreateComment extends React.Component {
     }
 
     commentMsgKeyPress(e) {
-        if (this.state.ctrlSend && e.ctrlKey || !this.state.ctrlSend) {
+        if ((this.state.ctrlSend && e.ctrlKey) || !this.state.ctrlSend) {
             if (e.which === KeyCodes.ENTER && !e.shiftKey && !e.altKey) {
                 e.preventDefault();
                 ReactDOM.findDOMNode(this.refs.textbox).blur();
@@ -313,7 +313,7 @@ class CreateComment extends React.Component {
         draft.uploadsInProgress = uploadsInProgress;
         PostStore.storeCommentDraft(this.props.rootId, draft);
 
-        this.setState({previews: previews, uploadsInProgress: uploadsInProgress});
+        this.setState({previews, uploadsInProgress});
     }
 
     componentWillReceiveProps(newProps) {

webapp/components/create_post.jsx

@@ -212,7 +212,7 @@ class CreatePost extends React.Component {
     }
 
     postMsgKeyPress(e) {
-        if (this.state.ctrlSend && e.ctrlKey || !this.state.ctrlSend) {
+        if ((this.state.ctrlSend && e.ctrlKey) || !this.state.ctrlSend) {
             if (e.which === KeyCodes.ENTER && !e.shiftKey && !e.altKey) {
                 e.preventDefault();
                 ReactDOM.findDOMNode(this.refs.textbox).blur();

webapp/components/file_upload.jsx

@@ -282,7 +282,8 @@ class FileUpload extends React.Component {
     keyUpload(e) {
         if (Utils.cmdOrCtrlPressed(e) && e.keyCode === Constants.KeyCodes.U) {
             e.preventDefault();
-            if (this.props.postType === 'post' && document.activeElement.id === 'post_textbox' || this.props.postType === 'comment' && document.activeElement.id === 'reply_textbox') {
+            if ((this.props.postType === 'post' && document.activeElement.id === 'post_textbox') ||
+                (this.props.postType === 'comment' && document.activeElement.id === 'reply_textbox')) {
                 $(this.refs.fileInput).focus().trigger('click');
             }
         }

webapp/components/invite_member_modal.jsx

@@ -131,7 +131,7 @@ class InviteMemberModal extends React.Component {
             invites.push(invite);
         }
 
-        this.setState({emailErrors: emailErrors, firstNameErrors: firstNameErrors, lastNameErrors: lastNameErrors});
+        this.setState({emailErrors, firstNameErrors, lastNameErrors});
 
         if (!valid || invites.length === 0) {
             return;
@@ -151,7 +151,7 @@ class InviteMemberModal extends React.Component {
             (err) => {
                 if (err.id === 'api.team.invite_members.already.app_error') {
                     emailErrors[err.detailed_error] = err.message;
-                    this.setState({emailErrors: emailErrors});
+                    this.setState({emailErrors});
                 } else {
                     this.setState({serverError: err.message});
                 }
@@ -193,7 +193,7 @@ class InviteMemberModal extends React.Component {
         var count = this.state.idCount + 1;
         var inviteIds = this.state.inviteIds;
         inviteIds.push(count);
-        this.setState({inviteIds: inviteIds, idCount: count});
+        this.setState({inviteIds, idCount: count});
     }
 
     clearFields() {
@@ -225,7 +225,7 @@ class InviteMemberModal extends React.Component {
         if (!inviteIds.length) {
             inviteIds.push(++count);
         }
-        this.setState({inviteIds: inviteIds, idCount: count});
+        this.setState({inviteIds, idCount: count});
     }
 
     showGetTeamInviteLinkModal() {
@@ -435,7 +435,7 @@ class InviteMemberModal extends React.Component {
                                 id='invite_member.teamInviteLink'
                                 defaultMessage='You can also invite people using the {link}.'
                                 values={{
-                                    link: (link)
+                                    link
                                 }}
                             />
                         </p>

webapp/components/msg_typing.jsx

@@ -71,7 +71,7 @@ class MsgTyping extends React.Component {
                     defaultMessage='{users} and {last} are typing...'
                     values={{
                         users: (users.join(', ')),
-                        last: (last)
+                        last
                     }}
                 />
             );

webapp/components/navbar.jsx

@@ -636,7 +636,7 @@ export default class Navbar extends React.Component {
                                 defaultMessage='No channel header yet.{newline}{link} to add one.'
                                 values={{
                                     newline: (<br/>),
-                                    link: (link)
+                                    link
                                 }}
                             />
                         </div>

webapp/components/removed_from_channel_modal.jsx

@@ -116,7 +116,7 @@ export default class RemovedFromChannelModal extends React.Component {
                                         id='removed_channel.remover'
                                         defaultMessage='{remover} removed you from {channel}'
                                         values={{
-                                            remover: (remover),
+                                            remover,
                                             channel: (channelName)
                                         }}
                                     />

webapp/components/rename_channel_modal.jsx

@@ -203,7 +203,7 @@ export default class RenameChannelModal extends React.Component {
             const displayName = ReactDOM.findDOMNode(this.refs.displayName).value.trim();
             const channelName = Utils.cleanUpUrlable(displayName);
             ReactDOM.findDOMNode(this.refs.channelName).value = channelName;
-            this.setState({channelName: channelName});
+            this.setState({channelName});
         }
     }
 

webapp/components/suggestion/suggestion_list.jsx

@@ -87,7 +87,7 @@ export default class SuggestionList extends React.Component {
                 content.scrollTop(itemTop - contentTopPadding);
             } else if (itemBottom + contentTopPadding + contentBottomPadding > contentTop + visibleContentHeight) {
                 // the item has gone off the bottom of the visible space
-                content.scrollTop(itemBottom - visibleContentHeight + contentTopPadding + contentBottomPadding);
+                content.scrollTop((itemBottom - visibleContentHeight) + contentTopPadding + contentBottomPadding);
             }
         }
     }

webapp/components/user_settings/user_settings_general.jsx

@@ -295,8 +295,17 @@ class UserSettingsGeneralTab extends React.Component {
     setupInitialState(props) {
         const user = props.user;
 
-        return {username: user.username, firstName: user.first_name, lastName: user.last_name, nickname: user.nickname,
-                        email: user.email, confirmEmail: '', picture: null, loadingPicture: false, emailChangeInProgress: false};
+        return {
+            username: user.username,
+            firstName: user.first_name,
+            lastName: user.last_name,
+            nickname: user.nickname,
+            email: user.email,
+            confirmEmail: '',
+            picture: null,
+            loadingPicture: false,
+            emailChangeInProgress: false
+        };
     }
 
     createEmailSection() {