Add progressive backoff function (#11497)
* [MM-15267] Utils: add backoff function to allow retries (#10958) * [MM-15267] Utils: add unit test and update retry logic (#10958) * [MM-15267] Utils: Add three retries to ProgressiveRetry (#10958) * [MM-15267] Utils: add comments for progressive retry (#10958) * [MM-15267] Utils: add license header to newly added file (#10958) * [MM-15267] Utils: fix typo (#10958) * [MM-15267] Utils: inline callback in function call (#10958) * [MM-15267] Utils: remove type definition for backoff callback function (#10958) * [MM-15267] Utils: use lookup table for timeout duration (#10958) * [MM-15267] Utils: table driven unit tests for Progressive Backoff (#10958) * [MM-15267] Utils: simplify retry function (#10958) * [MM-15267] Utils: add assert and require packages to test file (#10958) * [MM-15267] Utils: revert changes in go.mod and go.sum (#10958)
Этот коммит содержится в:
коммит произвёл
Jesse Hallam
родитель
903085feb8
Коммит
b464f31b38
26
utils/backoff.go
Обычный файл
26
utils/backoff.go
Обычный файл
@@ -0,0 +1,26 @@
|
||||
// Copyright (c) 2016-present Mattermost, Inc. All Rights Reserved.
|
||||
// See License.txt for license information.
|
||||
|
||||
package utils
|
||||
|
||||
import (
|
||||
"time"
|
||||
)
|
||||
|
||||
var backoffTimeouts = []time.Duration{50 * time.Millisecond, 100 * time.Millisecond, 200 * time.Millisecond, 200 * time.Millisecond, 400 * time.Millisecond, 400 * time.Millisecond}
|
||||
|
||||
// ProgressiveRetry executes a BackoffOperation and waits an increasing time before retrying the operation.
|
||||
func ProgressiveRetry(operation func() error) error {
|
||||
var err error
|
||||
|
||||
for attempts := 0; attempts < len(backoffTimeouts); attempts++ {
|
||||
err = operation()
|
||||
if err == nil {
|
||||
return nil
|
||||
}
|
||||
|
||||
time.Sleep(backoffTimeouts[attempts])
|
||||
}
|
||||
|
||||
return err
|
||||
}
|
||||
62
utils/backoff_test.go
Обычный файл
62
utils/backoff_test.go
Обычный файл
@@ -0,0 +1,62 @@
|
||||
package utils
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/pkg/errors"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestProgressiveRetry(t *testing.T) {
|
||||
var retries int
|
||||
|
||||
type args struct {
|
||||
operation func() error
|
||||
}
|
||||
tests := []struct {
|
||||
name string
|
||||
args args
|
||||
wantErr bool
|
||||
expectedRetries int
|
||||
}{
|
||||
{
|
||||
name: "Should fail and return error",
|
||||
args: args{
|
||||
operation: func() error {
|
||||
retries++
|
||||
return errors.New("Operation Failed")
|
||||
},
|
||||
},
|
||||
wantErr: true,
|
||||
expectedRetries: 6,
|
||||
},
|
||||
{
|
||||
name: "Should succeed after two retries",
|
||||
args: args{
|
||||
operation: func() error {
|
||||
retries++
|
||||
if retries == 2 {
|
||||
return nil
|
||||
}
|
||||
|
||||
return errors.New("Operation Failed")
|
||||
},
|
||||
},
|
||||
wantErr: false,
|
||||
expectedRetries: 2,
|
||||
},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
retries = 0
|
||||
|
||||
err := ProgressiveRetry(tt.args.operation)
|
||||
if !tt.wantErr {
|
||||
require.Nil(t, err)
|
||||
}
|
||||
|
||||
assert.Equal(t, tt.expectedRetries, retries)
|
||||
})
|
||||
}
|
||||
}
|
||||
Ссылка в новой задаче
Block a user