Use require/assert.Empty instead of require/assert.Len(t, X, 0) (#13413)

store/storetest/audit_store.go

@@ -40,7 +40,7 @@ func testAuditStore(t *testing.T, ss store.Store) {
 
 	audits, err = ss.Audit().Get("missing", 0, 100)
 	require.Nil(t, err)
-	assert.Len(t, audits, 0)
+	assert.Empty(t, audits)
 
 	audits, err = ss.Audit().Get("", 0, 100)
 	require.Nil(t, err)

store/storetest/channel_member_history_store.go

@@ -117,7 +117,7 @@ func testGetUsersInChannelAtChannelMemberHistory(t *testing.T, ss store.Store) {
 	// case 1: user joins and leaves the channel before the export period begins
 	channelMembers, err := ss.ChannelMemberHistory().GetUsersInChannelDuring(joinTime-500, joinTime-100, channel.Id)
 	require.Nil(t, err)
-	assert.Len(t, channelMembers, 0)
+	assert.Empty(t, channelMembers)
 
 	// case 2: user joins the channel after the export period begins, but has not yet left the channel when the export period ends
 	channelMembers, err = ss.ChannelMemberHistory().GetUsersInChannelDuring(joinTime-100, joinTime+500, channel.Id)
@@ -170,7 +170,7 @@ func testGetUsersInChannelAtChannelMemberHistory(t *testing.T, ss store.Store) {
 	// case 6: user has joined and left the channel long before the export period begins
 	channelMembers, err = ss.ChannelMemberHistory().GetUsersInChannelDuring(leaveTime+100, leaveTime+200, channel.Id)
 	require.Nil(t, err)
-	assert.Len(t, channelMembers, 0)
+	assert.Empty(t, channelMembers)
 }
 
 func testGetUsersInChannelAtChannelMembers(t *testing.T, ss store.Store) {

store/storetest/channel_store.go

@@ -679,7 +679,7 @@ func testChannelStoreGetByNames(t *testing.T, ss store.Store) {
 
 	channels, err := ss.Channel().GetByNames(o1.TeamId, []string{o1.Name}, false)
 	require.Nil(t, err)
-	assert.Len(t, channels, 0)
+	assert.Empty(t, channels)
 }
 
 func testChannelStoreGetDeletedByName(t *testing.T, ss store.Store) {
@@ -3335,7 +3335,7 @@ func testChannelStoreGetPinnedPosts(t *testing.T, ss store.Store) {
 
 	pl, errGet = ss.Channel().GetPinnedPosts(o2.Id)
 	require.Nil(t, errGet, errGet)
-	require.Len(t, pl.Posts, 0, "wasn't supposed to return posts")
+	require.Empty(t, pl.Posts, "wasn't supposed to return posts")
 }
 
 func testChannelStoreGetPinnedPostCount(t *testing.T, ss store.Store) {
@@ -3471,12 +3471,12 @@ func testChannelStoreGetChannelsByScheme(t *testing.T, ss store.Store) {
 	// Get the channels by a valid Scheme ID where there aren't any matching Channel.
 	d2, err := ss.Channel().GetChannelsByScheme(s2.Id, 0, 100)
 	assert.Nil(t, err)
-	assert.Len(t, d2, 0)
+	assert.Empty(t, d2)
 
 	// Get the channels by an invalid Scheme ID.
 	d3, err := ss.Channel().GetChannelsByScheme(model.NewId(), 0, 100)
 	assert.Nil(t, err)
-	assert.Len(t, d3, 0)
+	assert.Empty(t, d3)
 }
 
 func testChannelStoreMigrateChannelMembers(t *testing.T, ss store.Store) {

store/storetest/cluster_discovery_store.go

@@ -152,5 +152,5 @@ func testClusterDiscoveryGetStore(t *testing.T, ss store.Store) {
 
 	list, err = ss.ClusterDiscovery().GetAll(model.NewId(), "cluster_name")
 	require.Nil(t, err)
-	assert.Len(t, list, 0)
+	assert.Empty(t, list)
 }

store/storetest/emoji_store.go

@@ -168,7 +168,7 @@ func testEmojiGetMultipleByName(t *testing.T, ss store.Store) {
 	t.Run("one nonexistent emoji", func(t *testing.T) {
 		received, err := ss.Emoji().GetMultipleByName([]string{"ab"})
 		require.Nilf(t, err, "%v, could not get emoji", err)
-		require.Len(t, received, 0, "got incorrect emoji")
+		require.Empty(t, received, "got incorrect emoji")
 	})
 
 	t.Run("multiple emojis with nonexistent names", func(t *testing.T) {

store/storetest/file_info_store.go

@@ -395,7 +395,7 @@ func testFileInfoDeleteForPost(t *testing.T, ss store.Store) {
 
 	infos, err = ss.FileInfo().GetForPost(postId, true, false, false)
 	require.Nil(t, err)
-	assert.Len(t, infos, 0)
+	assert.Empty(t, infos)
 }
 
 func testFileInfoPermanentDelete(t *testing.T, ss store.Store) {

store/storetest/group_store.go

@@ -1107,7 +1107,7 @@ func testPendingAutoAddTeamMembers(t *testing.T, ss store.Store) {
 	// Time after syncable was created
 	teamMembers, err = ss.Group().TeamMembersToAdd(syncable.CreateAt + 1)
 	require.Nil(t, err)
-	require.Len(t, teamMembers, 0)
+	require.Empty(t, teamMembers)
 
 	// Delete and restore GroupMember should return result
 	_, err = ss.Group().DeleteMember(group.Id, user.Id)
@@ -1133,7 +1133,7 @@ func testPendingAutoAddTeamMembers(t *testing.T, ss store.Store) {
 	// Time after syncable was updated
 	teamMembers, err = ss.Group().TeamMembersToAdd(syncable.UpdateAt + 1)
 	require.Nil(t, err)
-	require.Len(t, teamMembers, 0)
+	require.Empty(t, teamMembers)
 
 	// Only includes if auto-add
 	syncable.AutoAdd = false
@@ -1141,7 +1141,7 @@ func testPendingAutoAddTeamMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	teamMembers, err = ss.Group().TeamMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, teamMembers, 0)
+	require.Empty(t, teamMembers)
 
 	// reset state of syncable and verify
 	_, err = ss.Group().UpdateGroupSyncable(&pristineSyncable)
@@ -1155,7 +1155,7 @@ func testPendingAutoAddTeamMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	teamMembers, err = ss.Group().TeamMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, teamMembers, 0)
+	require.Empty(t, teamMembers)
 
 	// reset state of group and verify
 	group.DeleteAt = 0
@@ -1171,7 +1171,7 @@ func testPendingAutoAddTeamMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	teamMembers, err = ss.Group().TeamMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, teamMembers, 0)
+	require.Empty(t, teamMembers)
 
 	// reset state of team and verify
 	team.DeleteAt = 0
@@ -1186,7 +1186,7 @@ func testPendingAutoAddTeamMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	teamMembers, err = ss.Group().TeamMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, teamMembers, 0)
+	require.Empty(t, teamMembers)
 
 	// reset GroupTeam and verify
 	_, err = ss.Group().UpdateGroupSyncable(&pristineSyncable)
@@ -1200,7 +1200,7 @@ func testPendingAutoAddTeamMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	teamMembers, err = ss.Group().TeamMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, teamMembers, 0)
+	require.Empty(t, teamMembers)
 
 	// restore group member and verify
 	_, err = ss.Group().UpsertMember(group.Id, user.Id)
@@ -1217,7 +1217,7 @@ func testPendingAutoAddTeamMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	teamMembers, err = ss.Group().TeamMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, teamMembers, 0)
+	require.Empty(t, teamMembers)
 }
 
 func testPendingAutoAddChannelMembers(t *testing.T, ss store.Store) {
@@ -1266,7 +1266,7 @@ func testPendingAutoAddChannelMembers(t *testing.T, ss store.Store) {
 	// Time after syncable was created
 	channelMembers, err = ss.Group().ChannelMembersToAdd(syncable.CreateAt + 1)
 	require.Nil(t, err)
-	require.Len(t, channelMembers, 0)
+	require.Empty(t, channelMembers)
 
 	// Delete and restore GroupMember should return result
 	_, err = ss.Group().DeleteMember(group.Id, user.Id)
@@ -1292,7 +1292,7 @@ func testPendingAutoAddChannelMembers(t *testing.T, ss store.Store) {
 	// Time after syncable was updated
 	channelMembers, err = ss.Group().ChannelMembersToAdd(syncable.UpdateAt + 1)
 	require.Nil(t, err)
-	require.Len(t, channelMembers, 0)
+	require.Empty(t, channelMembers)
 
 	// Only includes if auto-add
 	syncable.AutoAdd = false
@@ -1300,7 +1300,7 @@ func testPendingAutoAddChannelMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	channelMembers, err = ss.Group().ChannelMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, channelMembers, 0)
+	require.Empty(t, channelMembers)
 
 	// reset state of syncable and verify
 	_, err = ss.Group().UpdateGroupSyncable(&pristineSyncable)
@@ -1314,7 +1314,7 @@ func testPendingAutoAddChannelMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	channelMembers, err = ss.Group().ChannelMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, channelMembers, 0)
+	require.Empty(t, channelMembers)
 
 	// reset state of group and verify
 	group.DeleteAt = 0
@@ -1329,7 +1329,7 @@ func testPendingAutoAddChannelMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	channelMembers, err = ss.Group().ChannelMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, channelMembers, 0)
+	require.Empty(t, channelMembers)
 
 	// reset state of channel and verify
 	channel.DeleteAt = 0
@@ -1344,7 +1344,7 @@ func testPendingAutoAddChannelMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	channelMembers, err = ss.Group().ChannelMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, channelMembers, 0)
+	require.Empty(t, channelMembers)
 
 	// reset GroupChannel and verify
 	_, err = ss.Group().UpdateGroupSyncable(&pristineSyncable)
@@ -1358,7 +1358,7 @@ func testPendingAutoAddChannelMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	channelMembers, err = ss.Group().ChannelMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, channelMembers, 0)
+	require.Empty(t, channelMembers)
 
 	// restore group member and verify
 	_, err = ss.Group().UpsertMember(group.Id, user.Id)
@@ -1372,14 +1372,14 @@ func testPendingAutoAddChannelMembers(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	channelMembers, err = ss.Group().ChannelMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, channelMembers, 0)
+	require.Empty(t, channelMembers)
 
 	// Leaving Channel (ChannelMemberHistory) should still not return result
 	err = ss.ChannelMemberHistory().LogLeaveEvent(user.Id, channel.Id, model.GetMillis())
 	require.Nil(t, err)
 	channelMembers, err = ss.Group().ChannelMembersToAdd(0)
 	require.Nil(t, err)
-	require.Len(t, channelMembers, 0)
+	require.Empty(t, channelMembers)
 
 	// Purging ChannelMemberHistory re-returns the result
 	_, err = ss.ChannelMemberHistory().PermanentDeleteBatch(model.GetMillis()+1, 100)

store/storetest/oauth_store.go

@@ -71,7 +71,7 @@ func testOAuthStoreGetApp(t *testing.T, ss store.Store) {
 	// Lets try and get the app from a user that hasn't created any apps
 	apps, err := ss.OAuth().GetAppByUser("fake0123456789abcderfgret1", 0, 1000)
 	require.Nil(t, err)
-	assert.Len(t, apps, 0, "Should have failed. Fake user hasn't created any apps")
+	assert.Empty(t, apps, "Should have failed. Fake user hasn't created any apps")
 
 	_, err = ss.OAuth().GetAppByUser(a1.CreatorId, 0, 1000)
 	require.Nil(t, err)
@@ -294,7 +294,7 @@ func testOAuthGetAuthorizedApps(t *testing.T, ss store.Store) {
 	// Lets try and get an Authorized app for a user who hasn't authorized it
 	apps, err := ss.OAuth().GetAuthorizedApps("fake0123456789abcderfgret1", 0, 1000)
 	require.Nil(t, err)
-	assert.Len(t, apps, 0, "Should have failed. Fake user hasn't authorized the app")
+	assert.Empty(t, apps, "Should have failed. Fake user hasn't authorized the app")
 
 	// allow the app
 	p := model.Preference{}

store/storetest/post_store.go

@@ -1118,7 +1118,7 @@ func testPostStoreGetPostsSince(t *testing.T, ss store.Store) {
 		assert.Nil(t, err)
 
 		assert.Equal(t, []string{}, postList.Order)
-		assert.Len(t, postList.Posts, 0)
+		assert.Empty(t, postList.Posts)
 	})
 
 	t.Run("should not cache a timestamp of 0 when nothing has changed", func(t *testing.T) {

store/storetest/preference_store.go

@@ -251,7 +251,7 @@ func testPreferenceDelete(t *testing.T, ss store.Store) {
 	require.Nil(t, err)
 	preferences, err = ss.Preference().GetAll(preference.UserId)
 	require.Nil(t, err)
-	assert.Len(t, preferences, 0, "should've returned no preferences")
+	assert.Empty(t, preferences, "should've returned no preferences")
 }
 
 func testPreferenceDeleteCategory(t *testing.T, ss store.Store) {
@@ -284,7 +284,7 @@ func testPreferenceDeleteCategory(t *testing.T, ss store.Store) {
 
 	preferences, err = ss.Preference().GetAll(userId)
 	require.Nil(t, err)
-	assert.Len(t, preferences, 0, "should've returned no preferences")
+	assert.Empty(t, preferences, "should've returned no preferences")
 }
 
 func testPreferenceDeleteCategoryAndName(t *testing.T, ss store.Store) {
@@ -323,11 +323,11 @@ func testPreferenceDeleteCategoryAndName(t *testing.T, ss store.Store) {
 
 	preferences, err = ss.Preference().GetAll(userId)
 	require.Nil(t, err)
-	assert.Len(t, preferences, 0, "should've returned no preference")
+	assert.Empty(t, preferences, "should've returned no preference")
 
 	preferences, err = ss.Preference().GetAll(userId2)
 	require.Nil(t, err)
-	assert.Len(t, preferences, 0, "should've returned no preference")
+	assert.Empty(t, preferences, "should've returned no preference")
 }
 
 func testPreferenceCleanupFlagsBatch(t *testing.T, ss store.Store) {

store/storetest/reaction_store.go

@@ -125,7 +125,7 @@ func testReactionDelete(t *testing.T, ss store.Store) {
 	reactions, rErr := ss.Reaction().GetForPost(post.Id, false)
 	require.Nil(t, rErr)
 
-	assert.Len(t, reactions, 0, "should've deleted reaction")
+	assert.Empty(t, reactions, "should've deleted reaction")
 
 	postList, err := ss.Post().Get(post.Id, false)
 	require.Nil(t, err)
@@ -285,7 +285,7 @@ func testReactionDeleteAllWithEmojiName(t *testing.T, ss store.Store) {
 
 	returned, err = ss.Reaction().GetForPost(post3.Id, false)
 	require.Nil(t, err)
-	assert.Len(t, returned, 0, "should've only removed reactions with emoji name")
+	assert.Empty(t, returned, "should've only removed reactions with emoji name")
 
 	// check that the posts are updated
 	postList, err := ss.Post().Get(post.Id, false)

store/storetest/role_store.go

@@ -263,7 +263,7 @@ func testRoleStoreGetByNames(t *testing.T, ss store.Store) {
 	n5 := []string{model.NewId(), model.NewId()}
 	roles5, err := ss.Role().GetByNames(n5)
 	assert.Nil(t, err)
-	assert.Len(t, roles5, 0)
+	assert.Empty(t, roles5)
 
 	// Get one valid one and one invalid one.
 	n6 := []string{r1.Name, model.NewId()}
@@ -354,5 +354,5 @@ func testRoleStorePermanentDeleteAll(t *testing.T, ss store.Store) {
 
 	roles, err = ss.Role().GetByNames([]string{r1.Name, r2.Name})
 	assert.Nil(t, err)
-	assert.Len(t, roles, 0)
+	assert.Empty(t, roles)
 }

store/storetest/scheme_store.go

@@ -484,5 +484,5 @@ func testSchemeStorePermanentDeleteAll(t *testing.T, ss store.Store) {
 
 	schemes, err := ss.Scheme().GetAllPage("", 0, 100000)
 	assert.Nil(t, err)
-	assert.Len(t, schemes, 0)
+	assert.Empty(t, schemes)
 }

store/storetest/session_store.go

@@ -169,7 +169,7 @@ func testSessionRemoveToken(t *testing.T, ss store.Store) {
 
 	data, err := ss.Session().GetSessions(s1.UserId)
 	require.Nil(t, err)
-	require.Len(t, data, 0, "should match len")
+	require.Empty(t, data, "should match len")
 }
 
 func testSessionUpdateDeviceId(t *testing.T, ss store.Store) {

store/storetest/team_store.go

@@ -848,7 +848,7 @@ func testTeamMembers(t *testing.T, ss store.Store) {
 
 	ms, err = ss.Team().GetMembers(teamId1, 0, 100, nil)
 	require.Nil(t, err)
-	require.Len(t, ms, 0)
+	require.Empty(t, ms)
 
 	uid := model.NewId()
 	m4 := &model.TeamMember{TeamId: teamId1, UserId: uid}
@@ -867,7 +867,7 @@ func testTeamMembers(t *testing.T, ss store.Store) {
 
 	ms, err = ss.Team().GetTeamsForUser(m1.UserId)
 	require.Nil(t, err)
-	require.Len(t, ms, 0)
+	require.Empty(t, ms)
 }
 
 func testTeamMembersWithPagination(t *testing.T, ss store.Store) {
@@ -924,7 +924,7 @@ func testTeamMembersWithPagination(t *testing.T, ss store.Store) {
 
 	result, err = ss.Team().GetTeamsForUserWithPagination(uid, 1, 1)
 	require.Nil(t, err)
-	require.Len(t, result, 0)
+	require.Empty(t, result)
 }
 
 func testSaveTeamMemberMaxMembers(t *testing.T, ss store.Store) {
@@ -1340,12 +1340,12 @@ func testGetTeamsByScheme(t *testing.T, ss store.Store) {
 	// Get the teams by a valid Scheme ID where there aren't any matching Teams.
 	d, err = ss.Team().GetTeamsByScheme(s2.Id, 0, 100)
 	assert.Nil(t, err)
-	assert.Len(t, d, 0)
+	assert.Empty(t, d)
 
 	// Get the teams by an invalid Scheme ID.
 	d, err = ss.Team().GetTeamsByScheme(model.NewId(), 0, 100)
 	assert.Nil(t, err)
-	assert.Len(t, d, 0)
+	assert.Empty(t, d)
 }
 
 func testTeamStoreMigrateTeamMembers(t *testing.T, ss store.Store) {

store/storetest/webhook_store.go

@@ -159,7 +159,7 @@ func testWebhookStoreGetIncomingByTeam(t *testing.T, ss store.Store) {
 
 	hooks, err = ss.Webhook().GetIncomingByTeam("123", 0, 100)
 	require.Nil(t, err)
-	require.Len(t, hooks, 0, "no webhooks should have returned")
+	require.Empty(t, hooks, "no webhooks should have returned")
 }
 
 func TestWebhookStoreGetIncomingByTeamByUser(t *testing.T, ss store.Store) {
@@ -206,7 +206,7 @@ func TestWebhookStoreGetIncomingByChannel(t *testing.T, ss store.Store) {
 
 	webhooks, err = ss.Webhook().GetIncomingByChannel("123")
 	require.Nil(t, err)
-	require.Len(t, webhooks, 0, "no webhooks should have returned")
+	require.Empty(t, webhooks, "no webhooks should have returned")
 }
 
 func testWebhookStoreDeleteIncoming(t *testing.T, ss store.Store) {
@@ -387,7 +387,7 @@ func testWebhookStoreGetOutgoingByChannel(t *testing.T, ss store.Store) {
 
 	result, err := ss.Webhook().GetOutgoingByChannel("123", -1, -1)
 	require.Nil(t, err)
-	require.Len(t, result, 0, "no webhooks should have returned")
+	require.Empty(t, result, "no webhooks should have returned")
 }
 
 func testWebhookStoreGetOutgoingByChannelByUser(t *testing.T, ss store.Store) {
@@ -444,7 +444,7 @@ func testWebhookStoreGetOutgoingByTeam(t *testing.T, ss store.Store) {
 
 	result, err := ss.Webhook().GetOutgoingByTeam("123", -1, -1)
 	require.Nil(t, err)
-	require.Len(t, result, 0, "no webhooks should have returned")
+	require.Empty(t, result, "no webhooks should have returned")
 }
 
 func testWebhookStoreGetOutgoingByTeamByUser(t *testing.T, ss store.Store) {